Minor: not refreshing listbox

[Marco Artale]

TC7.5 b7

1. Open the search dialog and look for thumbs.db files from C:\

2. Use the "feed to listbox" button

3. Select all the list box and delete with F8

The bug is reproduced: the files are actually deleted but the list with selected files doesn't refresh. All the files are there still in list and red-selected.

Win XP Home, Celeron M processor, Fujitsu Laptop Amilo L1300, 1GB Ram

[karlchen]

Hello, Marco.

Cannot confirm.

Just tested it:
+ Searched for Autoruns???.arn files on the whole C: drive
+ T.C. found 4 of them in 2 folders
+ pressed the "feed to listbox" button
+ selected them all in the listbox
+ pressed F8 and confirmed
+ the files were deleted to the recycle bin
+ the listbox turnt empty immediately

Windows XP Prof SP2, 32bit
Total Commander 7.50 pb7

Kind regards,
Karl

[HolgerK]

Confirmed with:

Win95Delete=1
; "[x] Use explorer delete method (faster, cannot handle comments)"

TC7.50pb7 / Vista

Regards
Holger

[karlchen]

Thanks, HolgerK,

for pointing to the relevant setting. In fact, Win95Delete=0 is the active setting here, because I use file comments a tremendous lot. This is why I could not reproduce Marco's problem.

Cheers,
Karl

[Marco Artale]

Thanks, HolgerK, and apologies for forgetting that important setting.

[Balderstrom]

@karlchen, Yeah I use descript.ion's a lot too. But I hate the Delete Confirmation popup. So I use Explorer method delete.

The worst that happens is my descript.ion's contain stuff for files that no longer exist, when I happen to notice that
* I create a TEMP folder
* Drag/Move Files to TEMP folder
* Drag/Move Files back to Parent.
= Updated descript.ion

TC should still update the ListBox if you have all the relevant "refresh" options checked though, regardless of Delete method, No?

[karlchen]

Hi, Balderstrom.

Of course, I agree that Total Commander should refresh the listbox after deleting, no matter whether Win95Delete has been set to 0 or to 1.

I had only said "thank you" to HolgerK for finding out and reporting that the parameter which made the difference was Win95Delete. This was not meant to say that it should make any difference.

It should not. But it does.

Cheers,
Karl

[ghisler(Author)]

Sorry, this is a known limitation which cannot be fixed - TC isn't informed by the Explorer which files it deletes and which not.

If you use Windows Vista or 7, you can use VistaDelete=1 instead of the Explorer method.

[Balderstrom]

@ Christian, how can that be true?

If I have:

Config|Refresh|[ ] Auto Refresh, unchecked
Config|Copy/Delete|[x] Use Explorer Delete Method

And I select 10 files and press Delete Key (or Delete on the ButtonBar)
Those files are removed from the File List (TMyListBox#)

Feed to Listbox is also a "TMyListBox" class, yet in the same instance it does not remove those files from the list because it doesn't know you deleted them?

[Marco Artale]

@Christian

A solution could be:

Deleting the list box entry regardeless of the result and then poping up/printing a warning message that tells that some file could still be on the drive.

Does it sound good?

[ghisler(Author)]

Sorry, I prefer not to do that.

[Hacker]

Balderstrom,

Those files are removed from the File List (TMyListBox#)

This means rereading the contents of a dir.

Feed to Listbox is also a "TMyListBox" class, yet in the same instance it does not remove those files from the list because it doesn't know you deleted them?

This means repeating a search operation.

Roman

[Balderstrom]

@ Hacker, I'm not going to debate on code I can't see - but what you say doesn't make sense.

If TC re-read the whole directory, then deleting a file from a very large directory (with Explorer method & no refresh) would cause at least a brief flash, while the directory was reread and the scroll|next selected item was moved to the proper location. Whereas - even with thousands of files, deleting one file just pulls it out of the list, and the cursor is placed onto the next file.

You see this brief flash when "Refresh" options are enabled. You do not see this brief flash when they are not enabled, and you delete files.

But the fact that TC knows which files are selected, and knows you pressed delete. Means it could update the list. Even with Refresh enabled, it does not update the FeedToListBox list.

The Author chooses not to, and that's certainly acceptable, but stating something like TC (a file manager) doesn't know the files were deleted is... extremely odd to say the least.

[Hacker]

Balderstrom,
Well, I might have been wrong on the first point. Still leaves the second.

Roman