Total Commander

Sob · Power Member Joined: 19 Jan 2005 Posts: 626

There are clearly two things:

1) different heights in 32-bit and 64-bit TC - they of course should be the same and have the right height
2) the matter of what right height is

It seems to me that you complain about 1), because beta 9 broke it again. I'm after 2).

I wrote simple application to test if we're seeing the same sizes. It looks like this:

http://web.hisoftware.cz/sob/download/edit-height-test.png

Left column consists of sample edits with heights from font_weight+0 to font_weight+10. The used font can be set above, to compare with TC settings. The other two columns are screenhots of the first one from Windows 7 with Aero and Classic themes. So it's possible to compare if it looks the same as the first column (for default Microsoft Sans Sefif 8). I can't imagine it could have different heights (with exception of different DPI settings - I use defaults everywhere).

Rename edit heights I see in TC:

- TC 7.56a = +5
- TC 8.0 beta 5 (with differences between 32/64)
- 32-bit = +5
- 64-bit = +8
- TC 8.0 beta 6 (after making height the same - but still have problems with some font combinations)
- 32-bit = +5
- 64-bit = +5
- TC 8.0 beta 8 (new algorithm for calculating the height, does not depend on main window font)
- 32-bit = +4
- 64-bit = +4
- TC 8.0 beta 9
- 32-bit = +6
- 64-bit = +8

Now what the right height is. I believe it's +6 (*1). With +4 I was seeing in beta 8 there was no space between the text and borders when using Classic theme. With Aero and other themes, edits have only 1px borders (as compared to 2px in Classic) so there was 1px space there and it didn't look bad. But even with Aero, +6 looks better, because it makes the space 2px, which is the same as left space and if you look at higher edits (+7 and above), you can see the top space always being 2px, so I take it as the best value.

There's of course the question how it's possible that my +6 is different from TC's +6. If you could run my test application and check what you see (screenshots welcome), it might perhaps bring some clues (e.g. if it's system-dependent).

http://web.hisoftware.cz/sob/download/edit-height-test.7z (contains 32-bit Delphi 5 version and 64-bit Lazarus version)
http://web.hisoftware.cz/sob/download/edit-height-test-src.7z (source)

--
(*1) it is actually computed value, it just happens that it was 6 with all themes so far

gora · Posted: Mon Nov 14, 2011 5:31 am Post subject:

2Sob
I don't know that to you will give my screenshots, but here they:
http://gora.7zsfx.info/test/capture_001_14112011_152015.png
http://gora.7zsfx.info/test/capture_003_14112011_152209.png
It is in my opinion better to use +4 since it is necessary to remember also about the next line on the panel which is partially closed at the big height of edit box.

Sob · Power Member Joined: 19 Jan 2005 Posts: 626

gora · Posted: Fri Nov 25, 2011 8:50 am Post subject:

Fixed in 8.0β10.

ghisler(Author) · Posted: Fri Nov 25, 2011 8:56 am Post subject:

Did you check both the 32-bit and 64-bit version?
_________________
Author of Total Commander
http://www.ghisler.com

gora · Posted: Fri Nov 25, 2011 9:00 am Post subject:

Flint · Posted: Fri Nov 25, 2011 9:28 am Post subject:

Confirm, the 32- and 64-bit versions now show identical rename boxes, and both with correct sizes. Tested with several different fonts, did not notice any significant problems (of course, except for the gap at the beginning which is unfixable at the moment).
_________________
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, other stuff!

Using TC 8.01 / Win7 x64 SP1

Sob · Power Member Joined: 19 Jan 2005 Posts: 626

I like it too. :)

Well, if I wanted to nitpick, it still doesn't have the best vertical position (1px up would be better, because the text would not move down that way), but as it's just one pixel and it's the same as it was for the long time before and I didn't mind it back then, I'll be quiet. ;)