Bad text color in inplace rename from Sync dialog (32/64)

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Bad text color in inplace rename from Sync dialog (32/64)

Post by *MVV »

As I see, inplace rename window in Sync dialog uses same text color that TC panels use, and it looks ugly when user has bright text and dark background color for panel because Sync dialog uses Windows theme colors and not TC panel colors. In my case text in inplace rename window is almost invisible. TC8b21{x32/x64}, Win7ProSP1.

Screenshot
umbra
Power Member
Power Member
Posts: 871
Joined: 2012-01-14, 20:41 UTC

Post by *umbra »

Confirmed. Since Sync ignores other color settings, it should ignore font color too.
Windows 7 Pro x64, Windows 10 Pro x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

You are right, I didn't set these manually yet. I will change it in the next beta.
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

NOT fixed in beta 22!
In my TCb22x32 sync tool's rename window still uses grey font color.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I didn't change it to black and white, I changed it to COLOR_WINDOW background and COLOR_WINDOWTEXT for the text. Are these your windows color settings?
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

My TC and Windows colors are following: Screenshot. So, text color in inplace rename is the same as text color in TC panels (just like in previous beta) and not Windows default one (BTW my OS theme colors are visible in edit box on previous screenshot).
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

So the background color in the rename box is correct, but the text color is wrong?
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Yes, text color is wrong.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

That's strange, I double checked the Delphi form and it should be OK. I will try to set the color manually.
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

It is quite easy to reproduce:
1. Start TC with clean INI.
2. Set red text color for panels.
3. Open Sync tool and try to rename any file... Font will be red (w/o selection).
umbra
Power Member
Power Member
Posts: 871
Joined: 2012-01-14, 20:41 UTC

Post by *umbra »

It is fixed in 8.0 beta 23. However I think there is a typo in HISTORY.TXT
06.03.12 Fixed: Wrong text color in inplace rename edit box in multi-rename tool (file list text color instead of system text color) (32/64)
Shouldn't it say Synchronize directories?
Windows 7 Pro x64, Windows 10 Pro x64
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Yes, it is fixed in b23, thanks!

Shouldn't it say Synchronize directories?
Shouldn't it say Synchronize directories?
Agree.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Yes it should - thanks for confirming the fix!
Author of Total Commander
https://www.ghisler.com
umbra
Power Member
Power Member
Posts: 871
Joined: 2012-01-14, 20:41 UTC

Post by *umbra »

Shouldn't it say Synchronize directories?
Fixed in beta 24.
Windows 7 Pro x64, Windows 10 Pro x64
Post Reply