Hotlist: item is added to wrong submenu if \t used in title

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Hotlist: item is added to wrong submenu if \t used in title

Post by *MVV »

Steps to reproduce:
1. Add some submenus to hotlist (Ctrl+D).
2. Rename one or more of them and add tab character to title (e.g. copy it from Notepad) - tab characters are quite useful in menus since they allow to aligh shortcut keys.
3. Try to add some folder to a submenu (checkbox in add dir window). TC will show submenu with tab character in a title as two submenus, and if you add item to submenu that placed below that one, TC will add item to wrong submenu.

Test wincmd.ini (MIME-encoded):

Code: Select all

MIME-Version: 1.0
Content-Type: application/octet-stream; name="new.ini"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="new.ini"

W0Rpck1lbnVdDQptZW51MT0tc20xDQptZW51Mj0tLQ0KbWVudTM9LXNtMgkmMg0KbWVudTQ9LS0N
Cm1lbnU1PS1zbTMNCm1lbnU2PS0tDQo=
If you add any dir to submenu, TC suggests 4 submenus: sm1, sm2, 2, sm3. And, adding to submenu sm3 will fail (item will be added to root menu), addilng to submenu 2 will fail too (TC will add item to sm3 menu).

Tested with TC8RC1x32/64.
User avatar
ts4242
Power Member
Power Member
Posts: 2081
Joined: 2004-02-02, 20:08 UTC
Contact:

Post by *ts4242 »

Confirmed!

\t should be supported in directory menu as the main menu instead of using tab character which is difficult to insert manually without copy and paste.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Indeed the tabstop is used to separate items passed to that dialog now. I will change that to a line break. \t is currently not supported because people may be using full paths as menu entries. Changing this would break something like c:\test.
Author of Total Commander
https://www.ghisler.com
User avatar
ts4242
Power Member
Power Member
Posts: 2081
Joined: 2004-02-02, 20:08 UTC
Contact:

Post by *ts4242 »

It is not mandatory to use \t, you can use a switch character from the characters which cannot exists in path, like >t or |t
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

I think it is not necessary, and it may bring some problems anyway.
ghisler(Author) wrote:Indeed the tabstop is used to separate items passed to that dialog now. I will change that to a line break.
Thanks!
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Works perfectly in 8 RC2, thanks! :)
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks!
Author of Total Commander
https://www.ghisler.com
Post Reply