+[8.5b5] "Pause" is not working for DELETE

[ferhat]

environment: win8 64Bit
TC32 and 64

steps
1) select huge amount of files
2) delete them
3) while deleting is processed click on background
4) click on "Pause"

observed:
deleting is still processed. progress bar increases rapidly etc...

[ghisler(Author)]

Not confirmed, works just fine here! Are you deleting to recycle bin or directly?

[gdpr deleted 6]

I tested on a Windows 7 x64 configuration with TC8.50b5, and i can sort of "semi-confirm" the effect -- or at least an related effect.

What happens here is that when i press "Pause", the progress bar will stop only after a certain delay.

Whether this is exactly the same effect the OP experienced (just with a much longer delay, perhaps) i can't tell.

I did two tests, repeating both a few times.
In both tests i let TC directly delete approx. 22800 files in 530 folders (not into trash bin).
The selection in TC was comprised of 84 files and 71 dirs.

The first test was deleting from a NTFS-formatted RAM disk (imdisk).
The second test was deleting the same files from a much slower USB 2.0 hard drive, also NTFS-formatted.

In both cases, the delay from pressing "Pause" until the progress bar stopped was a little less to one second (guesstimate).

Also, when deleting only approx. 7800 files in 180 folders from the USB2.0 HDD, the delay did not change recognizably.

Since the delay in my case is so small, it does not have any consequence. Without paying attention to the progress bar, i would perhaps not even noticed the delay.

EDIT: I will repeat the tests with deleting into trash bin, but it will take some time...

[gdpr deleted 6]

Confirmed, when deleting into recycle bin.

TC8.50b5 x64
Windows 7 x64 Pro

Same test setup as described in my previous post, but i now recycle-bin-delete the files from a USB 2.0 HDD, and in another test also from a RAID-0 volume (2 HDDs, Intel Z77 chip-set RAID).

I can confirm the issue for both the USB 2.0 HDD, as well as the RAID-0 configuration. In neither case pressing the Pause button stopped the delete action.

After clicking Pause, it took another 5..15 seconds for the deletion to complete (time perhaps related to file cache condition/performance).

[ghisler(Author)]

I could finally reproduce it! The problem was that I had VistaDelete=0 in my wincmd.ini (for test purposes)...

[gdpr deleted 6]

Unfortunately, not really fixed in TC8.50b6 64-bit (running on Windows 7 Pro x64 with a fresh wincmd.ini).

The 32-bit version of TC8.50b6 doesn't seem to be affected by this issue and the Pause button works just fine.

However, pressing the Pause button in the 64-bit version of TC8.50b6 will result in a crash of some thread in TC (probably the background delete thread?).

TC will show the following error (albeit the error dialog might open behind TC's main window and must be ALT-Tabbed into the foreground):

Code: Select all

---------------------------
Total Commander 8.50b6
---------------------------
CheckSynchronize called from non-main thread "$30F8".
CheckSynchronize called from non-main thread "$30F8"
Windows 7 SP1 6.1 (Build 7601)

Please report this error to the Author, with a description
of what you were doing when this error occurred!

Stack trace (x64):4A8A5E
80D220 43D7E3 577314 7FEFD38BA3B 
Press Ctrl+C to copy this report!
---------------------------
OK   
---------------------------

After clicking the error dialog away, TC crashes hard with an Access Violation as shown in this screenshot:
Image: http://i.imgur.com/eRSa7zs.jpg

[ghisler(Author)]

Thanks for the report. I couldn't reproduce it so far, but it's a well-known Lazarus problem: It happens sometimes when calling application.processmessages from a background thread. I will replace it with my own MessageLoop call.

[ghisler(Author)]

Can you retry with beta 7, please?

[gdpr deleted 6]

Beta 7 works, thanks!