+Icon drawing damages file selection

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

+Icon drawing damages file selection

Post by *MarcinW »

Tested with Windows XP and TC 8.51 RC2 32-bit, with clean INI.


Steps to reproduce:
1) Create directory c:\test\ and place test.ico there (attached below).
2) Select file c:\test\test.ico.
3) Press Shift+F4, enter any name other than test.ico and close the Notepad.
4) Now, in many cases (randomly), selection is NOT drawn around the icon of the test.ico file.

5) Select the file created with Notepad and delete it.
6) Now as in 4) again.


It seems that there is a race condition between the icon drawing thread and the selection drawing thread. And the icon drawing thread, when executed later, damages selection frame that has been already drawn.

Regards

Code: Select all

MIME-Version: 1.0
Content-Type: application/octet-stream; name="test.ico"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="test.ico"

AAABAAEAECAAAAEABAAoAQAAFgAAACgAAAAQAAAAIAAAAAEABAAAAAAAwAAAAAAAAAAAAAAAAAAA
AAAAAAAAAAAAAACAAACAAAAAgIAAgAAAAIAAgACAgAAAwMDAAICAgAAAAP8AAP8AAAD//wD/AAAA
/wD/AP//AAD///8AAAAAAIAAAAAAAAAJgAAAAACAAAmAAAAAAJgACYgAmAAACYmbmQmAAAAAm7u7
mAAAAAm7AAu5gAAACbC7sLmIiJmbu7u7u5mQAAm7u7u5gAAACbsLC7mAAAAAm7u7mAAAAAkJm5kJ
gAAAkAAJgACQAAAAAAmAAAAAAAAACQAAAAD/fwAA/n8AAN5/AADOMwAA4CcAAPAPAADgBwAA4AAA
AAABAADgBwAA4AcAAPAPAADoJwAA3ncAAP5/AAD+/wAA

Code: Select all

MIME-Version: 1.0
Content-Type: application/octet-stream; name="screenshot.png"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="screenshot.png"

iVBORw0KGgoAAAANSUhEUgAAAqwAAAD4CAIAAACmICOvAAAAK3RFWHRDcmVhdGlvbiBUaW1lAFNv
IDEyIGt3aSAyMDE0IDAyOjEzOjQ4ICswMTAwZlz+DQAAAAd0SU1FB94EDAAOHj863moAAAAJcEhZ
cwAACxIAAAsSAdLdfvwAAAAEZ0FNQQAAsY8L/GEFAAAP2klEQVR42u3dS6gk13kA4GppFIi9CMFk
k00SQrJRIFrExIGge5WFyTJYwlo4m7Fl2UJeORAwnjAzIGNjgmMHZ6Od81AMEsoIbCJrYfXVIig7
BUuBEAjEcV7OwgSNHjP30a6+Z6an7j1V1fXo6qq+5/toin+qq6tPz+LWf/4659TszTdez+564cbL
GQCQhvvGbgAAMI5L8a6v/vWPx24VADA4lQAASJQkAAASJQkAgERd6n+K4bzzr3+xij/4a0+P3Zyd
bCEAVFEJAIBETboS0MR2+uJ9vqX42aL683T7FAA0pxIAAIna+UrA9IW+e9taQrdPAUBzKgEAkKhZ
/OyAza4Y2OTedn1/t/m79WeuOqbbebq1v74N/T8FAM2pBABAotaMCajqj8aa9+DD/rAN+zfVu23S
O4+/PT4yPqb+l7b9nxnuUwDQnEoAACRqTSUg7itXHdNct+Pre+f1mrS/z/n7nwEAtk8lAAAS1Wid
gKp6wK70d9vOy9ebByAFKgEAkKgWKwYW+8p9esndVsHbVE+9ai5A/29RSwBgt6gEAECidmDFwKqz
NV8VoP7bq45su3Zh29/S7XgA2BSVAABI1OCVAABgmlQCACBRkgAASJQkAAASJQkAgERJAgAgUWdm
Bzz4m789dnsAgC1RCQCARJ15dsD169fHbg8AsCUqAQCQqJKnCM7n87FbBUASvvn1r2S7PyIt1NGv
Xr06dkNaUwkAgESVVAKKedlb//SPYrFYLBYPFBfFe3bRbv0KlQAASFRJJWAKuaFYLBaL04kZi0oA
ACSqpBIwndxQLBaLxRc7ZlwqAQCQKGMCxGKxWDzResBvPPSRbJ3iE3CmrOq3xO0vHjn0r1MJAIBE
DTgmYDabrc4ZcpniMcVMZ7FYbPB7xWKxWLwrcXOb6hNvs59d/41hf9gW92+ztqESAACJGnBMQFEx
0wnHFE0nJxWLxWLxlOsBF8kURjOoBABAolqPCYj79FXHx6ryvinkoWKxWCze9RpAfPe9fgRAfD9+
Cup/RSweZ1B/TJFKAAAkqsWYgGJ+0aQeEAvzBcJcgKL67yoqziNoMn80qJ+bUHX+KeTIYrFYnELc
RPx3u38Pfjs1gGJvvtuvqF9LIN7TZA5CoBIAAIlqNCagqt9cXw+oEud98Wer+u5VtYT4rkk4Jhxf
bGfV+gTx+aeTI4vFYvFFjZtr3mOO+9xTuOtf1ZtvOy6hye9qXilXCQCARK0ZE9Akm6iqBxTF/fKi
5rWH4vFxm9seU1zTsL49YrFYLJ5CPSBlzWsbzesKKgEAkKg1YwKK/fu431x/7zw+Z7EeUFRVA6ia
C9Ct319Vn5hOLiwWi8WpxZtVNcN+3PUA+o9O6HOG+s+qBABAolqsExBrnt81P0/z/fH5ux0T1zma
rIcoFovF4m3WA9quhVdl+xWC/usE1P8/hDN0+xaVAABI1KyYHbxw4+V8+9gf/H5Wlq+1HRNQ37eu
uvdf9V3x98bnr1onIG5D1fnVAMRisXj7NYDhRglsR7h6Xr16ded+hUoAACRqwDEB9XWC+j53k3H7
8THxOavOY16AWCwWTydmLCoBAJCoRs8OaNJ3F4vFYrFYDWC3qAQAQKJajAkQi8VisVg94CJRCQCA
RJWsEwAApEAlAAASVTImYD6fj90qAGBwKgEAkKhLVW/M5/tjtw0AGJBKAAAk6lL/Uzz55H+t4mef
/cWxfxEA0IhKAAAkqlcl4NOf/s98+/TTn1vtuXXra/n2W9/6lbF/FwCwhkoAACSqYyXgiSd+lG8/
85nP5tvDw8PV/qeeeup0z5/n2+ee+/VW54znI+zvzzu0bVPnAYDtqJ+RV3UVK36qeEyT+X3heJUA
AEhU60rApz71H6fbJ7KzNYBifPny5dM9z+bb559/sEOz+vTdw2etcwDALor79GHb7coYf6p4TpUA
AEhUi0rAJz/5w3z7iU/8Yb69ffv2an+oAYQ9Yfv+++/n20cfffT03W/n2xs3Hhr7lwLAyKru4lcp
1rb71AOqqAQAQKIaVQIuX/73fPuxjy179m+//fZq/wMPPJBvj4+PV/vfe++97Gyd4LHHHsuW9YC/
zbff/e6Hx/69ADCCtjWA7VAJAIBENaoEnJycZMtx/s/n26Ojo+xu7//xxx9f7XnnnXey5YqBt/Lt
K6+8svpseBcA0jRuDaBqrpx1AgAgaY0qAfGzAD7+8X/O7s4CCLMDwmiAEIfKwXe+81tj/zoAGM0U
xgFYJwAAKNHx2QFhTMC7776b3e39hzEBYX/YAkDKhp7l359KAAAkqlcloDgOIGyLlYCPfvQfsrOz
A0L82mu/N/avBoAt6VMPGHpUgUoAACSqVyWgODug+BTBhx9+ON/ef//9q23w0ksvdfiuJs9Lntpd
FgAoal4PiGf2D3eNUwkAgET1qgSEGQGhBhCqAkGxKlCsBHSbNVCVAen9A7BbNntF63a24rsqAQCQ
qF6VgJs3b2Z3x/wXZwGEJwjE/f7mlYA+8ymr1kkGAIpUAgAgUR0rAd/73u9ky3v/r632xOsBxHF4
pkCVTd3jN1YAAJpQCQCARHWsBATf//7DY7cfAOhIJQAAEiUJAIBESQIAIFEtxgT86V99LlvO9V+O
8D8+Wm6PjheF+HR7eG8lgNu3l3v+7At/OfZvBABK9BoYWOMrf/TLIfjauiNn2bWx/xMAIEUtkoCj
0x7/Zx//hZpjfvTf7z/4qz/bqgWL0yRAKgAAW7axSsDPfWC23Hb9+OJuEiAbAIDtaF0JiIXL/6Yo
DADAdvSdHbDZDGBlIQkAgIH1qgTUZwA//sly7sDh6aMDHjj9ns9f/0G+/Zuvv7g6puZin7+lHgAA
w+k4JqD+8v/MN/8t3z7Z4DzhMl+VCrg1AADDaVMJOLxTCajKAP7/3cX//t/tPLj57R/m27/7+//J
7lYCPviB5X2HxaL8zKvLfGk2oCQAAENoPSagJgPo35pZbUkAANigVmMCjr/8+V8qfWuVAXzo538m
3/7uhz+Ub28dnjQ+9z0H8/ne/n68P64HzOf7pWfY35+f29P8SABIR4tKQGkGkF/+N1IDKMrzgPwV
71cPAIANmr35xuurf7xw4+Vs2W+eZ1HvufQCXLz8Hx6ef/d2Yc/R6ciAL3x5OTvguW+8mDVT+qU1
4wOKba7v5Tc/EgAuqkaVgLUZwEBmFeMEh/5eAEhBxymCxQwg7vEHx/ceKJjNGi8pdK4CcZCVDxHI
qu/09zkSANKxvhIQ97y3UAMoiscHKAYAQH9rKgHx5fYnNxfZ3VH/xX5/cHJSHsdHxqru0+f74ykD
ecMOsnl8ZPNzbvy/EgB2S99nBwAAO6ouCYjLAE/9yb8cn2Slr1u3l6/F4t4rPqaP+KZA1VgBAKCJ
FpWAPAMYt62liwcAAN1UjgmIywDhKYInhTH/952O+a+aHRAfWS/csw936xves9/LP1ObGXQ4JwAk
orwS8Gp0ZZ3II3ziZrgpAADdtHp2wLIScFwx5j8e/3/ccnZA0GH9vrUfsSYgAMQajQmYSBlggo0B
gN1VkgS8WnGX/ejoJH+dHGer132z5Svv5a86+iEOr/jdgVg7CAA6WF8JmGDPe4JNAoCdc35MwNVr
16oOPTlZrhb8x1/6wdhtLrHIrskMAKCVNZWAyV5ZJ9swANgVLWYHPPeNF8duLQCwMWcqATX3AqbP
8EAAaKWuEtCq5B6uwd2q9GHVv729vXx7cHDQMM72rmaz6/3PIxaLxWJxmrGnCAJAomZvvvF6iB58
6CPn32tfCfjSM8/k2ytXBl4Z4OyXdm4zAKSsshKwE1fTnWgkAExTi9sBebe78+C7Pp8FAIZgTAAA
JKrFOgGh9l6cBXCmc79cTjD74uzKchsdH8YKZNsaKwDAzpnP91exp79ux51KQDwqcEe56QAADd2Z
HXAuCXgkz8EKGVnszrV2UX/u5ab5fIHOOeC5C3/9aEGZJgAExgQAQKJajAkI4hrA7LTHv1icj4uj
BLLtrh8AAKylEgAAiWpdCYgtFuVxH+HOffGefdUYhfi+fnxk1b3/+FsAGEvVmK0+f/+rjiRQCQCA
RK2pBJTMuGvb14/WDwjqx/BX5YDx/uV2v/IM944pywTlhgBTtv7v/9m/9k2OpEglAAAStaYSEPfX
F7PTPfFcgOKnivsLqwUUhX+3nS9Qv3pBfKS8D+Di8bd9U5aVgAuzXCAA0NyyEvDWG68X84BH9vcb
fri4NkC8P9Z/nYDS7G9Rdoz7QABQr2RMwKvz+ditAgAG13qdgDvPBiyMDKhcG6DlswPaujc+YL9k
v3oAwEXlKTCbYnYAACSq9VMEw8oBoX//xStXim+cnq9w6lAzKBzf51mCNetAnVvM4CC6nVG/qpQs
EmAKrBi4fSoBAJCoFpWA+j598d2geEzbekAr5yoB9WsRAgCBSgAAJKrF7IDm/fj4mDu98wHmCAAA
3agEAECiyisBr87ns+jZfEPM9e9vYQQAAHRypxLw1unwwAvAqEAAaKj1ioFVwtX3mU6fXZwuOnhw
cJBv9/b2WsXnChb5qbqdRywWi8Xi1GJjAgAgUXfWCciipQJ2pa5ukQAA6KayErATA+52opEAME33
koALMDZQGQAAmjMmAAASVZcETLzYPvHmAcDEnUkCrl+7NnZ7unMvAABacTsAABK1JgmYbMl9sg0D
gF1xPgnY0TsC7gUAQFvrbwdMsM89wSYBwM4pSQIe2d8fu1XtKAMAQAeNBgZOquc9qcYAwO4yOwAA
ElWeBMR3BCbS/46b4V4AAHRTWQnYiYvrTjQSAKapxe2A0YsBozcAAC6SuiQg7mePeBl2IwAANsvA
QABI1JokYCLFAGUAANi49ZWA0fMAGQAADKHj7YCt5QEGAwLAQBolAaU97y1cnku/QhkAADaiaSVg
+3mADAAABtXidkBVHrDxVKDqnDIAANigdmMCqi7DG8wDqk4lAwCAzWo9MHDQPEAGAABbc6nDZ2YV
5frVzrbX7PoEQgYAAEPokgRkdy/Mi9qqQJOLt8s/AIylYxIQzGpHBfa8QSADAIBB9X12wECXahkA
AAytVyUgqL810O1sAMDQNpAEBKuLd7dswLUfALZsY0nAStvCgMs/AIxi80lA4NIOABPXd2AgALCj
JAEAkChJAAAkShIAAImSBABAoiQBAJAoSQAAJEoSAACJkgQAQKIkAQCQKEkAACRKEgAAiZIEAECi
JAEAkChJAAAkShIAAImSBABAoiQBAJAoSQAAJEoSAACJkgQAQKIkAQCQKEkAACRKEgAAiZIEAECi
JAEAkChJAAAkShIAAImSBABAoiQBAJAoSQAAJEoSAACJkgQAQKIkAQCQKEkAACRKEgAAiZIEAECi
JAEAkChJAAAkShIAAImSBABAoiQBAJAoSQAAJEoSAACJkgQAQKIkAQCQqJ8CzKWZs1ez+aoAAAAA
SUVORK5CYII=
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Confirmed for TC 8.51RC2 32bit, but not 64bit - and only with inverted cursor disabled.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4622
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Post by *white »

Confirmed for TC8.51rc2 32bit
Confirmed for TC8.51rc1 32bit

Not confirmed TC8.51b5 32bit

Perhaps related to:
HISTORY.TXT wrote:01.04.14 Added: Reduced flickering of current item in listboxes by re-drawing loaded icons manually instead of invalidating the rectangle (32/64)
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I could reproduce it too, thanks!
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4622
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Post by *white »

Tested OK using TC8.51rc3 32bit.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks!
Author of Total Commander
https://www.ghisler.com
User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Post by *MarcinW »

Problem fixed in 8.51 RC3 32-bit, thanks!
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Confirmed fixed in TC 8.51 RC3 32bit :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Post Reply