FXP Sequrity BUG!

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
Isica
Junior Member
Junior Member
Posts: 38
Joined: 2013-09-24, 05:07 UTC

FXP Sequrity BUG!

Post by *Isica »

When copying a file on the server (Shift + F5), a second connection to the server is always created in plain text!
----------
Connect to: (21.04.2015 3:14:59)
hostname=195.2.x.x
username=debug
startdir=
220 FTP Server ready.
AUTH TLS
234 AUTH TLS successful

Cert subject: /C=RU/ST=Moskow/L=spb/O=Default Company Ltd/CN=breezfm.ru/emailAddress=admin@breezfm.ru
Cert issuer: /C=RU/ST=Moskow/L=spb/O=Default Company Ltd/CN=breezfm.ru/emailAddress=admin@breezfm.ru

USER debug
331 Password required for debug
PASS ***********
230 User debug logged in.
SYST
215 UNIX Type: L8
FEAT
211-Features:
MDTM
MFMT
TVFS
UTF8
AUTH TLS
MFF modify;UNIX.group;UNIX.mode;
MLST modify*;perm*;size*;type*;unique*;UNIX.group*;UNIX.mode*;UNIX.owner*;
PBSZ
PROT
REST STREAM
LANG zh-CN;es-ES;zh-TW;ja-JP;ko-KR;en-US*;fr-FR;bg-BG;it-IT;ru-RU
SIZE
211 End
PBSZ 0
200 PBSZ 0 successful
OPTS UTF8 ON
200 UTF8 set to on
Connect ok!
PROT C
200 Protection set to Clear
PWD
257 "/" is the current directory
Get directory
TYPE A
200 Type set to A
PORT 93,72,y,y,18,239
200 PORT command successful
MLSD
150 Opening ASCII mode data connection for MLSD
Download
Waiting for server...
226 Transfer complete
----------
Connect to: (21.04.2015 3:15:29)
hostname=195.2.x.x
username=debug
startdir=
220 FTP Server ready.
# AUTH TLS Command is ABSENT!
USER debug
331 Password required for debug
PASS *********** # Open Text Password Send!!!
230 User debug logged in.
SYST
215 UNIX Type: L8
FEAT
211-Features:
MDTM
MFMT
TVFS
UTF8
AUTH TLS
MFF modify;UNIX.group;UNIX.mode;
MLST modify*;perm*;size*;type*;unique*;UNIX.group*;UNIX.mode*;UNIX.owner*;
PBSZ
PROT
REST STREAM
LANG zh-CN;es-ES;zh-TW;ja-JP;ko-KR;en-US*;fr-FR;bg-BG;it-IT;ru-RU
SIZE
211 End
OPTS UTF8 ON
200 UTF8 set to on
Connect ok!
CWD /1112
550 /1112: No such file or directory
CWD /
250 CWD command successful
PWD
257 "/" is the current directory
Get directory
TYPE A
200 Type set to A
PORT 93,72,y,y,18,241
200 PORT command successful
MLSD
150 Opening ASCII mode data connection for MLSD
Download
Waiting for server...
226 Transfer complete
TYPE I
200 Type set to I
TYPE I
200 Type set to I
PASV
227 Entering Passive Mode (195,2,x,x,191,200).
PORT 195,2,x,x,191,200
200 PORT command successful
STOR 1112
150 Opening BINARY mode data connection for 1112
RETR 1111
150 Opening BINARY mode data connection for 1111 (1 bytes)
226 Transfer complete
226 Transfer complete
Copied (21.04.2015 3:15:32): 1111 -> 1112 1 bytes, 0 bytes/s
QUIT
221 Goodbye.
Get directory
TYPE A
200 Type set to A
PORT 93,72,y,y,18,242
200 PORT command successful
MLSD
150 Opening ASCII mode data connection for MLSD
Download
Waiting for server...
226 Transfer complete
Last edited by Isica on 2015-04-25, 01:18 UTC, edited 1 time in total.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48118
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

???
This isn't a bug, that's how FxP works - it's a connection between TWO servers. When you copy within the same server, you still need a second control connection (for the target).
Author of Total Commander
https://www.ghisler.com
Isica
Junior Member
Junior Member
Posts: 38
Joined: 2013-09-24, 05:07 UTC

Post by *Isica »

I know how to work FXP :)
The problem is that the second connection to the (same) server is done in plain text!

PS
Generally, FTP (and FXP) has many problems. It may be worth to discuss them in a particular topic?
User avatar
Sir_SiLvA
Power Member
Power Member
Posts: 3300
Joined: 2003-05-06, 11:46 UTC

Post by *Sir_SiLvA »

Isica wrote:Generally, FTP (and FXP) has many problems. It may be worth to discuss them in a particular topic?
No its not cause Chris stated more than once (use the search) that the fpt support is only small and he want change it cuase there is software out there for ftp stuff.
Sob
Power Member
Power Member
Posts: 941
Joined: 2005-01-19, 17:33 UTC

Post by *Sob »

TC's FTP client may be basic feature wise and it's fine. But this really is security bug.

You connect to encrypted ftps://yourserver.tld, because you don't want your password sniffed by anyone. Then you want to copy some file on server using Shift+F5 and TC needs to open another connection to the same server to do that. But this time, it uses plain ftp://yourserver.tld without encryption.
User avatar
Horst.Epp
Power Member
Power Member
Posts: 6509
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Post by *Horst.Epp »

Sob wrote:TC's FTP client may be basic feature wise and it's fine. But this really is security bug.

You connect to encrypted ftps://yourserver.tld, because you don't want your password sniffed by anyone. Then you want to copy some file on server using Shift+F5 and TC needs to open another connection to the same server to do that. But this time, it uses plain ftp://yourserver.tld without encryption.
FXP is between two servers and not between your TC and a server.
Sob
Power Member
Power Member
Posts: 941
Joined: 2005-01-19, 17:33 UTC

Post by *Sob »

Data connections yes, control connections no. Both control connections are established by TC. The problem here is second control connection, because it skips AUTH command and just sends the password in plaintext.

Original poster already described it well, just look at the log (hint: the colored parts ;).
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48118
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

This was fixed in TC 8.52 beta 1, but FxP may still not work, depending on the server. The fix only fixes the login problem.
Author of Total Commander
https://www.ghisler.com
Sob
Power Member
Power Member
Posts: 941
Joined: 2005-01-19, 17:33 UTC

Post by *Sob »

Confirmed. Sorry for being a little late.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48118
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks!
Author of Total Commander
https://www.ghisler.com
Post Reply