[9.0ß1] Tab icon does not move with text on switching

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

[9.0ß1] Tab icon does not move with text on switching

Post by *Flint »

The active tab is drawn a bit above the others. So when you switch between tabs, the title text of the tab moves 2 pixels up when its tab becomes active, and drops back down when it becomes inactive. However, this does not happen with the icons drawn next to the text. It breaks the whole impression of the 3D movement design.

OS: Windows 7 SP1 x64
TC 9.0β1 32- and 64-bit
Last edited by Flint on 2016-06-09, 09:57 UTC, edited 1 time in total.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48104
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Hmm, not sure about that - to me it looks better when the icon remains in place...
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

I've also noticed that it looks strange. Tab title moves to imitate tab header activating but icon remains on the same place as if it is detached from tab header.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48104
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

OK, I have checked this - TC draws the icon itself, centered vertically on the tab. This is necessary so TC can draw a different tab header background _below_ the icon. The problem is that Windows returns the same tab header rectangle for active and inactive tabs. The text is drawn by Windows.
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Looks better in 9.0b2, thanks. :)
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

Post by *Flint »

Indeed, confirm fixed in β2.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48104
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I just move it up by 2 pixels, that's how the text seems to move too, independent from the display DPI...
Author of Total Commander
https://www.ghisler.com
Post Reply