[9.0b1x86] Too flat interface

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: white, Hacker, petermad, Stefan2

User avatar
petermad
Power Member
Power Member
Posts: 14807
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

The status bar looks almost as if it was another directory in the list
Exactly - that why I also suggested this: http://ghisler.ch/board/viewtopic.php?p=311426#311426 - Also when not using classic theme - look at the image in my post - it is the same problem with themed Windows when using wincmd.ini parameter TabHeaderThemed=0 - and always a problem with the status bar - themed or not.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

It's not so simple - there was a border around the listbox which I removed because it could only be drawn with the 3D sunken effect. That border is now missing at the bottom too. I could draw something on the status bar, but it's not clear what color should be used there so that it's compatible with all themes.
Author of Total Commander
https://www.ghisler.com
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

Post by *Flint »

ghisler(Author)
What did you use for the column headers delimiter? I think the same might be used for status bar.
If that does not work for some reason — maybe another parameter under [Colors].
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
j7n
Member
Member
Posts: 168
Joined: 2005-08-07, 21:56 UTC

Post by *j7n »

The lines around the main toolbar and the separators within it do look inconsistent with the sunken status bar and Explorer, Office and other standard software on 2000/XP.

The option "Flat user interface" toggles between sunken and grey everywhere – except – the main toolbar. Unflat should allow the sunken borders.

Comparison with other software (EmEditor is even fairly recent – made in 2012)

All other toolbars look like they have nice metallic hi-fi finish with a groove, whereas TC has grey paint that is about to rub off. The 2px lines do not look as dark to me, because the opposite colors partly cancel out.

Why write four pages of complaints? I consider this thread a revolt against "flat design".

To be true to the classic theme, a depressed button should also have a lighter color, inbetween 3D 'face' and 'highlight' (white), but I can accept that it is not due to TC being a custom Delphi program.

Image: http://i.imgur.com/cThFdWV.png
#148174 Personal license
Running Total Commander v8.52a
Sob
Power Member
Power Member
Posts: 941
Joined: 2005-01-19, 17:33 UTC

Post by *Sob »

Don't forget, the original "flat" and "non-flat" was a little different from what we have now. These new 1px lines are like "ultraflat" - hated equally by all Classic fans, no matter if they prefer flat or non-flat. ;)
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Sob wrote:These new 1px lines are like "ultraflat" - hated equally by all Classic fans, no matter if they prefer flat or non-flat. ;)
+100

Classic interface should conform classic styles but now it doesn't. And screenshots by j7n show it.
The most interesting thing is that both Delphi and Lazarus are already able to draw necessary borders (for TToolbar, TPanel etc) so there is no need in any additional painting...
User avatar
petermad
Power Member
Power Member
Posts: 14807
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

History.txt
14.08.16 Added: Re-added horizontal border between listbox and
footer when using themes, using top line of tab control (32/64)
Thanks! - now we are almost there :-)

But when [Layout]TabHeaderThemed=0 is used we still ned a line between the tab header and the listbox - for the same reasons as we needed the line between the footer and the listbox - see: http://madsenworld.dk/tcmd/top-panel-line.png
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
petermad
Power Member
Power Member
Posts: 14807
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

But when [Layout]TabHeaderThemed=0 is used we still ned a line between the tab header and the listbox
Fixed in TC9b11 - Thank You! :-) :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Hacker
Moderator
Moderator
Posts: 13065
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Post by *Hacker »

Move to Fixed?

TIA
Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
User avatar
petermad
Power Member
Power Member
Posts: 14807
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Move to Fixed?
I don't know if the other particepants issues with classic theme are all fixed.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

There is still a border issue in classic theme that is not 'fixed':
- classic borders are not classic now but 1-pixel flat
- there is no border between status bars and F-buttons when command line is hidden
- there is no border between status bars and command line when command line is not hidden.
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Another thing that is not 'fixed' is path bar style inconsistency: it has border when tab header is visible but no border when tab header is absent.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Not confirmed. It has its own (sunken) border when there are no tabs, and uses the tab control borders otherwise.
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

ghisler(Author) wrote:uses the tab control borders otherwise
That's what I'm talking about. It should use same nice sunken border in both cases (in case of classic theme of course). When I add extended style 0x20000 for TPathPanel in case of tabs, it looks perfect.

Controls with different backgrounds are never placed together w/o any borders in classic 3D look.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

The tab control is drawn using Windows theme functions, so I can't just change its colors.
Author of Total Commander
https://www.ghisler.com
Post Reply