Exclamation mark on hid/sys items is okay but not by default

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

User avatar
petermad
Power Member
Power Member
Posts: 14796
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

If overlay is supposed to work TC shouldn't use "exclamation icon" and draw on it but rather just draw on standard file icon.
I agree.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Lefteous wrote:- There should be a way to provide a custom overlay
I think it would be nice to be able to override only specific TC icons, not only full iconlibs, and in such case there will be a way to provide a custom overlay icon.

petermad,
Agree, and that's how I suggested it (ShowHiddenSystemOverlay=0 and ShowHiddenSystemOverlay=2).

ghisler(Author),
Since there is an option to show dimmed icons, TC should support hiding !'s at all even with iconlib (or OldListIcons=1).
Here I've suggested three modes, one for old behaviour (ShowHiddenSystemOverlay=1) and two new ones (ShowHiddenSystemOverlay=0 and ShowHiddenSystemOverlay=2).
I think you could add third grayed state for "!" checkbox for old behaviour, so states would be: unchecked - do not show "!" at all (for fans of dimmed icons); grayed - show "!" using icons from iconlib, pure old behaviour; checked - draw overlay "!" over real file/folder icons (as it is for system icons now).
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48079
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Currently this "!" option only works correctly when using "Show default folder/file icons from Explorer". I have already modified the operation when this is turned off, so please wait for beta 11 to test that. For example, currently TC uses both the icon library "file with ! on it" overlayed with the separate "!" icon, which is of course incorrect.
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Custom icons are now displayed correctly with ! overlay, thanks!
However it seems that ! overlay for folder icons are still not used in case of icon libraries with overlay icon (tested with IconLib=%COMMANDER_EXE% and with this lib).
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48079
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

This isn't a bug: When you use a library, and the library does NOT contain a separate "!"overlay icon, then TC will use the special icon for hidden/system folders instead (just like TC 8.x did). The 12th icon in the lib (index 11 if counted from 0) does not contain an ! but is slightly dimmed.
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

How can we make a library with separate overlay icon? Isn't it the icon with index 50? In my tests both libraries (custom lib and TOTALCMD.exe) have that icon but TC doesn't use it anyway...
User avatar
petermad
Power Member
Power Member
Posts: 14796
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

2MVV

I can confirm that overlayed '!' doesn't work with you library https://yadi.sk/d/38qKJdNPuWR8A

I have made this library: http://madsenworld.dk/tcmd/totalcmd64b.icl

It is generated from totalcmd64.exe from TC9B11 - and thereafter I have replaced icon number 11 (folder with !-mark) with icon number 1 (plain folder), and icon number 15 (folder with !-mark) with icon number 13 (plain folder) - so there are no folders with '!' in the library, AND this library does contain the '!' overlay (icon 49 and 50).

It also doesn't show overlayed '!' on icon 15, as MVV's library doesn't.

The overlay '!' only seems to work for custom icons (via Desktop.ini) in TC9B11
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Nice, beta 12 does it in a right way! Thanks! :)
User avatar
petermad
Power Member
Power Member
Posts: 14796
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

TC9b12 now shows '!' as expected in all cases when OldListIcons=1:

If no iconlib is defined: '!' is overlayed with TC's internal overlay
If iconlib with '!' icon inside it (icon 49 and 50) is defined: TC overlay with '!' from iconlib.
If iconlib without '!' icon inside it is defined: TC uses icons with integrated '!' from iconlib (icons 9,11, 15, 18).
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48079
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks for the detailed test! Yes, that's how it should be now.
Author of Total Commander
https://www.ghisler.com
Post Reply