[Fixed] Deleting a file on a network share disables...

Post by *ghisler(Author) » 2016-10-14, 17:02 UTC

I'm really sorry but I cannot reproduce it. It also doesn't make any sense why this would happen.

redfox · Post by *redfox » 2016-10-19, 10:42 UTC

I finally found the cause of the problem:

It was the Copy/Delete: Use Explorer delete method in the Settings.

After I disabled it, the bug never occured again.

Mr. Ghisler, please fix it in a next release. Thank you.

Tested on Win7 SP1/32.

Dalai · Post by *Dalai » 2016-10-19, 12:28 UTC

2redfox
It's always a good idea to check whether or not a misbehavior (or bug) also occurs with a clean wincmd.ini:

Code: Select all

totalcmd.exe /i="%temp%\fresh.ini"

That way any configuration settings can be ruled out.

Regards
Dalai

redfox · Post by *redfox » 2016-10-19, 13:41 UTC

Dalai: Of course, I did it, but the difference between a fresh and fully updated config file is huge. You still have to eliminate possible causes one by one.

Btw., the default delete method of TC is really slow, when you delete subdirs with many files - every file is deleted separately. The Explorer method does not do it, it just deletes a dir with all files at once, which is much quicker. Once Mr. Ghisler fixes the said bug, I'll revert to it.

Post by *Hacker » 2016-10-19, 14:48 UTC

redfox,

the default delete method of TC is really slow

Try disabling Configuration - Options - Operation:
- Calculate space occupied by subdirectories [ ] before copying / deleting
- [ ] Copy comments with files.

Roman

redfox · Post by *redfox » 2016-10-19, 20:47 UTC

Hacker: As I wrote in another thread recently, disabling the "Calculate space occupied by subdirectories" also disables the second progress bar when copying files. So I don't recommend doing it.
We are a bit off topic here now..

--

I just read the changelog of TC 9 RC2, but the mentioned bug (Wed Oct 19, 2016 11:42 am) was not fixed yet. I hope that it will be done later.
Disabling the "Use Explorer delete method" is only a temporary workaround.

Post by *ghisler(Author) » 2016-10-19, 21:26 UTC

I finally found the cause of the problem:

It was the Copy/Delete: Use Explorer delete method in the Settings.

I cannot reproduce that, Explorer delete works just fine here!

Are you able to reproduce it with a fresh wincmd.ini where you only enable the Explorer delete method?

redfox · Post by *redfox » 2016-10-19, 22:29 UTC

ghisler(Author) wrote:
I finally found the cause of the problem:

It was the Copy/Delete: Use Explorer delete method in the Settings.
Are you able to reproduce it with a fresh wincmd.ini where you only enable the Explorer delete method?

Yes, of course.

The Explorer delete method has a longer delay (until a single file is deleted) in my network share than the standard TC method, approx. 3.5s vs. 2s. It might cause the described problem.

Post by *ghisler(Author) » 2016-10-20, 13:49 UTC

You wrote in a previous post that it worked OK in beta 10. Is this still the case? If yes, I tried to find changes between beta 10 and RC2 which could cause this, but there are far too many (>200). I checked the most relevant files, but couldn't spot anything relevant.

So it would be extremely helpful to know up to which beta version it works with Explorer delete, and where it stops.

You can find old betas here:
http://www.ghisler.com/900_b10.php
http://www.ghisler.com/900_b11.php
http://www.ghisler.com/900_b12.php
http://www.ghisler.com/900_b13.php
http://www.ghisler.com/900_b14.php
http://www.ghisler.com/900_b15.php
http://www.ghisler.com/900_b16.php
http://www.ghisler.com/900_b17.php

redfox · Post by *redfox » 2016-10-20, 16:59 UTC

ghisler(Author) wrote: So it would be extremely helpful to know up to which beta version it works with Explorer delete, and where it stops.

Already done that 2 days ago, all results the same.

ghisler(Author) wrote:You wrote in a previous post that it worked OK in beta 10.

Yes, but it was because the beta 10 I tried had a fresh wincmd.ini with Explorer method disabled (default).

Post by *Hacker » 2016-10-20, 18:18 UTC

redfox,

I downloaded and tried all betas from 10 to 17, with the same result: When the Explorer delete method enabled, the bug is present.

So we still do not know in which beta the bug appeared.

Roman

redfox · Post by *redfox » 2016-10-21, 10:27 UTC

I did the whole testing again, since I did it previously in Sandboxie, which had different results (network shared files were stored locally in the sandbox, so the bug could not occur in any version).

So, the last good version is TC 9 beta 11. The b12 and newer have the said bug. I tested only the 32 bit version.

If I look into the old b12 changelog, I should remind you that the bug is not present when the file is deleted via right click context menu, only through keyboard del key or the f8 button, as I wrote before.
This entry looks suspicious:

31.08.16 Fixed: Refresh only active panel after deleting file via right click context menu, and the other panel showed a different drive (32/64)

Post by *ghisler(Author) » 2016-10-21, 16:32 UTC

Thanks for checking. That bugfix only prevents TC from re-reading the other (inactive) panel. In older versions, it simply refreshed both panels.

redfox · Post by *redfox » 2016-10-30, 09:06 UTC

I just installed the RC3 and the bug seems to be gone. Did you change anything intentionally, Mr. Ghisler? It was not listed in the changelog.
Thanks.

Post by *ghisler(Author) » 2016-10-31, 20:19 UTC

Yes, I reverted one change I made in beta 12 (where I changed a SendMessage to a PostMessage call). I didn't notice any change, so I didn't document it. I hope that this really solves your problem! Please keep me informed.