TCMP queue: file can't be added via Open with after removing

Support for Android version of Total Commander

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

TCMP queue: file can't be added via Open with after removing

Post by *DrShark »

To reproduce:
1. Add a file to a TC Media Player using TC4A file context menu item Open with by selectong TotalCmd (queue) as an app. For some files like *.oga (OGG audio) which TC doesn't recognize as a media it will be the only way when using a context menu.
2. Remove this file from a queue playlist (playing is not necessary).
3. Try to re-add it to queue by repeating step 1: the file won't be added to queue playlist.
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

The player includes a function to avoid that you add the last added file again.
Author of Total Commander
https://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Post by *DrShark »

ghisler(Author) wrote:The player includes a function to avoid that you add the last added file again.
Please consider to remove this limitation.
Also once re-adding of such a file using Open with -> TotalCmd (queue) caused removing all other tracks from queue (which made playlist empty.) If I will manage to reproduce it, I will make a separate topic.
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

The problem is that when you re-open a form, Android often passes the "intent" with the file name again to the activity. This resulted in duplicated tripled etc. tracks.
Author of Total Commander
https://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Post by *DrShark »

ghisler(Author) wrote:The problem is that when you re-open a form, Android often passes the "intent" with the file name again to the activity. This resulted in duplicated tripled etc. tracks.
You mean that each time file is re-opened 1 more copy of it added by Android to the playlist? I don't see it as the serious issue (it may be a feature). Anyway, maybe you can try to allow the re-adding only if the file was previously removed from queue playlist?

Or by saying "duplicated tripled etc." you mean that Android adds random number of tracks with that file to the playlist?
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

No, each time the user switches back to the player, it receives the intent again, and the last added file would be added again.
Author of Total Commander
https://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Post by *DrShark »

Maybe then you can modify Remove track function so it will visually hide it instead of removing from queue playlist? From user point of view it will still work like current removing (such hidden tracks even won't be exported to file playlist) but when user will try to re-add the previously removed (hidden) track TC Media Player will just show it?
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Post by *DrShark »

I see that "Add to queue" file context menu item allows to add many tracks of the same file (which means the track removed from playlist can be re-added to queue playlist using this menu item). However, this menu item seems to be available only for files that recoginzed by TC4A as media (for example the *.oga files which TCMP plays on my device doesn't have such menu item).

Why "Add to queue" doesn't have that "avoid to add the last added file again" restriction which exist for "Open with"->"TotalCmd (queue)"?

If it won't be possible to remove the re-adding restriction for "Open with"->"TotalCmd (queue)" way (using for example the method I suggested in previous post), maybe you can add an option to set a user-defined list of extensions with enabled "Add to queue" context menu item?
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

"Add to queue" passes the files internally from TC to the player, so there is no problem with itents.
Author of Total Commander
https://www.ghisler.com
Post Reply