This forum uses cookies. Click X button to hide this message. What is stored? 
Total Commander Forum Index Total Commander
Forum - Public Discussion and Support
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

Two similar bugs with locked tabs

 
Post new topic   Reply to topic    Total Commander Forum Index -> TC Behaviour which will not be changed Printable version
View previous topic :: View next topic  
Author Message
Vochomurka
Power Member
Power Member


Joined: 14 Sep 2005
Posts: 748
Location: Russia

PostPosted: Fri Oct 13, 2017 6:25 am    Post subject: Two similar bugs with locked tabs Reply with quote

Bug #1. One non-closable and many non-activating tabs
How to reproduce:
1) Lock all tabs (only "Locked", but not "Locked, but directory change allowed");
2) Save tabs to tab-file;
2) Open this tab-file in a text editor, and change paths to non-existent ones, provided that the drive is valid.
It is most easy to choose the C:\ drive, and then type some random characters like "kjet83hjew" as a directory name.
For example, here is a sample tab-file:
Code:
[activetabs]
0_path=c:\9f8j4fmqp35tieiu\
0_options=1|0|0|0|0|1|0|
1_path=c:\d8oi04hgop25\
1_options=1|0|0|0|0|1|0|
2_path=c:\msp7oe95kd\
2_options=1|0|0|0|0|1|0|
activetab=0
3) Left-click any tab header and choose "Load tabs from file, replace tabs", then pick created tab-file;
4) One additional tab with C:\ root is created as a last tab;
5) Now the last (rightmost) tab cannot be closed and is always active, and all other tabs cannot be activated but can be closed.

Bug #2. Non-activating tab
How to reproduce:
1) Create a directory (or use an existing one with waste files);
2) Enter it and lock its tab (only "Locked", but not "Locked, but directory change allowed");
3) Drag this tab so that it is not the last (or just open some tabs after it);
4) In another tab delete the directory created in step 1;
5) As before, the tab pointing to the just deleted directory cannot be activated, but can be closed.
Video

Both these situation were caused by usual events: changing of drive names while reinstalling the Windows, or deleting the directory whose tab was locked before.
In fact, in both cases there is an attempt to activate the tab pointing to non-existent directory.
I treat these as bugs because the tab that cannot be activated is not a normal behavior and can confuse the user.
I suppose that the best solution is to display a standard message box like "Path ... is invalid" or, at worst, just to produce the system "Error" sound
_________________
PowerPro scripts for Total Commander
Back to top
View user's profile Send private message Send e-mail
siealex
Senior Member
Senior Member


Joined: 22 Mar 2009
Posts: 210

PostPosted: Sat Oct 14, 2017 9:05 am    Post subject: Reply with quote

Confirmed.
Quote:
I suppose that the best solution is to display a standard message box like "Path ... is invalid" or, at worst, just to produce the system "Error" sound

And/or to go straight to the root of that drive.
Quote:
Drag this tab so that it is not the last (or just open some tabs after it)

This is not necessary. If this tab is the last one (and active), it is immediately deactivated.
PS, it may be a very old bug, I confirmed it also on 8.50b15 on my Win98 virtual machine.
_________________
We are not so S.M.A.R.T. as we imagine...
Back to top
View user's profile Send private message Send e-mail
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 34364
Location: Switzerland

PostPosted: Sun Oct 15, 2017 1:20 am    Post subject: Reply with quote

This cannot be avoided: When you try to switch to a tab which is locked, and the directory doesn't exist, TC will go to the parent of that directory. Since the tab explicitly forbids to go to a different location, TC is forced to open a new tab for that parent directory.

When you try to remove the last, not locked tab, TC would have to switch to the previous tab. But since it contains an invalid directory AND is locked, TC is forced to open a new unlocked tab.

So to get rid of these tabs, unlock and close them.
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
Vochomurka
Power Member
Power Member


Joined: 14 Sep 2005
Posts: 748
Location: Russia

PostPosted: Sun Oct 15, 2017 1:25 am    Post subject: Reply with quote

2ghisler(Author)
Of course, it is evident.
What about some visual and/or acoustic warning to the user to let him know that his action (attempt to go to the absent path) is invalid?
Thank you
_________________
PowerPro scripts for Total Commander
Back to top
View user's profile Send private message Send e-mail
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 34364
Location: Switzerland

PostPosted: Sun Oct 15, 2017 1:29 am    Post subject: Reply with quote

Hmm, what do you have in mind?
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
Vochomurka
Power Member
Power Member


Joined: 14 Sep 2005
Posts: 748
Location: Russia

PostPosted: Sun Oct 15, 2017 1:30 am    Post subject: Reply with quote

Vochomurka wrote:
I suppose that the best solution is to display a standard message box like "Path ... is invalid" or, at worst, just to produce the system "Error" sound

_________________
PowerPro scripts for Total Commander
Back to top
View user's profile Send private message Send e-mail
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 34364
Location: Switzerland

PostPosted: Mon Oct 16, 2017 3:38 am    Post subject: Reply with quote

I will consider it for a later version. Currently it's not so easy, you would get this error message or beep on every failed directory change, which would be quite annoying.
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
siealex
Senior Member
Senior Member


Joined: 22 Mar 2009
Posts: 210

PostPosted: Mon Oct 16, 2017 12:24 pm    Post subject: Reply with quote

Quote:
Since the tab explicitly forbids to go to a different location, TC is forced to open a new tab for that parent directory.

And if I have a LOCKED tab for this PARENT directory, TC goes to that tab. Is it intended?
Image: https://s1.postimg.org/6tfa0qm9an/592.jpg
_________________
We are not so S.M.A.R.T. as we imagine...
Back to top
View user's profile Send private message Send e-mail
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 34364
Location: Switzerland

PostPosted: Tue Oct 17, 2017 3:01 am    Post subject: Reply with quote

It depends on the LockedTabChange option in wincmd.ini. The default is 1, which means re-use existing tab with that directory.
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
Vochomurka
Power Member
Power Member


Joined: 14 Sep 2005
Posts: 748
Location: Russia

PostPosted: Wed Oct 18, 2017 12:25 am    Post subject: Reply with quote

ghisler(Author) wrote:
I will consider it for a later version. Currently it's not so easy, you would get this error message or beep on every failed directory change, which would be quite annoying.
Perfect! This annoyance will force the user to study out what's happening that he can't activate some specific tab.
The situation when some tab is inaccessible is not normal and must be avoided. On the other hand, it is rather seldom. So, the user must be informed explicitly that something is wrong in his tabs. I prefer to get the message box with incorrect (in my case - absent) path, and the description of error (not TC's, but user's one)
_________________
PowerPro scripts for Total Commander
Back to top
View user's profile Send private message Send e-mail
Display posts from previous:   
Post new topic   Reply to topic    Total Commander Forum Index -> TC Behaviour which will not be changed All times are GMT - 6 Hours
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Impressum: This site is maintained by Ghisler Software GmbH

Using phpBB © 2001-2005 phpBB Group