[TC 11.02RC3] cm_SyncChangeDir — synchronous exit from directories with different names

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Fla$her
Power Member
Power Member
Posts: 2318
Joined: 2020-01-18, 04:03 UTC

Re: [TC 11.02RC3] cm_SyncChangeDir — synchronous exit from directories with different names

Post by *Fla$her »

ghisler(Author) wrote: 2023-10-25, 13:40 UTCI have now implemented this, please let me know what you think:
✖️ Something's not right. With ChangeDirMode=1/3, the function shouldn't be automatically disabled, but it's disabled with different folder names by pressing Backspace (with Enter on [..] there is no such problem). It's also disabled by BS if there is an FTP root or drive list on any one panel, even if there is an FTP root on both sides.

✔️ With ChangeDirMode=1/3, synchronous change by Enter on [..] doesn't suspend or disable the mode if the folder of the same name in one of the panels has opened twice (C:\test \ > C:\test\test) and more. ✖ Unfortunately, this doesn't apply to Backspace yet.
✔️ Exiting a folder with a different name on another panel is no longer performed.
Overquoting is evil! 👎
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.02RC3] cm_SyncChangeDir — synchronous exit from directories with different names

Post by *ghisler(Author) »

I can confirm that backspace behaves incorrectly with ChangeDirMode=1 or 3.
It does seem to work fine with ChangeDirMode=5 or 7, though. Can you confirm that?
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2318
Joined: 2020-01-18, 04:03 UTC

Re: [TC 11.02RC3] cm_SyncChangeDir — synchronous exit from directories with different names

Post by *Fla$her »

ghisler(Author) wrote: 2023-10-26, 08:52 UTC It does seem to work find with ChangeDirMode=5 or 7, though. Can you confirm that?
Please clarify. Does it work correctly or incorrectly (as I described)?
Overquoting is evil! 👎
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.02RC3] cm_SyncChangeDir — synchronous exit from directories with different names

Post by *ghisler(Author) »

Going up with backspace should work correctly with ChangeDirMode=5 or 7, suspending the function until you return to the last directory pair where it was enabled.
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2318
Joined: 2020-01-18, 04:03 UTC

Re: [TC 11.02RC3] cm_SyncChangeDir — synchronous exit from directories with different names

Post by *Fla$her »

Yes, it is. I checked it right away.
Overquoting is evil! 👎
Fla$her
Power Member
Power Member
Posts: 2318
Joined: 2020-01-18, 04:03 UTC

Re: [TC 11.02RC3] cm_SyncChangeDir — synchronous exit from directories with different names

Post by *Fla$her »

11.02RC5. To change the directory now, for some reason, after switching on the mode, you often have to press Enter or Backspace twice, as if TC doesn't have time to perform some operation.
Overquoting is evil! 👎
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.02RC3] cm_SyncChangeDir — synchronous exit from directories with different names

Post by *ghisler(Author) »

To change the directory now, for some reason, after switching on the mode, you often have to press Enter or Backspace twice
This is caused by SyncChangeDirMode=2 or any other mode in combination with 2. Here the first try to access a directory which doesn't exist on the other side will result in a beep, only the second try will succeed.
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2318
Joined: 2020-01-18, 04:03 UTC

Re: [TC 11.02RC3] cm_SyncChangeDir — synchronous exit from directories with different names

Post by *Fla$her »

But why a double attempt? Without sound, it is incomprehensible, but with sound, you will already understand that you entered the catalog with a warning, and if you are not satisfied with it, you can go back out. And constantly pressing twice is annoying, because it has to be done much more often than potentially making mistakes.
Last edited by Fla$her on 2023-10-30, 14:30 UTC, edited 1 time in total.
Overquoting is evil! 👎
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.02RC3] cm_SyncChangeDir — synchronous exit from directories with different names

Post by *ghisler(Author) »

But why a double attempt?
What do you mean? The first attempt causes the beep, the second changes the directory. If you don't want that, then don't add 2.
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2318
Joined: 2020-01-18, 04:03 UTC

Re: [TC 11.02RC3] cm_SyncChangeDir — synchronous exit from directories with different names

Post by *Fla$her »

I want there to be a beep at the same time as the directory change.
Overquoting is evil! 👎
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.02RC3] cm_SyncChangeDir — synchronous exit from directories with different names

Post by *ghisler(Author) »

I see - that would have to be a separate option. The main reason why there is a beep on a first attempt is that with SyncChangeDirMode=0/2, the function gets disabled. Then it would be annoying that the user gets notified but can't prevent that the function gets disabled.

Anyway, could you check whether the following bug you reported has been fixed?
Something's not right. With ChangeDirMode=1/3, the function shouldn't be automatically disabled, but it's disabled with different folder names by pressing Backspace (with Enter on [..] there is no such problem). It's also disabled by BS if there is an FTP root or drive list on any one panel, even if there is an FTP root on both sides.
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2318
Joined: 2020-01-18, 04:03 UTC

Re: [TC 11.02RC3] cm_SyncChangeDir — synchronous exit from directories with different names

Post by *Fla$her »

Then it would be annoying that the user gets notified but can't prevent that the function gets disabled.
I agree. Please add another flag to the option.
Anyway, could you check whether the following bug you reported has been fixed?
Yes. Fixed.
Overquoting is evil! 👎
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.02RC3] cm_SyncChangeDir — synchronous exit from directories with different names

Post by *ghisler(Author) »

Great! Are there still any open bugs in this function which I missed?
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.02RC3] cm_SyncChangeDir — synchronous exit from directories with different names

Post by *white »

Moderator message from: white » 2023-11-02, 13:29 UTC

ghisler(Author) wrote: 2023-10-31, 07:40 UTC Great! Are there still any open bugs in this function which I missed?
Discussion after this has been split to new thread: viewtopic.php?t=80427
Post Reply