TC7.5b4 deleting DIR

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
User avatar
cdi1965
Junior Member
Junior Member
Posts: 10
Joined: 2004-02-16, 14:19 UTC

TC7.5b4 deleting DIR

Post by *cdi1965 »

Hi,
when I'm deleting a directory (e.g 5mb size) the CPU goes up to 70% and more and the RAM goes up till there is no more RAM available.

After deleting the DIRECTORY ist complete the resources (RAM/CPU) are still growing.

OS: Windows 7 RC german 64bit


CDI1965
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50383
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

This is unfortunately a known Vista/Windows bug, and there is no workaround. It happens because Total Commander is deleting each file individually (via SHFileOperation) to recycle bin. This is the ONLY way to find out whether a file really was deleted or not. Deleting all together to recycle bin doesn't return any information of which was deleted and which not, but this information is absolutely needed to delete comments or thumbnails belonging to the deleted file(s).
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8711
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

ghisler(Author) wrote:Deleting all together to recycle bin doesn't return any information of which was deleted and which not, but this information is absolutely needed to delete comments or thumbnails belonging to the deleted file(s).
What if just check existing files (non-deleted) after deleting "all together"? Or this even more slower?
Johan6665
Junior Member
Junior Member
Posts: 2
Joined: 2009-09-26, 14:17 UTC

Post by *Johan6665 »

Hi

I have seen the same problem on my system(Win7 64bit).
This makes Total Commander more or less unusable in windows 7. Total Commander consumes all memory until system falls over.

Are you working on a solution? Your software is allot better than what windows offers!

Keep up the good work! And please fix this soon:-)


/Johan
User avatar
HolgerK
Power Member
Power Member
Posts: 5408
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Post by *HolgerK »

TC7.5 Help 4.b wincmd.ini wrote:VistaDelete=0
;If =1, use new delete method of Windows Vista or later to delete files to recycle bin. Moves entire directories instead of individual files to recycle bin. Warning: This method doesn't warn about read only, hidden or system files, or non-empty directories, just like the Explorer! Do not use if you have manually disabled the recycle bin on certain drives!
Just add VistaDelete=1 to the [Configuration] section of your wincmd.ini file, restart and enjoy!

Regards
Holger
User avatar
Balderstrom
Power Member
Power Member
Posts: 2148
Joined: 2005-10-11, 10:10 UTC

Post by *Balderstrom »

Wouldn't it be better if there was at least one additional delete command? so that we could use TC Delete for most intents and purposes but choose the alternate behaviour in some cases?
cm_ExplorerDelete, if running vista equivalent to "VistaDelete=1" otherwise equivalent to checkboxing use Explorer Delete method in Config.
in addition to the already existing cm_Delete.
User avatar
MVV
Power Member
Power Member
Posts: 8711
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Balderstrom wrote:Wouldn't it be better if there was at least one additional delete command? so that we could use TC Delete for most intents and purposes but choose the alternate behaviour in some cases?
cm_ExplorerDelete, if running vista equivalent to "VistaDelete=1" otherwise equivalent to checkboxing use Explorer Delete method in Config.
in addition to the already existing cm_Delete.
You already have cm_ExplorerDelete, just open context menu and choose Delete. :D
User avatar
Balderstrom
Power Member
Power Member
Posts: 2148
Joined: 2005-10-11, 10:10 UTC

Post by *Balderstrom »

Context Menu is not something you can assign to a button or an internal HotKey.

And contextMenu availability of something is hardly a good response. TC has pack/unpack copy/paste and numerous other functions that are available via a context menu.
*BLINK* TC9 Added WM_COPYDATA and WM_USER queries for scripting.
Johan6665
Junior Member
Junior Member
Posts: 2
Joined: 2009-09-26, 14:17 UTC

Post by *Johan6665 »

Thanks for the help. You saved me! I really don't like windows explorer.

Keep up the good work. Thanks again!

/Johan
raytc
Senior Member
Senior Member
Posts: 274
Joined: 2004-06-28, 11:03 UTC

Post by *raytc »

When I delete directories with a lot of files my cpu goes over 90%. Mostly 98%.

I've never noted this before.

My tc = 8.01 64 bits
win 8 pro 64 bits
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50383
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Please right click on the F8 delete button and choose "Properties", then enable delete confirmation in the recycle bin. Why? TC disables the new faster delete method when delete confirmations are off. Unfortunately this is the default on Windows 8, so TC uses the old slow delete method on these systems.
Author of Total Commander
https://www.ghisler.com
raytc
Senior Member
Senior Member
Posts: 274
Joined: 2004-06-28, 11:03 UTC

Post by *raytc »

Haven't understand very well the reason but it seems to work. Thank you :)
TC 9.51 (x64) - win10
User avatar
MVV
Power Member
Power Member
Posts: 8711
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

raytc, as ghisler said, TC uses slower (but safer) delete method if delete confirmations in Windows are disabled (to prevent unexpected deletion). When you've enabled them, TC switched to faster delete method.
raytc
Senior Member
Senior Member
Posts: 274
Joined: 2004-06-28, 11:03 UTC

Post by *raytc »

The strange thing is, that it is with confirmation faster than without confirmation. (ok ... 2 different methods). :)

The ideal situation (for me) would be: the faster delete method without delete confirmation :)
TC 9.51 (x64) - win10
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50383
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

In TC 8.5, I will show my own delete confirmation dialog in this situation.
Author of Total Commander
https://www.ghisler.com
Post Reply