Copy, file and dir with same name

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

User avatar
Alextp
Power Member
Power Member
Posts: 2321
Joined: 2004-08-16, 22:35 UTC
Location: Russian Federation
Contact:

Copy, file and dir with same name

Post by *Alextp »

Russian forum:

Copy file F to folder C:\A where folder C:\A\F already exists.

TC copies F to C:\A\F\F.
Expected: TC doesn't copy F and show error (since the folder C:\A\F already exists).

TC 7.02
User avatar
Sir_SiLvA
Power Member
Power Member
Posts: 3291
Joined: 2003-05-06, 11:46 UTC

Post by *Sir_SiLvA »

have you seen what explorer does ?
Hoecker sie sind raus!
User avatar
Alextp
Power Member
Power Member
Posts: 2321
Joined: 2004-08-16, 22:35 UTC
Location: Russian Federation
Contact:

Post by *Alextp »

No access to file:
---------------------------
Ошибка при копировании файла или папки
---------------------------
Не удается скопировать xxxxxxx. Нет доступа.
...
---------------------------
ОК
---------------------------
User avatar
petermad
Power Member
Power Member
Posts: 14793
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

TC copies F to C:\A\F\F.
Confirmed.
Expected: TC doesn't copy F and show error
Agree.
have you seen what explorer does
A little more correct error message could be needed.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Sombra
Power Member
Power Member
Posts: 811
Joined: 2005-12-27, 22:23 UTC
Location: Zaragoza, Spain

Post by *Sombra »

Perhaps this is similar to the case 1 of this topic: http://ghisler.ch/board/viewtopic.php?p=109867

:?: :?:
I can read English, but... I write like Tarzan. (sorry)
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48077
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

This is intentional. I added a warning when you rename a file, maybe i should add one too when copying?
Author of Total Commander
https://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Post by *DrShark »

ghisler(Author) wrote:maybe i should add one too when copying?
Yes.
User avatar
petermad
Power Member
Power Member
Posts: 14793
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

maybe i should add one too when copying
Good idea - and also one when moving files!

A message box saying something like:

"A directory with the same name as the file: xxx already exists - do yo want to copy (move) the file to that directory ?"
[Yes] [No] [Always] [Cancel]

would be a good idea IMHO.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Sombra
Power Member
Power Member
Posts: 811
Joined: 2005-12-27, 22:23 UTC
Location: Zaragoza, Spain

Post by *Sombra »

maybe i should add one too when copying?
Good point. That could prevent confusion to users.
I can read English, but... I write like Tarzan. (sorry)
StatusQuo
Power Member
Power Member
Posts: 1524
Joined: 2007-01-17, 21:36 UTC
Location: Germany

Post by *StatusQuo »

petermad wrote:Expected: TC doesn't copy F and show error

Agree.
Sorry, I disagree here.
If I enter "copy/move G C:\A\F" (or use F5/F6 for this) I expect that the file gets copied into that folder.
The same should IMO apply to "copy/move F C:\A\F" (F5/F6).
ghisler(Author) wrote:I added a warning when you rename a file, maybe i should add one too when copying?
petermad wrote:and also one when moving files!
Yes, that would be a nice (and consistent) solution to satisfy all, IMO.
Who the hell is General Failure, and why is he reading my disk?
-- TC starter menu: Fast yet descriptive command access!
User avatar
petermad
Power Member
Power Member
Posts: 14793
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

The same should IMO apply to "copy/move F C:\A\F"
But that's not the issue - the issue is that when you copy/move F to C:\A it gets copied to C:\A\F - in that way it gets copied but it is out of your sight, because it is one directory below the current in the target panel.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
StatusQuo
Power Member
Power Member
Posts: 1524
Joined: 2007-01-17, 21:36 UTC
Location: Germany

Post by *StatusQuo »

2petermad
StatusQuo wrote:The same should IMO apply to "copy/move F C:\A\F"
But that's not the issue
Well, indirectly it is (I admit, I didn't explain this clearly enough):

If you copy/move only 1 file (file "F" from the source panel) and C:\A is the active path on the target panel,
then the suggested target name is "C:\A\F" -
an existing folder name, so the file gets in there ("copy/move F C:\A\F").

If you copy/move multiple files, the effect does not occur,
because the target name is suggested as "C:\A" -
an error message is displayed (as expected) in this case, the file "F" is not copied.
Who the hell is General Failure, and why is he reading my disk?
-- TC starter menu: Fast yet descriptive command access!
User avatar
Alextp
Power Member
Power Member
Posts: 2321
Joined: 2004-08-16, 22:35 UTC
Location: Russian Federation
Contact:

Post by *Alextp »

StatusQuo wrote:If you copy/move only 1 file (file "F" from the source panel) ... then the suggested target name is "C:\A\F" - an existing folder name, so the file gets in there..
It is, and it is the "bug".
Better if TC will show message, as Ghisler suggested.
User avatar
petermad
Power Member
Power Member
Posts: 14793
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

2StatusQuo
If you copy/move multiple files, the effect does not occur,
Aha, I see the difference now.

I still think that the behaviour when copying 1 file is inexpedient, because I must admit that I most often don't look at the suggested name when copying/moving files, because I already know the location of the target panel (the beauty of a two-panel file manager).
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
StatusQuo
Power Member
Power Member
Posts: 1524
Joined: 2007-01-17, 21:36 UTC
Location: Germany

Post by *StatusQuo »

2petermad
I most often don't look at the suggested name
I still think that the behaviour when copying 1 file is inexpedient
Yes, I agree to both.
To not make it impossible to copy the file into C:\A\F on purpose,
the warning message should solve the problem (better than refusing the action).
Who the hell is General Failure, and why is he reading my disk?
-- TC starter menu: Fast yet descriptive command access!
Post Reply