7.5PB4: When typing fast, quick filter can loose characters

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
m^2
Power Member
Power Member
Posts: 1413
Joined: 2006-07-12, 10:02 UTC
Location: Poland
Contact:

7.5PB4: When typing fast, quick filter can loose characters

Post by *m^2 »

I have a directory with 7741 files in subfolders. I just wanted to search for some files with quick filter in broad view and noticed a problem:
With such number of files, filtering takes much longer than typing. I can type 10 characters, wait, wait, wait...after a few seconds TC shows some 3 (it can be another number too) of them, the first is correct, but then TC skips a few, takes another ones, skips something again, takes another...

Also, I have a proposal: If I press backspace a few times, TC calls the filter for each button press for each file. If I press another backspace before TC finished processing the previous one, it could skip it and start processing another.
Caching results would be helpful too.
User avatar
fenix_productions
Power Member
Power Member
Posts: 1979
Joined: 2005-08-07, 13:23 UTC
Location: Poland
Contact:

Post by *fenix_productions »

2m^2
Completely agree.

I think some advices could be taken from here:
http://www.codeproject.com/KB/WPF/SnappyFiltering.aspx
"When we created the poke, we thought it would be cool to have a feature without any specific purpose." Facebook...

#128099
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Sorry, Quick Filter has to work like this because it stops accepting characters if there would be no match.
Author of Total Commander
https://www.ghisler.com
User avatar
m^2
Power Member
Power Member
Posts: 1413
Joined: 2006-07-12, 10:02 UTC
Location: Poland
Contact:

Post by *m^2 »

No, it's another issue. It skips some characters. I type "celina" and TC displays "cin", although there is a file with "celina" in name.
User avatar
za222
Member
Member
Posts: 146
Joined: 2003-03-11, 17:19 UTC
Location: Germany

Post by *za222 »

I must agree with the bug report.

Quick filter has become very laggy and slow with beta4!

i got a folder with over 9000 files and beta3 worked really fast and i didint even notice any CPU load.

But with beta4 it has become really slow, sometimes misses keys if you are too fast and CPU hits 100% (50% on dual core).
Especially if you have typed something like

*test*2009*dat

in the quickfilter
and then press and HOLD backspace it takes ages to delete all the characters in the quickfilter (100% cpu again).
No problem here in beta3 either.
User avatar
m^2
Power Member
Power Member
Posts: 1413
Joined: 2006-07-12, 10:02 UTC
Location: Poland
Contact:

Post by *m^2 »

za222 wrote:I must agree with the bug report.

Quick filter has become very laggy and slow with beta4!

i got a folder with over 9000 files and beta3 worked really fast and i didint even notice any CPU load.

But with beta4 it has become really slow, sometimes misses keys if you are too fast and CPU hits 100% (50% on dual core).
Especially if you have typed something like

*test*2009*dat

in the quickfilter
and then press and HOLD backspace it takes ages to delete all the characters in the quickfilter (100% cpu again).
No problem here in beta3 either.
Confirmed!
Actually I didn't use the previous betas with many files, but now I tried and they not only seem to work correctly, but are way faster too.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I have checked now why it has become so slow: It's an error in the loading of the external search dll! I will fix that in the next beta. TC tries to load the dll again and again on each keypress...
Author of Total Commander
https://www.ghisler.com
User avatar
Samuel
Power Member
Power Member
Posts: 1930
Joined: 2003-08-29, 15:44 UTC
Location: Germany, Brandenburg an der Havel
Contact:

Post by *Samuel »

Fixed long ago. Can confirm problem in the beta and that its fixed.
User avatar
StickyNomad
Power Member
Power Member
Posts: 1933
Joined: 2004-01-10, 00:15 UTC
Location: Germany

Post by *StickyNomad »

I couldn't reproduce this too, so it seems to be fixed here.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Great, thanks very much!
Author of Total Commander
https://www.ghisler.com
Post Reply