Compare & Edit large files bug

[MVV]

I found a bug, then I tried to repeat it with other file.

I've created a file with following content copypasted some times:

Code: Select all

1	1	1	1	1	1679		1	1	1	1	1	67214
1	1	1	1	1	1680		1	1	1	1	1	67215
1	1	1	1	1	1681		1	1	1	1	1	67216
...
1	1	1	1	1	13844		1	1	1	1	1	79379
1	1	1	1	1	13845		1	1	1	1	1	79380

File size is about 4 MB. I made a copy of a file and removed 39 lines from it. I wanted to compare two large different files.

Then I tried to compare files and to make some changes in one file, save it (by pressing Compare button), again make some changes, again save... but TC said "Unable to create output file!"

I had repeated situation many times, second save fails always (restart compare, repeat making changes - second save fails again).

Tested with 7.50PB6, 7.04a.

[ghisler(Author)]

Saving via the Compare button is the wrong method, please use the save button (the one with the disk icon) instead. Using the compare button disturbs the .bak file management because the file is re-loaded. It also kills the UNDO history.

I will still try to find a solution which works with .bak file management...

[MVV]

Sometimes when Comparer incorrectly matches "equal" lines I press Compare for fixing that by rematching lines (for example, after adding some null lines to one file). And Compare button allows for me to see how files will be compared next time I run Comparer. So, I make changes and see results immediately.

I tried to use Save button directly, there is no bug, Save works. But when I use Compare button once for saving, next time when I want to save file neither Compare nor Save button don't works until I close Comparer and open it again.

Is there a way to keep undo history between Compare button presses?

Why Compare button causes troubles with .bak management? When I press Compare button, TC should Save file(s) and Reload them, I don't see any conflicts here.

[ghisler(Author)]

I think that I found a solution now. However, you will get two backup files then, .bak and .bk2. The first will be the state of the file before editing started, and the second the state before the last editing step. This is necessary because large files are mapped into memory, which has to be the .bak file for several reasons.

[MVV]

That's good. But if we'll have two temp files, we have even more need to keep them in temp folder as people suggested (me too).

[ghisler(Author)]

Unfortunately the temp folder isn't necessarily on the same harddisk, so this wouldn't work.

[MVV]

Unfortunately the temp folder isn't necessarily on the same harddisk, so this wouldn't work.

Why? We should just make a backup copy in temp folder and map original file. I don't see here any troubles.

BTW, backup creating between different logical drives not slower than in the same folder.

I'd always hated thumbs.dat files that litter folders. What about you?

[StatusQuo]

2MVV
I just updated this script to work with the current beta:
AutoHotkey: Auto-Delete BAK-files created by TC's File-Compare-Editor

[MVV]

I just updated this script to work with the current beta:
AutoHotkey: Auto-Delete BAK-files created by TC's File-Compare-Editor

Maybe it's good but I think TC should support .bak creating disabling itself. It is more surely.
If I need a tool for removing backups, I'd write such tool in C/C++ (with multiple windows support, changing compared files w/o closing compare dialog etc.).

[Boofo]

If I need a tool for removing backups, I'd write such tool in C/C++ (with multiple windows support, changing compared files w/o closing compare dialog etc.).

Go for it!

[ghisler(Author)]

OK, the original error of this bug report should be fixed now...

[MVV]

Original problem fixed, checked in b8. But now after compare-and-edit TC leaves up to FOUR backup files... Needs to hold them in special folder even more:)

[ghisler(Author)]

Great, thanks for confirming the fix! Sorry, the 4 backup files cannot be avoided.

[MVV]

I do not suggest to avoid them, I (and nort only) suggest to keep them in user-specified garbage folder.

[Balderstrom]

The only issue with the Compare tool that I've run into on more than one occasion is I use .bak frequently to make backups of source code within the same file's directory. When running CompareFile tool against 2 files, and making any changes + save. TC will happily overwrite the existing .bak that it didn't create and with no confirmation warning that it is going to do so.

This wouldn't occur if TC's "temp" backups were named along the lines of FileName.ext.tc.bak or FileName.ext.tc.bk1, etc.

Or if it made a .bk1 for its initial save if an there was a pre-existing .bak