Search not work while file list show previous search result

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
ts4242
Power Member
Power Member
Posts: 2081
Joined: 2004-02-02, 20:08 UTC
Contact:

Search not work while file list show previous search result

Post by *ts4242 »

1- In the left panel open any folder
2- Do search for *.* and feed the result to the listbox
3- While the listbox show previous search result, do search again for *.* but this time select another folder from the find dialog
4- Press Start
5- Only top level folders in the searched folder are founded
User avatar
HolgerK
Power Member
Power Member
Posts: 5406
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Post by *HolgerK »

Confirmed!
Only top level folders and files in the searched folder are founded
No file in sub folders of the second path is found.

Regards
Holger
User avatar
ts4242
Power Member
Power Member
Posts: 2081
Joined: 2004-02-02, 20:08 UTC
Contact:

Post by *ts4242 »

HolgerK wrote:Confirmed!
Only top level folders and files in the searched folder are founded
No file in sub folders of the second path is found.

Regards
Holger
Your addition is correct, I missed files because my folder top level was not contains files but only sub-folders
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

This isn't a bug, the option "Search subdirs" - "Only current directory" is still active.
Author of Total Commander
https://www.ghisler.com
User avatar
ts4242
Power Member
Power Member
Posts: 2081
Joined: 2004-02-02, 20:08 UTC
Contact:

Post by *ts4242 »

2ghisler(Author)

I didn't notice that the option "current dir only" is pre-selected

I think if the user change the search in dir, the option "all (unlimited depth)" auto selected again.
User avatar
HolgerK
Power Member
Power Member
Posts: 5406
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Post by *HolgerK »

ghisler(Author) wrote:This isn't a bug, the option "Search subdirs" - "Only current directory" is still active.
I see.

But the question remains why is it set after a feed to list box?
Is it because otherwise some folder, sub folder would be searched multiple times?

Even if I do a second search from "feed to list box"(with all files and folder selected) and change the option to "all (unlimited depth)" the same number of files and folders will be found.

Regards
Holger
User avatar
ts4242
Power Member
Power Member
Posts: 2081
Joined: 2004-02-02, 20:08 UTC
Contact:

Post by *ts4242 »

2HolgerK

I found this entry in History.txt
03.03.10 Fixed: Search function, in results from "Feed to Listbox", only selected: create list of already searched directories, to avoid that the same dir searched twice (listing its files also twice)

2ghisler(Author)
17.03.10 Added: Search function: When started from "Feed to listbox" panel, handle as if all files would be selected
In this case you should disable search in field too as you do if there is actually selected files/folders
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Well, there are two possible solutions here:
1. Since duplicate results are avoided now, I could leave the "search subdirs" option always at "unlimited depth"

2. I could change it to "unlimited depth" as soon as the user puts something in the "start in" field. This would be more like TC 7.5 behaviour.

What do you think?
Author of Total Commander
https://www.ghisler.com
User avatar
ts4242
Power Member
Power Member
Posts: 2081
Joined: 2004-02-02, 20:08 UTC
Contact:

Post by *ts4242 »

ghisler(Author) wrote:1. Since duplicate results are avoided now, I could leave the "search subdirs" option always at "unlimited depth"
This one is OK for me.
User avatar
HolgerK
Power Member
Power Member
Posts: 5406
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Post by *HolgerK »

1. Since duplicate results are avoided now, I could leave the "search subdirs" option always at "unlimited depth"
a) it is exact the behavior as in 7.50(a)
b) it can be useful if you mark some folder(s) from a "Feed to list box" search result and repeat the search to refine the result. In this case "Search in" is grayed because of "[x] Only search in selected".

Regards
Holger
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

1. Since duplicate results are avoided now, I could leave the "search subdirs" option always at "unlimited depth"
Support for this solution++

Because of:
b) it can be useful if you mark some folder(s) from a "Feed to list box" search result and repeat the search to refine the result. In this case "Search in" is grayed because of "[x] Only search in selected".
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

OK, I will do it as suggested in "1".
Author of Total Commander
https://www.ghisler.com
User avatar
ts4242
Power Member
Power Member
Posts: 2081
Joined: 2004-02-02, 20:08 UTC
Contact:

Post by *ts4242 »

Fixed in 7.55 beta 2.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Great, thanks!
Author of Total Commander
https://www.ghisler.com
Post Reply