Packer plugins: incorrect return code handling.

[Eugene]

If DeleteFiles() returns E_BAD_DATA, TC prints "CRC error".
If DeleteFiles() returns E_BAD_ARCHIVE, TC prints "Error in archive file".
I suppose it must be vice versa.

Same is for PackFiles(). But I didn't test all the functions. Dear TC author, could you please review return code handling routines for every function?

[fenix_productions]

2Eugene
According to wcxhead.h file from SDK, you seem to be right:

Code: Select all

#define E_BAD_DATA        12            /* Data is bad */
#define E_BAD_ARCHIVE     13            /* CRC error in archive data */

[ghisler(Author)]

Seems that the documentation isn't very clear here. The documentation is mainly meant for the pack process, not the delete process.

For deleting, the meaning is:
E_BAD_DATA: The archive could be opened OK, but some bad data was encountered during the delete process.
E_BAD_ARCHIVE: The archive as a whole is bad, and cannot be modified.

[Eugene]

If PackFiles() returns E_BAD_DATA, TC prints "CRC error".
If PackFiles() returns E_BAD_ARCHIVE, TC prints "Error in archive file".

Code: Select all

#define E_BAD_DATA        12            /* Data is bad */
#define E_BAD_ARCHIVE     13            /* CRC error in archive data */

So this documentation is not for packing purposes too.

[ghisler(Author)]

Strange, I will check that and update the docs if necessary.