[8.0ß1-x64] Nag screen creates a button in Taskbar

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

[8.0ß1-x64] Nag screen creates a button in Taskbar

Post by *Flint »

When 64-bit TC is started without registration key file, a nag dialog is shown, and in Windows taskbar there is additional window present with title "Total Commander". After clicking the 1-2-3 button, this additional taskbar button disappears.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
karlchen
Power Member
Power Member
Posts: 4603
Joined: 2003-02-06, 22:23 UTC
Location: Germany

Post by *karlchen »

Hello, Flint.

Your report is confirmed using

Windows Server 2008 R2 (64-bit)
Total Commander 8.0 beta1 64-bit

The additional taskbar icon is not visible when using e.g.

Windows Server 2008 R2 (64-bit)
Total Commander 8.0 beta1 32-bit

I am not sure, however, why this additional taskbar icon should constitute a bug. Anyway, the reported behaviour can be reproduced.

Cheers,
Karl
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

Post by *Flint »

karlchen wrote:The additional taskbar icon is not visible when using e.g.

Windows Server 2008 R2 (64-bit)
Total Commander 8.0 beta1 32-bit
It's obviously a Lazarus-related problem, so it is present in 64-bit version only.
karlchen wrote:I am not sure, however, why this additional taskbar icon should constitute a bug.
Because this dialog is modal and blocks the main TC window. Additional taskbar button should only be present when it is a normal usecase to switch between two windows. But we cannot switch between the nag screen and main TC window, so additional button is a waste of space and violation of usability conventions (users see the button and think that it is possible to activate the TC window).
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Confirmed - unfortunately I have no idea how to prevent that from happening. :(
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Christian, you should specify TC main window handle as parent window of nag window. Windows doesn't show taskbar buttons for windows that have parents, currently nag window has no parent.

Don't know exactly how to do it in Lazarus but sure you'll find it. :)
Maybe Parent property of window will help you. Also you should try ShowModal if you use Show.
Or at least API function or method SetParent.

Also there is a property ShowInTaskBar - try to change it.
Last edited by MVV on 2011-09-19, 13:07 UTC, edited 1 time in total.
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

Post by *Flint »

ghisler(Author) wrote:unfortunately I have no idea how to prevent that from happening.
Maybe it will help to try to find differences between the nag screen and other dialogs (like Settings or Change buttonbar) which don't create a new window button.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

you should specify TC main window handle as parent window of nag window
Unfortunately that's not possible because it's loaded before the main window. I tried the Lazarus option ShowInTaskBar-stNever, but this doesn't work.
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Fixed in beta2.

You may change parent just before displaying main window - at this moment it is created. :) Maybe it is easier than creating small invisible window.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I'm actually using the existing TApplication object as the parent, that works very well also for the breadcrumb bar.
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Great idea. :D
I haven't noticed that nag has same parent as main TC window. :)
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

Post by *Flint »

Confirm the fix.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks!
Author of Total Commander
https://www.ghisler.com
Post Reply