Solved [TC8b1 x64] False colors in Listers menu

[petermad]

See: http://madsenworld.dk/tcmd/listermenu.png

in the 64 bit version each menu item has a gradueted color, in the 32bit version it is uniform 8expected)

I am using a modified Luna theme under win 7.

[ghisler(Author)]

Cannot reproduce - how can I get that theme?

Btw, the Lister menu is drawn by Lazarus, not by TC itself.

[petermad]

Theme: http://satukoro.deviantart.com/art/Luna-Metallic-Port-to-Win7Aero-159299506

You also need a theme patcher if you haven't already patched: http://deepxw.blogspot.com/2008/11/universal-theme-patcher.html

Theme file settings:

Code: Select all

[VisualStyles]
Path=%SystemRoot%\resources\Themes\Luna Metallic Aero\Luna Metallic Aero.msstyles
ColorStyle=NormalColor
Size=NormalSize
ColorizationColor=0X80555555
Transparency=1
Composition=1
VisualStyleVersion=10

[Control Panel\Colors]
Scrollbar=212 208 200
Background=88 87 104
ActiveTitle=192 192 192
InactiveTitle=255 255 255
Menu=240 240 240
Window=255 255 255
WindowFrame=0 0 0
MenuText=1 1 1
WindowText=0 0 0
TitleText=14 16 16
ActiveBorder=212 208 200
InactiveBorder=212 208 200
AppWorkspace=128 128 128
Hilight=178 180 191
HilightText=0 0 0
ButtonFace=224 223 227
ButtonShadow=157 157 161
GrayText=172 168 153
ButtonText=0 0 0
InactiveTitleText=162 161 161
ButtonHilight=255 255 255
ButtonDkShadow=113 111 100
ButtonLight=241 239 226
InfoText=0 0 0
InfoWindow=255 255 225
ButtonAlternateFace=181 181 181
HotTrackingColor=100 139 203
GradientActiveTitle=200 200 200
GradientInactiveTitle=238 239 247
MenuHilight=187 183 199
MenuBar=224 226 235

[ghisler(Author)]

OK, I will check it. However, it will first become worse in Beta 2 because I will let Lazarus draw also the main menu of TC because of other problems reported here in the forum. It will take a while to rewrite the Lazarus component library to handle that.

[Sob]

Lazarus doesn't expect menu background to be left-right gradient and when repainting individual menu items, it passes only the small rect of single item to ThemeDrawElement() and it takes it as whole tiny-width menubar.

Following is "works for me" fix for LCL. It uses full rect of menu and only clipping rect of item.

http://web.hisoftware.cz/sob/download/lcl-win32-menu-gradient-bg-fix.patch

[ghisler(Author)]

Thanks, that works great with petermad's theme! Are you somehow involved with Lazarus development, or how did you manage to figure this out so quickly?

[Sob]

Nope, I'm almost complete stranger to Lazarus. But I have general idea how owner-drawn menus work, so it was the matter of finding the menu item drawing function and checking what it does with background, because it was clearly the problem. :)

[ghisler(Author)]

This should be fixed in beta 2, please try it!

[petermad]

Fixed in TC 8.0b2

[ghisler(Author)]

Thanks, I used the fix suggested by Sob.