[TC8.0b5 x64] FTP files edited by "Compare contents&quo

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
cgh
Junior Member
Junior Member
Posts: 4
Joined: 2006-11-19, 15:16 UTC

[TC8.0b5 x64] FTP files edited by "Compare contents&quo

Post by *cgh »

...can not be uploaded

TC8.0b5 x64 on Win7 (SP1) Home Professional 64 bit

Steps to reproduce:
1. open an FTP connection
2. compare (File/Compare By Content) a text file FTP located with it's different version from local HDD - I think it is necessary to have the same name
3. modify FTP file by copying the entire different lines and try to save and upload it - TC loses the focus on the small windows asking to overwrite exiting file and the buttons (overwrite, skip, rename, cancel,etc) become useless

Code: Select all

---------------------------
Total Commander 8.0ß5
---------------------------
[TCustomForm.SetFocus] FileCompForm:TFileCompForm Can not focus.
[TCustomForm.SetFocus] FileCompForm:TFileCompForm Can not focus
Windows 7 SP1 6.1 (Build 7601)

Please report this error to the Author, with a description
of what you were doing when this error occurred!

Stack trace (x64):4350EE
434FBC 4345F2 7B92DF 989AA8 40F935 7C4282 7B887B 89FCCF
7F5858 77699BD1 522D07 502691 60358F 5F7475 43974E 439540

Press Ctrl+C to copy this report!
Continue execution?
---------------------------
Yes   No   
---------------------------

with 7.56a on the same machine never met this problem

didn't try yet with 8.0b5 32bit

thank you,
cgh
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I will check it, thanks.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Could not reproduce.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Can anyone reproduce this error with beta 7?
Author of Total Commander
https://www.ghisler.com
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

Post by *Flint »

I tried to reproduce the original report in 8.0β5 x64 under Win7 x64 SP1, but I got neither crash nor focus loss, so I cannot test whether it was fixed. Just in case I tested β7 — no problems as well.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
Sob
Power Member
Power Member
Posts: 941
Joined: 2005-01-19, 17:33 UTC

Post by *Sob »

Found something:

http://web.hisoftware.cz/sob/img/tc80b7x64-ftp-compare-upload-lock-up.avi

Maybe not exactly the same, there's no crash, but very likely related.
User avatar
cgh
Junior Member
Junior Member
Posts: 4
Joined: 2006-11-19, 15:16 UTC

Post by *cgh »

yes, that is the behavior, with one exception: I get it editing a file from ftp, not in archive, but the idea is the same - the file has to be downloaded in temp for edit

thank you

PS: the bug is still present in ß6, ß7 and ß8
Sob
Power Member
Power Member
Posts: 941
Joined: 2005-01-19, 17:33 UTC

Post by *Sob »

There's nothing about archives in my video, there's only "7zip" as part of filename. It was simply the first file in my directory used for testing TC betas. :)
User avatar
cgh
Junior Member
Junior Member
Posts: 4
Joined: 2006-11-19, 15:16 UTC

Post by *cgh »

you are right, Sob
the perfect match of the situation just caught my eyes :)
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

I tried to reproduce the original report in 8.0β5 x64 under Win7 x64 SP1, but I got neither crash nor focus loss
Same here with TC 8.0b8 x64 - no problems.

But there is a difference between the 64bit version and the 32bit version:

When I click the close button in the CbC window in the 64 bit version the window doesn't close - it is moved behind TC's main window while the dialogs about reuploading and overwriting is shown. The CbC window is first closed once the file is saved.

In the 32bit version the CbC window is closed before the reupload dialog is shown.

EDIT: while testing this I actually had the bug once, but haven't been able to reproduce it since.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I couldn't reproduce it yet, but your hint about a difference is worth investigating.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

In beta 9, I'm now hiding the compare dialog before re-uploading. Please check whether this fixes your problem or not. I still can't reproduce it - the only way to reproduce it was to switch back to "compare by content" when the re-upload dialog was shown.
Author of Total Commander
https://www.ghisler.com
User avatar
cgh
Junior Member
Junior Member
Posts: 4
Joined: 2006-11-19, 15:16 UTC

Post by *cgh »

thank you very much!

tried few times, different files, different ftp servers: total commander works as expected - the files are saved and uploaded with no trouble, after editing :D
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

I can confirm that TC 8.0b9 x64 now closes the CbC dialog before asking for confirmation to re-upload the file - as the 32bit version does.

I haven't had any crashes yet.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Great, thanks! Please let me know if you encounter any new problems.
Author of Total Commander
https://www.ghisler.com
Post Reply