[TC 8.0ß9 x86] Filter is lost after switching to another tab

Here you can propose new features, make suggestions etc.

Moderators: white, Hacker, petermad, Stefan2

AndrewCreator
Member
Member
Posts: 122
Joined: 2011-10-10, 23:25 UTC

[TC 8.0ß9 x86] Filter is lost after switching to another tab

Post by *AndrewCreator »

Test for x64 is welcome.

Steps to reproduce:
1) Open dir.
2) Filter some results (QuickSearchAutoFilter=1).
3) Open one more tab.
4) Close newly opened tab.
5) Filter will be lost.

Expected behaviour:
Filter remains.

Inconveniences caused:
Should apply the same filter multiply times what is uncomfortable on slow network folders.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

This is intentional, sorry. Only the permanent filter (Ctrl+F12 or menu Show - Custom) is saved, but not the temporary quick search filter.
Author of Total Commander
https://www.ghisler.com
AndrewCreator
Member
Member
Posts: 122
Joined: 2011-10-10, 23:25 UTC

Post by *AndrewCreator »

Thank you for the answer. Could you tell why this is intentional? Is there any use-case when this matters?

Also I would like to admit that filter is lost even if switching to another tab and back in the same panel. But it remains if you switch to another tab in the second panel.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

The problem is that you don't see what is being filtered out with the temporary filter - only a small filter icon is shown. You wouldn't remember a filter on a different tab set 3 weeks ago.
Author of Total Commander
https://www.ghisler.com
AndrewCreator
Member
Member
Posts: 122
Joined: 2011-10-10, 23:25 UTC

Post by *AndrewCreator »

Oh, I caught misunderstanding reason. I should describe the problem with a bit more details.

I open tab1 and filter some results.
Then I open tab2.
I expect that tab1 filter remains on tab1 and I will see it when I switch back to tab1.

So, the filtered results should remain on the tab until the filter is changed or tab is closed.
User avatar
Samuel
Power Member
Power Member
Posts: 1929
Joined: 2003-08-29, 15:44 UTC
Location: Germany, Brandenburg an der Havel
Contact:

Post by *Samuel »

Oh, I caught misunderstanding reason. I should describe the problem with a bit more details.

I open tab1 and filter some results.
Then I open tab2.
I expect that tab1 filter remains on tab1 and I will see it when I switch back to tab1.

So, the filtered results should remain on the tab until the filter is changed or tab is closed.
I think this is exactly what Christian did understand.

The problem he refers too is:
1) I open tab1 and filter some results.
2) Then I open tab2.
3) I work a hour or more on tab2
4) I come back to tab1, overlook the small icon and I cannot find several files.

I partly agree (perhaps it could be an option) because the filter icon is very small. IMO the path bar should be colored red if there are any active filters. Because currently the small icon is easy to overlook.
AndrewCreator
Member
Member
Posts: 122
Joined: 2011-10-10, 23:25 UTC

Post by *AndrewCreator »

Samuel

I think that at least current behaviour is inconsistent.

1) You open tab1 and filter some results.
2) Then you open new TC instance.
3) You work an hour or more in new instance.
4) You come back to tab1, overlook the small icon and cannot find several files.
User avatar
Samuel
Power Member
Power Member
Posts: 1929
Joined: 2003-08-29, 15:44 UTC
Location: Germany, Brandenburg an der Havel
Contact:

Post by *Samuel »

AndrewCreator wrote:Samuel

I think that at least current behaviour is inconsistent.

1) You open tab1 and filter some results.
2) Then you open new TC instance.
3) You work an hour or more in new instance.
4) You come back to tab1, overlook the small icon and cannot find several files.
I agree. See my quote:
Samuel wrote:I partly agree (perhaps it could be an option) because the filter icon is very small. IMO the path bar should be colored red if there are any active filters. Because currently the small icon is easy to overlook.
AndrewCreator
Member
Member
Posts: 122
Joined: 2011-10-10, 23:25 UTC

Post by *AndrewCreator »

Samuel

So the filter in tab should remain as it remains when we open new TC instance. At least there should be an option.

Path bar might be colored (only as option).
User avatar
Samuel
Power Member
Power Member
Posts: 1929
Joined: 2003-08-29, 15:44 UTC
Location: Germany, Brandenburg an der Havel
Contact:

Post by *Samuel »

IMO no. Its about probabilities.
AndrewCreator
Member
Member
Posts: 122
Joined: 2011-10-10, 23:25 UTC

Post by *AndrewCreator »

Ok, I understand your opinion. Let's wait for Christian.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Maybe it would indeed be a good idea to remove the filter when you switch away from TC and back. But that may also be inconvenient when editing a few filtered files. IMHO it's much easier to keep track of just one or two filters, than of multiple tabs with different filters in each.
Author of Total Commander
https://www.ghisler.com
AndrewCreator
Member
Member
Posts: 122
Joined: 2011-10-10, 23:25 UTC

Post by *AndrewCreator »

It would be really bad idea to remove the filter after focus lost!

Another bad idea would to remove the filter when switching to another tab in other panel.

So, we have 3 cases:

1) Filter is lost after switching to another tab in the same panel.
2) Filter remains after switching to another tab in the other panel.
3) Filter remains after losing focus.

Case 1) is not consistent with cases 2) and 3).

There are 3 solutions:
1) Retain inconsistency.
2) Fix case 1)
3) Fix cases 2) and 3)

Solution 3) is not suitable anyway, it will break very useful TC feature.
User avatar
Samuel
Power Member
Power Member
Posts: 1929
Joined: 2003-08-29, 15:44 UTC
Location: Germany, Brandenburg an der Havel
Contact:

Post by *Samuel »

IMO the only consistent way to solve it is to make the filter state more obvious.

What if I open TC, filter, go for lunch, cant find file x...
IMO the Pathbar should be red if any filtering on the file panel is done. (Ctrl+S, Ctrl+F11 or Ctrl+F12)
User avatar
Horst.Epp
Power Member
Power Member
Posts: 6450
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Post by *Horst.Epp »

Samuel wrote:IMO the only consistent way to solve it is to make the filter state more obvious.
What if I open TC, filter, go for lunch, cant find file x...
IMO the Pathbar should be red if any filtering on the file panel is done. (Ctrl+S, Ctrl+F11 or Ctrl+F12)
Not a good idea !
This conflicts with color settings used for the active and inactive windows.
Post Reply