Unfinished in-place renamed file/folder don't dismiss

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

MarianD
Junior Member
Junior Member
Posts: 52
Joined: 2009-05-27, 21:33 UTC
Location: Bratislava, Slovakia

Post by *MarianD »

ghisler(Author) wrote:The edit box disappears
Yes, but the rename edit box don't disappears - for example, after clicking on another file / folder - if the scrolling by the mouse wheel had no effect (because you try to scroll to the wrong direction when the list is already scrolled to its begin or end).
MarianD
Junior Member
Junior Member
Posts: 52
Joined: 2009-05-27, 21:33 UTC
Location: Bratislava, Slovakia

Post by *MarianD »

ghisler(Author) wrote:I can reproduce the problem now when turning the scroll wheel while the rename box is open.
I am not able to reproduce it now. In my previous post I probably had TC already in this odd state but I recognized it only after trying reproduce it by turning the scroll wheel during opened rename box.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Strange, and I cannot reproduce what you report...
Author of Total Commander
https://www.ghisler.com
Sob
Power Member
Power Member
Posts: 941
Joined: 2005-01-19, 17:33 UTC

Post by *Sob »

As I wrote before about problem being possibly related to "two clicks to rename", it's probably supposed to be "click on already selected item", I actually never really thought about what it is, because I don't use it often, as it's too slow for me.

I played with it a little again and I noticed some things:

1) When you try the same in Explorer (click already selected item), rename edit is displayed instantly. In TC there's slight delay. It's hard to tell how much, my guess is 200-300 ms.

2) In TC, it's possible to have "Item A" selected, click it again and quickly during the above delay click "Item B" and it shows rename edit for "Item B". It's correct that rename edit for "Item A" was not shown, it was canceled by clicking "Item B". But it's wrong that rename edit for "Item B" was shown, because it was clicked only once.

Now for me the interesting question is where this delay in TC comes from. If it's something intentional or if TC is actually waiting for something (doing some stuff). Basically I'm wondering if there might be some even smaller time window possible, when the new event (click elsewhere) could interfere with progress of displaying the edit, so TC would show it, but fail to remember that it did so. And later it would think it's not open and wouldn't try to close it.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

1) Yes, this is intentional, TC uses a timer. It should prevent the rename box from appearing in case of accidental clicks, or when the user wanted to double click.
2) Yes, it's strange, but TC only checks that the file under the cursor is the same as the current file (with the caret).

But what does this have to do with the non-disappearing rename box?
Last edited by ghisler(Author) on 2011-12-18, 16:01 UTC, edited 1 time in total.
Author of Total Commander
https://www.ghisler.com
Sob
Power Member
Power Member
Posts: 941
Joined: 2005-01-19, 17:33 UTC

Post by *Sob »

Maybe nothing, maybe a lot. As I wrote, I once succeeded to reproduce this bug by only repeatedly selecting files, starting rename using this another click on selected file and canceling it by clicking elsewere. After about two minutes I had non-dissapearing rename box. Unfortunately it's not reliable way to reproduce it, second time it did not work. But it seems to me it might be related.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

OK, just let me know if you find a way to reproduce it. The scrolling with the scrollbar should no longer cause the problem in beta 13.
Author of Total Commander
https://www.ghisler.com
User avatar
romulous
Senior Member
Senior Member
Posts: 226
Joined: 2003-11-19, 04:10 UTC

Post by *romulous »

The instance of this problem on my PC was not caused by scrolling either. Apart from the information I've already given previously on how it occurred for me, I can't be of any more help I'm afraid :(
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Sorry, I cannot help you without any step by step instructions to reproduce the problem.
Author of Total Commander
https://www.ghisler.com
User avatar
romulous
Senior Member
Senior Member
Posts: 226
Joined: 2003-11-19, 04:10 UTC

Post by *romulous »

-Install XCD: http://mitglied.multimania.de/matbal/
-Open TC x64, Alt+F10 and then F2 to refresh the tree
-Afterwards, run XCD, type a folder name in and then hit Enter
-Once XCD finds the folder, make sure it is highlighted and hit Enter
-It will either work ok (in which case XCD will close and send you to that folder in TC), or it won't (the XCD window will close but you won't be in the folder). I've noticed that sometimes when it doesn't work, the TC window is fine (ie no rename box problem). However, other times you will see the problem
-If you don't see the problem, run XCD again and type in another folder name. Repeat XCD searching until the problem occurs. It doesn't happen 100% of the time for me, it might happen on the first try after opening TC, it might happen on the 10th, it might happen on the 100th. It will eventually happen though.
MarianD
Junior Member
Junior Member
Posts: 52
Joined: 2009-05-27, 21:33 UTC
Location: Bratislava, Slovakia

Post by *MarianD »

I finally caught it - I am able to reproduce the problem! Change the actual folder by typing in the title of the panel. From this moment is TC in this odd state, when the rename edit box don't disappears after clicking on another file/folder.

TC 8.0ß13 64-bit, Windows 7 64-bit
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

2MarianD
Yes, I can reproduce that too, thanks! The two use the same edit control for renaming...
Author of Total Commander
https://www.ghisler.com
MarianD
Junior Member
Junior Member
Posts: 52
Joined: 2009-05-27, 21:33 UTC
Location: Bratislava, Slovakia

Post by *MarianD »

It seems that the bug is now totally fixed. Thanks!

TC 8.0ß14 64-bit, Windows 7 64-bit
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks!
Author of Total Commander
https://www.ghisler.com
Post Reply