[9.0b2] Inplace rename - file sorting if RenameUpDown=1

[jvh]

Steps to reproduce:

1. Press Shift+F6 on any file and rename it
2. Press up or down key (go to another file)
3. Press Enter
-> renamed file isn't sorted

Repeat steps 1 and 2
Press Esc
-> renamed file is sorted

[Dalai]

This is (may be?) intentional. See http://ghisler.ch/board/viewtopic.php?t=44199

Regards
Dalai

[jvh]

This is (may be?) intentional. See http://ghisler.ch/board/viewtopic.php?t=44199

Regards
Dalai

Can be, but Enter should close renaming (especialy if Esc does it too).

[Samuel]

Confirmed. I think this is what I could not reproduce previously:

Code: Select all

10.06.16 Fixed: Inplace rename, use up/down to go to previous/next file: delay re-loading directory until rename is closed (32/64)

Seems to be fixed.

I don't know for sure, but in my first tests it looked like the list got never sorted. However I can't reproduce this anymore. Currently it seems to work.

Perhaps some people should check on this.

The files are not sorted, if the last file edited was not changed and editing was finished by pressing "Enter" - pressing "ESC" or using the mouse to focus something else is fine.

[ghisler(Author)]

Yes, this is intentional: The user may want to rename multiple files in a row. In beta 1, the list was sorted, so the rename box was jumping around wildly.

[Dalai]

2ghisler(Author)
The file list should be sorted after the rename operation is complete. ENTER marks the end of a rename operation, even for multiple files, does it not?

Regards
Dalai

[Samuel]

Yes, this is intentional: The user may want to rename multiple files in a row. In beta 1, the list was sorted, so the rename box was jumping around wildly.

No it is not (IMO), please read the first post carefully.

1) Press Shift+F6 on file #1 and rename it
2) Press down key to start editing file #2
2a) the file list is not sorted instantly, what is a nice and working feature of beta 2
3) Do not change the file name of file #2 and press Enter to finish editing
3b) the file list is not sorted after the last file changed, what is a bug of beta 2

If in step 3:
A) the file name gets changed or
B) the rename process is canceled by pressing ESC or
C) the rename process is canceled by any kind of focus change
then everything works as expected. (the file list is sorted after the last file changed)

[ghisler(Author)]

Ah, sorry, I misunderstood. I have fixed it now for beta 3.

[Samuel]

Thank you very much.

[Samuel]

Code: Select all

22.06.16 Fixed: Rename file with Shift+F6, go to next with cursor up/down, then just press ENTER (no change) -> list was not sorted as it should be (32/64)

I cannot reproduce the problem in TC 9 beta 3. Thank you.

Code: Select all

20.06.16 Fixed: Inplace edit of current path: Prevent cursor up/down to jump into the file list (32/64)

A little bit offtopic: I confirm the bug in beta 2 and the fix in beta 3.

[jvh]

Fixed in 9.0b3, thanks!