TC crashes with the WebDAV plugin

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
bugboy
Junior Member
Junior Member
Posts: 4
Joined: 2013-09-04, 10:16 UTC

TC crashes with the WebDAV plugin

Post by *bugboy »

When connecting to an NWebDAV based server using the WebDAV plugin, then TC crashes without any further message. Other WebDAV clients seem to work fine with NWebDAV based servers.

The NWebDAV server is an open-source WebDAV server, developed by me, that aims to be as compatible as possible.

Because TC doesn't show any errors, it's very hard for me to determine what is wrong. I think that a TC crash is always a bug, but if it is caused because an invalid WebDAV response then please let me know.

You can either reply in this thread or on the GitHub issue. Whatever you like :)
Last edited by bugboy on 2016-12-13, 21:36 UTC, edited 1 time in total.
bugboy
Junior Member
Junior Member
Posts: 4
Joined: 2013-09-04, 10:16 UTC

Post by *bugboy »

I have setup a test account. Please use the following settings:
Hostname: fileshare.rimote.net
SSL: enabled
Username: nwebdav@ramondeklein.nl
Password: test

This post has been filed, because of the following bug report on GitHub: https://github.com/ramondeklein/nwebdav/issues/8.
CoolWater
Power Member
Power Member
Posts: 737
Joined: 2003-03-27, 16:33 UTC

Post by *CoolWater »

2bugboy

No crash here. Log says:

Code: Select all

CONNECT \Test
=================
Get dir: \
PROPFIND / HTTP/1.1
Depth: 1
Content-type: text/xml; charset="utf-8"
User-Agent: ezdavplugin/2.8 TotalCommander/9.0 (Windows/8; en_EN)
Host: fileshare.rimote.net
Content-Length: 0
Connection: Keep-Alive
Cache-Control: no-cache
Cookie: RiwoToken=mUgQNz5TH80KgpcXf8KLzTj7xadLkTZ_PT75fFXtHKA3T4VrZfnsXncI-qyzq1sCRbPfJTJB1bZ5OgIPHmoTdxMx9a2LoXAbtVxGJ7e6rCjQbfUTMp4d7MdNiDy0qJwfA_7r63DT1BvMd1w0SquHN5Fqh33-9yd640_miDIfVSl_sExhPYHiIcGI5fM3pst2
******Received headers
HTTP/1.1 207 Multi-Status
Content-Length: 3561
Content-Type: text/xml; charset="utf-8"
Server: NWebDav/0.1.16.0 Microsoft-HTTPAPI/2.0
Date: Wed, 14 Dec 2016 09:36:38 GMT
207 Multi-Status
Disconnected
HTH
CoolWater
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I did get a crash, but in the 64-bit version only. The crash is in the WebDAV plugin (which is open source). I will try to find the reason in the debugger.
Author of Total Commander
https://www.ghisler.com
CoolWater
Power Member
Power Member
Posts: 737
Joined: 2003-03-27, 16:33 UTC

Post by *CoolWater »

It seems that the WebDav plugin cannot handle the response correctly. At least here, no directory listing is shown. Since Content-Length is set and also Content-Type, data is available.
bugboy
Junior Member
Junior Member
Posts: 4
Joined: 2013-09-04, 10:16 UTC

Post by *bugboy »

ghisler(Author) wrote:I did get a crash, but in the 64-bit version only. The crash is in the WebDAV plugin (which is open source). I will try to find the reason in the debugger.
Nice to hear that you want to look into the problem. If I can assist in any way, then don't hesitate to contact me.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I found the problem: It's caused by the byte order marker (BOM) at the start of the file listing! The xml library which I'm using detects it, but doesn't skip it (the "next" pointer is not set). Fortunately it's not a critical bug, it cannot be used for remote code execution.

I have updated the plugin on our homepage here:
http://www.ghisler.com/plugins.htm#filesys
Author of Total Commander
https://www.ghisler.com
bugboy
Junior Member
Junior Member
Posts: 4
Joined: 2013-09-04, 10:16 UTC

Post by *bugboy »

Thanks very much. I'll update the GitHub issue.
Post Reply