This forum uses cookies. Click X button to hide this message. What is stored? 
Total Commander Forum Index Total Commander
Forum - Public Discussion and Support
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

TC4A TCMP: restore playlist and removed tracks

 
Post new topic   Reply to topic    Total Commander Forum Index -> Total Commander for Android Printable version
View previous topic :: View next topic  
Author Message
DrShark
Power Member
Power Member


Joined: 03 Nov 2006
Posts: 928
Location: Kyiv, 68/262

PostPosted: Wed Aug 23, 2017 4:53 pm    Post subject: TC4A TCMP: restore playlist and removed tracks Reply with quote

Since TC4A v. 2.80 TCMP restores playlist if the player reopened (for example using a button with command 137) after being closed using red X button or Android Navigation Bar buttons/keys.

However, what I see wrong in this feature is that it also restores the tracks explicitly removed from playlist by user using the "Remove"/"Remove all"/"Remove all above" track context menu items. I think such tracks shouldn't be restored.
_________________
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
Back to top
View user's profile Send private message
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 34715
Location: Switzerland

PostPosted: Thu Aug 24, 2017 3:45 am    Post subject: Reply with quote

Hmm, I'm not so sure about that - consider the situation where a user deletes the entire list and closes the player.
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
DrShark
Power Member
Power Member


Joined: 03 Nov 2006
Posts: 928
Location: Kyiv, 68/262

PostPosted: Fri Aug 25, 2017 2:31 am    Post subject: Reply with quote

ghisler(Author) wrote:
consider the situation where a user deletes the entire list and closes the player.
if user removes entire playlist using one of mentioned "Remove..." options, it's supposed one may want to make it empty (for example to add new files later using player's "Add files" ("+" button) option.)

If user wants to have playlist restored later, it's possible to just close the player using player's X button.
_________________
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
Back to top
View user's profile Send private message
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 34715
Location: Switzerland

PostPosted: Mon Aug 28, 2017 4:38 am    Post subject: Reply with quote

OK, changed that in the latest beta 8! Please try it.

Play store:
https://www.ghisler.com/betatc
APK:
https://www.ghisler.com/tcbeta.apk
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
DrShark
Power Member
Power Member


Joined: 03 Nov 2006
Posts: 928
Location: Kyiv, 68/262

PostPosted: Mon Aug 28, 2017 6:38 pm    Post subject: Reply with quote

ghisler(Author) wrote:
OK, changed that in the latest beta 8! Please try it.
history2.txt wrote:
2017-08-27 Fixed: Media player: Save playlist on exit even after deleting tracks, just not after "delete all"
That just not after "delete all" part means that at least one track is always restored in playlist, so the use case described in previous post is not covered by such solution (it's possible to get the emtpy playlist saved/restored using re-adding by Open with -> TotalCmd (Queue) a single track in playlist, but too many steps required to achive it this way.)
_________________
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
Back to top
View user's profile Send private message
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 34715
Location: Switzerland

PostPosted: Thu Aug 31, 2017 2:19 am    Post subject: Reply with quote

Yes, that's intentional - it's just when you choose to remove all tracks - it could be by accident. If you remove one by one, the empty list should be stored.
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
DrShark
Power Member
Power Member


Joined: 03 Nov 2006
Posts: 928
Location: Kyiv, 68/262

PostPosted: Mon Sep 04, 2017 3:55 am    Post subject: Reply with quote

ghisler(Author) wrote:
If you remove one by one, the empty list should be stored.
I cannot confirm it:
a) if I remove tracks one by one using Remove context item and restart the player using either a button with internal command 137 or button TotalCmd (Queue) activity as a command, all tracks are restored;
b) if I remove tracks all tracks except one using either Remove all above or Remove all below context menu item, and then remove last track usilon Remove context item, and restart the player using either a button with internal command 137 or button TotalCmd (Queue) activity as a command, the last track restored.
_________________
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
Back to top
View user's profile Send private message
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 34715
Location: Switzerland

PostPosted: Mon Sep 04, 2017 6:53 am    Post subject: Reply with quote

Yes, it's an additional measure to never store empty list.
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
DrShark
Power Member
Power Member


Joined: 03 Nov 2006
Posts: 928
Location: Kyiv, 68/262

PostPosted: Thu Sep 07, 2017 1:00 am    Post subject: Reply with quote

That are false statments then:
ghisler(Author) wrote:
If you remove one by one, the empty list should be stored.
history2.txt wrote:
2017-08-27 Fixed: Media player: Save playlist on exit even after deleting tracks, just not after "delete all"

because:
DrShark wrote:
if I remove tracks one by one [or] [...] using either Remove all above or Remove all below context menu item, and then remove last track using Remove context item, and restart the player using either a button with internal command 137 or button TotalCmd (Queue) activity as a command, the last track restored.
ghisler(Author) wrote:
Yes, it's an additional measure to never store empty list.


The whole point of this topic is to let user have playlist restored as is (even empty!) after intentional removing the tracks using "Remove ..." track context menu items. Can you try at least add an option to have desired behavior?
_________________
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    Total Commander Forum Index -> Total Commander for Android All times are GMT - 6 Hours
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Impressum: This site is maintained by Ghisler Software GmbH

Using phpBB © 2001-2005 phpBB Group