[solved] Replacing Photo app. with PhotoViewer broken

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
petermad
Power Member
Power Member
Posts: 14700
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

[solved] Replacing Photo app. with PhotoViewer broken

Post by *petermad »

This feature seems to be broken in TC 9.10 with Windows 10 version 1709 Fall Creators Update:

In the dialog box "Files" - "Associate with", but only on Windows 10, and only when a file type is associated with the Windows Photos app. Then TC shows:
[X] Replace with:
PhotoViewer.dll
Last edited by petermad on 2021-05-30, 11:39 UTC, edited 1 time in total.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48010
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

What exactly doesn't work? I have just tried both TC 32-bit and 64-bit in fall creators update, and ENTER opens JPG files in Windows Photos (the desktop program) just fine.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14700
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

This is how my association for jpg files look like after installation of Fall Creators Update:
http://madsenworld.dk/tcmd/photoviewer.png
And with this setting it is Windows' (very slow) Photo App that opens jpg files when pressing Enter.

Maybe YOUR association looks like this:
http://madsenworld.dk/tcmd/photoviewer2.png
where I manually have changed the association via Windows' context menu's "Open With"
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48010
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

This is how my association for jpg files look like after installation of Fall Creators Update:
http://madsenworld.dk/tcmd/photoviewer.png
And with this setting it is Windows' (very slow) Photo App that opens jpg files when pressing Enter.
That's exactly how it looks like here too. Because of the checkbox, TC uses the desktop program (my German Windows 10 shows it as "Windows-Fotoanzeige").
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14700
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

The problem is that with the setting as shown in: http://madsenworld.dk/tcmd/photoviewer.png it is NOT the "Windows Photo Viewer" ("Windows Billedfremviser" in Danish) that is used - as expected.

In stead it is the "Photos" App ("Billeder" in Danish) that is used - so the checkmark in "Replace with: PhotoViewer.dll" is without effect!

This it what is being used in my current Windows 10 with the "Replace with: PhotoViewer.dll" setting:
http://madsenworld.dk/tcmd/photos-app-sample.png

And this is what I expect to use as previously:
http://madsenworld.dk/tcmd/photoviewer-sample.png
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48010
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I cannot reproduce that, sorry. It's as if PhotoViewer.dll is missing on your system. TC does the following:
1. Use path:
%ProgramFiles%\Windows Photo Viewer\PhotoViewer.dll
2. Replace %ProgramFiles% with environment variable.
3. Check whether the file exists - if yes, use this, otherwise use real association

I have checked, it works with both TC 32-bit and 64-bit here.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14700
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

I have both
C:\Program Files\Windows Photo Viewer\PhotoViewer.dll
and
C:\Program Files (x86)\Windows Photo Viewer\PhotoViewer.dll

BTW - if I didn't have the PhotoViewer.dll file, I couldn't show you this: http://madsenworld.dk/tcmd/photoviewer-sample.png

The PhotoViewer.dll files are brand new from 29-09-2017 fileversion: 10.0.16299.15

The previous PhotoViewer.dll files from before the Fall Creators Update (1709) was from 07-07.2017 fileversion: 10.0.15063.483

As I told you I didn't have the problem before the last Windows update.

It is not a big deal, I can just manually associate to Windows Photo Viewer, and I anyway mostly use TC plugins to view images. I just wanted you to know that at least here TC's feature to replace the Photos App with PhotoViewer.dll is broken.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48010
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I have the exact same versions here!

Can you try opening it manually from the TC command line?

Code: Select all

%SystemRoot%\System32\rundll32.exe "%ProgramFiles%\Windows Photo Viewer\PhotoViewer.dll", ImageView_Fullscreen "c:\path\image file name.jpg"
Maybe you have x64DisableRedirection=1 set? Then %SystemRoot%\System32 would find the wrong rundll32.exe.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14700
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Tried that in both 64bit TC 9.10 and in 32bit TC both with x64DisableRedirection=1 and x64DisableRedirection=0 - and it works fine in all 3 cases.

It also works when I manually change the association as I showed earlier in http://madsenworld.dk/tcmd/photoviewer2.png

But I just tested with a clean ini file - and there it works! - so now I just have to find out which setting is preventing it from working in my usual setting.


EDIT: :!:
I found the culprit - it was an internal association like this: http://madsenworld.dk/tcmd/internalassoc.png where I had used ** as the "Open" action that caused it.

So apparently the replacement with PhotoViewer.dll does not take place when ** for "default system association" is used.

But I found out that if I just leave the "Open" field blank, then the PhotoViewer.dll replacement works.

So I was wrong about the Fall Creators Update being the reason - apparantly I just hadn't noticed eralier.

Maybe it should be changed so that the PhotoViewer.dll replacement also works for the ** action.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48010
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Ah, that makes sense - ** tells TC to use the Windows association, and leaving the field empty means "no change". I will consider changing it since it's causing confusion.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14700
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Changed in TC 9.11rc1 to treat ** the same ad empty firld - Thanks :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Post Reply