Page 1 of 1

Is there a reason why we don't have an https file plugin?

Posted: 2019-05-07, 14:46 UTC
by MauriceSnell
Is there a reason why we don't have an https file plugin? Or is there one but I'm missing it?

I mean are we just waiting for someone to get around to writing it, or is there a technical reason why it hasn't been done?

As far as I know, we have easy-to-use general purpose http file plug-ins, which allow downloading bulk content from most http web-sites, and we have WebDAV which can be used in some specific cases - but isn't a general way to copy content from most https web-sites.

Re: Is there a reason why we don't have an https file plugin?

Posted: 2019-05-07, 16:34 UTC
by DrShark
There is a WFX HTTPS Browser plugin.

Re: Is there a reason why we don't have an https file plugin?

Posted: 2019-05-07, 19:26 UTC
by MauriceSnell
Thanks for that - as it wasn't on the main ghisler.com site I didn't know.

Unfortunately it crashes TC during installation - at the point where it tries to open the list of plugins. I've tried a few times, with V9.20 and the latest V9.22a 64-bit TC. I am using the install method of opening the zip file from within TC. I also tried manually adding it - and TC still crashes as soon as the wfx64 file is selected.

Any suggestions please?

Re: Is there a reason why we don't have an https file plugin?

Posted: 2019-05-07, 21:05 UTC
by DrShark
MauriceSnell wrote:
2019-05-07, 19:26 UTC
Unfortunately it crashes TC during installation ... Any suggestions please?
I don't have access to 64-bit Windows right now to check it (the plugin is 64-bit only).
You can try to contact plugin authors about your error:
  • original HTTPS Browser plugin developer, WouterVanNifterick, by creating a new issue on original plugin github project
  • rg-software, who forked and compiled this plugin, using his contacts on github or website
You can also provide (both here and to plugin authors in case you'll contact them) additional information about an error like your Windows version and, if present, the text of specific error messages.

Re: Is there a reason why we don't have an https file plugin?

Posted: 2019-05-07, 21:25 UTC
by Hacker
Works fine for me. Windows 10 x64, TC 9.22a x64.

Roman

Re: Is there a reason why we don't have an https file plugin?

Posted: 2019-05-07, 21:35 UTC
by Usher
DrShark wrote:
2019-05-07, 21:05 UTC
I don't have access to 64-bit Windows right now to check it (the plugin is 64-bit only).
(...)
rg-software, who forked and compiled this plugin, using his contacts on github or website
This fork contains both 32- and 64-bit version, but i haven't tried it yet.

Re: Is there a reason why we don't have an https file plugin?

Posted: 2019-05-07, 22:12 UTC
by DrShark
Usher wrote:
2019-05-07, 21:35 UTC
This fork contains both 32- and 64-bit version, but i haven't tried it yet.
You are right, version on totalcmd.net from 03.12.2018 is x64-only, and github release version is from 13.12.2018 which includes both 32- and 64-bit plugins.
2MauriceSnell
Try to install plugin version from github in 32-bit Total Commander.

Re: Is there a reason why we don't have an https file plugin?

Posted: 2019-05-08, 09:05 UTC
by MauriceSnell
It also works for me on Win 10 64-bit, but crashes on 64-bit Server 2008 R2 Standard - where I first tried it.

Re: Is there a reason why we don't have an https file plugin?

Posted: 2019-05-08, 09:10 UTC
by MauriceSnell
It works, (on WIn10) to access https sites that don't need a user login. I can't see any way to enter username and password and access password-protected sites.

Re: Is there a reason why we don't have an https file plugin?

Posted: 2019-05-08, 10:57 UTC
by Usher
Have you tried to use the canonical way, that is to provide username and password in URL? Something like that:

Code: Select all

https://username:password@example.domain.invalid/

Re: Is there a reason why we don't have an https file plugin?

Posted: 2019-05-08, 12:27 UTC
by Usher
The HTTPS plugin in general is the same as the original HTTP plugin by Fabio Chelly, which is available there: http://totalcmd.net/plugring/http.html
You can find there full readme with plugin description.
Note that the old canonical way is deprecated now. Many sites force interactive logging in, ignoring data in fields autofilled by the browser or using CATPCHA to confirm provided credentials.

Re: Is there a reason why we don't have an https file plugin?

Posted: 2019-05-08, 16:47 UTC
by petermad
Hmm, neither the version from http://totalcmd.net/plugring/https_browser.html or the version from https://github.com/rg-software/wfx-https-browser/releases can be installed in my TC 32bit and 64bit under Windows 7 :!:

It works OK under Windows XP, 8.1 and 10 though :)

Re: Is there a reason why we don't have an https file plugin?

Posted: 2019-05-08, 18:22 UTC
by Dalai
After taking a look at the source code, my guess is that the plugin messes up the DLL entry/exit pointers because it doesn't save them but just overwrites them. This is how it looks currently:

Code: Select all

procedure DLLEntryPoint(dwReason: DWORD);
begin
  case dwReason of
    DLL_PROCESS_ATTACH : ...
    DLL_PROCESS_DETACH : ...
  end;
end;

begin
  DllProc := @DLLEntryPoint;
  DLLEntryPoint(DLL_PROCESS_ATTACH);
end.
And this is how it should look like (IMO):

Code: Select all

var SaveDllProc    : TDllProc;

procedure DllEntryPoint(dwReason: DWORD);
begin
    case dwReason of
        DLL_PROCESS_ATTACH : ...
        DLL_PROCESS_DETACH : ...
    end;
    if Assigned(SaveDllProc) then
        SaveDllProc(dwReason);
end;

begin
    // save exit procedure chain
    SaveDllProc:= DllProc;

    // install DllEntryPoint procedure
    DllProc:= @DllEntryPoint;
    DllEntryPoint(DLL_PROCESS_ATTACH);
end.
As I said, just a guess.

Regards
Dalai

Re: Is there a reason why we don't have an https file plugin?

Posted: 2019-05-09, 08:51 UTC
by DrShark
On my Vista 32-bit plugin installs and works fine.

On Windows 7 32-bit I can confirm plugin install fails with Total Commander crash and error:

Code: Select all

---------------------------
Application Error
---------------------------
Exception ENetHTTPClientException in module httpsbrowser.wfx at 002743AE.Error obtaining session handle.
---------------------------
ОК   
---------------------------
If to install it manually by writing its entry in [FileSystemPlugins] section of wincmd.ini, on try to access it in Network Neighborhood via Enter or Alt+Enter, it also crashes Total Commander with following errors:

Code: Select all

---------------------------
Application Error
---------------------------
Exception ENetHTTPClientException in module httpsbrowser.wfx at 002743AE.

Error obtaining session handle.


---------------------------
ОК   
---------------------------

Code: Select all

---------------------------
Total Commander
---------------------------
Error, could not load plugin!

c:\totalcmd\plugins\wfx\HTTPSBrowser\httpsbrowser.wfx
---------------------------
ОК   
---------------------------
On Windows 7, setting a compatibility mode for Total Commander to Windows Vista, or any other compatibility changes like running as administrator don't help to avoid the crash.

I'll try to contact plugin authors about this error.