[TC 9.21rc2 x64] Wrong wincmd.ini section used for IconsInMenus setting

Bug reports will be moved here when the described bug has been fixed

Moderators: Stefan2, white, sheep, Hacker

Post Reply
User avatar
petermad
Power Member
Power Member
Posts: 8073
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

[TC 9.21rc2 x64] Wrong wincmd.ini section used for IconsInMenus setting

Post by *petermad » 2018-08-01, 22:49 UTC

History.txt:
01.08.18 Fixed: Moved DPI dependent main menu icon sizes from [Configuration] to resolution-specific section for full multiple screen support, e.g. to [1920x1080 (16x20)] (32/64)
This it not what happens in TC 9.21rc2 x64 - if I use 1920x1080 resolution and change the menu icon size the change is NOT saved under [1920x1080 (8x16)], but is saved as:

Code: Select all

[C:\Users\Username\AppData\Roaming\GHISLER\wincmd.ini]
IconsInMenus_96=0
or when using UseIniInProgramDir=7 it is saved as:

Code: Select all

[C:\totalcmd\wincmd.ini]
IconsInMenus_96=0
It works OK in the 32bit version.
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.92b1 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36554
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 9.21rc2 x64] Wrong wincmd.ini section used for IconsInMenus setting

Post by *ghisler(Author) » 2018-08-02, 09:18 UTC

Thanks, looks like I didn't copy all changes to the 64-bit code. I'm usually changing the 32-bit version first, and when it all works, copy the changes to the 64-bit version via "Compare by content".
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 8073
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [TC 9.21rc2 x64] Wrong wincmd.ini section used for IconsInMenus setting

Post by *petermad » 2018-08-02, 11:29 UTC

BTW In a section like [1920x1080 (8x16)] - what does the (8x16) stand for? I have never seen anything but (8x16) for any resolution I have used, but in the Help you use [1024x768 (10x20)] as an example.
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.92b1 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
Usher
Member
Member
Posts: 141
Joined: 2011-03-11, 10:11 UTC

Re: [TC 9.21rc2 x64] Wrong wincmd.ini section used for IconsInMenus setting

Post by *Usher » 2018-08-02, 15:29 UTC

I think that 8x16 is for standard (100%) font size scaling, 10x20 is for 125%. It may be needed when two or more monitors are in use.
Regards from Poland
Andrzej P. Wozniak

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36554
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 9.21rc2 x64] Wrong wincmd.ini section used for IconsInMenus setting

Post by *ghisler(Author) » 2018-08-03, 10:30 UTC

It's the values returned by Windows function GetDialogBaseUnits - it's a measure for the scaling.
Author of Total Commander
http://www.ghisler.com

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36554
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 9.21rc2 x64] Wrong wincmd.ini section used for IconsInMenus setting

Post by *ghisler(Author) » 2018-08-05, 07:15 UTC

According to my tests, only the saving doesn't work in TC 64-bit. Once it's stored in the section (via TC 32-bit), it also works in TC 64-bit. Can anyone with multiple screens confirm that, please?
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 8073
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [TC 9.21rc2 x64] Wrong wincmd.ini section used for IconsInMenus setting

Post by *petermad » 2018-08-05, 09:27 UTC

My dual screen setup is on a Windows 7 PC, so I cannot set different DPI-scaling for each monitor.

But to test I did this:
1. I deleted all IconsInMenus settings both in the [Configuration] and in my [1920x1080 (8x16)] section.
2. Then I started the 32bit version of TC and changed the icon size in menus to 24x24.
3. This corerctly sets IconsInMenus_96=1 in the [1920x1080 (8x16)] section.
4. I now deleted IconsInMenus=21 in the [Configuration] section.
5. I then started the 64bit version of TC, and the icons in the menus are still shown as 24x24, indicating that the 64bit version reads the IconsInMenus_96=1 in the [1920x1080 (8x16)] section - if not, they would have been show with the default 16x16 size.
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.92b1 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36554
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 9.21rc2 x64] Wrong wincmd.ini section used for IconsInMenus setting

Post by *ghisler(Author) » 2018-08-08, 16:15 UTC

This should be fixed in RC3 64-bit now, please test!
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 8073
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [TC 9.21rc2 x64] Wrong wincmd.ini section used for IconsInMenus setting

Post by *petermad » 2018-08-08, 21:54 UTC

Confirmed fixed in TC 9.21 rc3 :-)

I have also checked with redirected [1920x1080 (8x16)] and [AllResolutions] when ResolutionSpecific=0
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.92b1 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36554
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 9.21rc2 x64] Wrong wincmd.ini section used for IconsInMenus setting

Post by *ghisler(Author) » 2018-08-09, 09:53 UTC

Thanks a lot!
Author of Total Commander
http://www.ghisler.com

Post Reply