Dark Mode, Copy progress dialog: Pause/Start button becomes light if pressed with keyboard

Bug reports will be moved here when the described bug has been fixed

Moderators: sheep, Hacker, Stefan2, white

Post Reply
User avatar
DrShark
Power Member
Power Member
Posts: 1548
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Dark Mode, Copy progress dialog: Pause/Start button becomes light if pressed with keyboard

Post by *DrShark »

To reproduce:
1. Start or switch TC to dark mode.
2. Start copying of some big file, so you'll have enough time to press buttons in Copy progress dialog.
3. Press "Pause" button with keyboard (Shift+Tab, Enter): it will become a light-themes "Start" button.
Pressing "Start" button with keyboard will turn it to a light-themed "Pause" button.

Reproduced using Total Commander 9.50 RC1, Vista 32-bit with classic theme.
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39109
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Dark Mode, Copy progress dialog: Pause/Start button becomes light if pressed with keyboard

Post by *ghisler(Author) »

Unfortunately there are a few problems with classic theme which cannot be fixed easily. For example, when you press the Alt key in a dialog, some buttons may get a light text overlayed. This happens when Windows draws on the button bypassing the WM_PAINT message, so I don't get the chance to overdraw the white text with dark.
Author of Total Commander
http://www.ghisler.com

User avatar
DrShark
Power Member
Power Member
Posts: 1548
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: Dark Mode, Copy progress dialog: Pause/Start button becomes light if pressed with keyboard

Post by *DrShark »

history950.txt wrote:28.01.20 Fixed: Dark mode, classic theme: Pause copying with ENTER on Pause button showed normal (not dark) pause/start button (32/64)
It's fixed for original conditions in TC 9.50 RC2, but now if after pressing Start/Pause to press Cancel button, the

Code: Select all

---------------------------
Total Commander
---------------------------
User abort!
---------------------------
OK   Cancel   
---------------------------
dialog will appear and Start/Pause button will again become light.
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39109
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Dark Mode, Copy progress dialog: Pause/Start button becomes light if pressed with keyboard

Post by *ghisler(Author) »

I have seen that too, but didn't fix it because it goes away when you click OK or Cancel.
Author of Total Commander
http://www.ghisler.com

User avatar
DrShark
Power Member
Power Member
Posts: 1548
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: Dark Mode, Copy progress dialog: Pause/Start button becomes light if pressed with keyboard

Post by *DrShark »

ghisler(Author) wrote:
2020-01-30, 11:00 UTC
I have seen that too, but didn't fix it because it goes away when you click OK or Cancel.
Sometimes it doesn't, and it doesn't look nice anyway, so please consider fixing this too.
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right

User avatar
DrShark
Power Member
Power Member
Posts: 1548
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: Dark Mode, Copy progress dialog: Pause/Start button becomes light if pressed with keyboard

Post by *DrShark »

DrShark wrote:
2020-01-30, 09:09 UTC
if after pressing Start/Pause to press Cancel button, the

Code: Select all

---------------------------
Total Commander
---------------------------
User abort!
---------------------------
OK   Cancel   
---------------------------
dialog will appear and Start/Pause button will again become light.
This is fixed in TC 9.50a RC1 (uncredited bugfix).
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39109
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Dark Mode, Copy progress dialog: Pause/Start button becomes light if pressed with keyboard

Post by *ghisler(Author) »

Thanks - I think I sent you an e-mail that I fixed this.
Author of Total Commander
http://www.ghisler.com

Post Reply