[FIXED] compare by content - edit mode still crashes

Bug reports will be moved here when the described bug has been fixed

Moderators: white, sheep, Hacker, Stefan2

Post Reply
miskox
Member
Member
Posts: 137
Joined: 2003-06-11, 06:00 UTC

[FIXED] compare by content - edit mode still crashes

Post by *miskox »

Windows 10 64-bit, TC 10 beta 7 32-bit.

TC still crashes (TC started with no .ini files).

Download test files www.kockarna.si/test-compare-10beta7.zip

In this .zip file there are two .txt files. left.txt (1.842.912 bytes in size) and right.txt (9 bytes in size).

Put them in the same folder and have this folder on the left and right (it might work if you select them in the same pane - I didn't try this).

Select left.txt in in the left pane, right.txt in the right pane.

Select file - compare by content.

CLick Edit mode.

Click in the left pane (larger file): ctrl/a, ctrl/c

Click in the right pane with right click and select Paste here.

And crash... at least here...

Saso
Last edited by miskox on 2021-04-30, 08:49 UTC, edited 1 time in total.
#224551
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 41248
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: compare by content - edit mode still crashes

Post by *ghisler(Author) »

Not confirmed, I do not get any crash, neither with TC 32-bit nor 64-bit. I get quite a long progress for the paste, but no crash.

Could you post the crash message here, please?
Author of Total Commander
http://www.ghisler.com
User avatar
Horst.Epp
Power Member
Power Member
Posts: 4317
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Re: compare by content - edit mode still crashes

Post by *Horst.Epp »

No confirmed
I downloaded the files and did as explained.
After a few seconds the paste was done with no problems or crash.
Tested with x86 and x64 TC
Windows 10 Home x64 Version 21H1 (OS Build 19043.1055)
TC 10.00 x64 / x86
Everything 1.5.0.1264a (x64)
miskox
Member
Member
Posts: 137
Joined: 2003-06-11, 06:00 UTC

Re: compare by content - edit mode still crashes

Post by *miskox »

Hello!

CTRL-C of the dump does not work (as in some previous tests). So here is the screen shot:

https://brickshelf.com/gallery/miskox/tmp/tc_compare_10beta7_crash.jpg

I will make a video later today.

Thanks.
Saso
#224551
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 41248
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: compare by content - edit mode still crashes

Post by *ghisler(Author) »

Could you please copy the crash message with Ctrl+C instead of taking a photo, and then paste it here? This way I wouldn't have to enter all these numbers by hand. Thanks a lot!
Author of Total Commander
http://www.ghisler.com
miskox
Member
Member
Posts: 137
Joined: 2003-06-11, 06:00 UTC

Re: compare by content - edit mode still crashes

Post by *miskox »

As I wrote - CTRL+C didn't work. And after that running commands from the 'TC prompt' doesn't work.
Sorry.

Saso
#224551
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 41248
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: compare by content - edit mode still crashes

Post by *ghisler(Author) »

You are right, when it crashes while the clipboard is open, it's not possible to use Ctrl+C.

I think I found the error, please try with beta 8 when it comes out later today.
Author of Total Commander
http://www.ghisler.com
miskox
Member
Member
Posts: 137
Joined: 2003-06-11, 06:00 UTC

Re: compare by content - edit mode still crashes

Post by *miskox »

It looks like it is working now. I was not able to crash it. Thank you.

Saso
#224551
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 41248
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [FIXED] compare by content - edit mode still crashes

Post by *ghisler(Author) »

I was only able to crash it by pressing Ctrl+A in the target too before pasting. But the fix should also handle all other cases where this happens. The problem was that it tried to paste to a non-existing line (not empty, just not there at all).
Author of Total Commander
http://www.ghisler.com
Post Reply