Auto resize in Overwrite dialogue

[RADiCAL]

When ticking the "Custom fields" checkbox, the window will expand a bit.

Expected: the window should maintain its dimentions at all times.

Reproduction:
1. Copy a file to another dir.
2. After you have copied the file, click F5 to copy it again and press Enter.
3. When the "Overwrite" dialogue will appear, tick the "Custom fields" checkbox and heed the changes in the window (you can take a screenshot before and after to see the difference).

[Flint]

Confirm. But this is reproduced only when Thumbnails is not checked.

[ghisler(Author)]

This is by design. It just looks ugly to have a huge overwrite dialog with almost nothing it. Remember that you can add multiple lines of custom columns!

[Flint]

ghisler(Author)
But why increase the size of the dialog when nothing is added? Look at the screenshots:
Before ticking the "Custom columns"
After ticking the "Custom columns"
After unticking the "Custom columns"
The dialog is increased in height, but there is nothing to be increased for!

[ghisler(Author)]

At least one line is added when tocking "Custom columns".

[icfu]

It also looks ugly to have a dialog autocenter itself after clicking a checkbox, like it happens with "custom columns" and "thumbnails" checkbox.

It is not only annoying, it is also extremely dangerous! I have just seen that when unchecking "thumbnails" the cursor hovers "overwrite" button afterwards.

Please, center only on the first dialog call!

Icfu

[ghisler(Author)]

How would you ensure the visibility of the dialog then?

[icfu]

I would calculate the offset before expanding the dialog:
If offset <0: recenter the dialog.
If offset >= 0 : no need to react.

Icfu

[ghisler(Author)]

It should re-size better now. Please test!

[RADiCAL]

Same behavior on pb4.
Please see Flint's message for screenshots.

[ghisler(Author)]

Sorry, I don't understand your remark.

If i click on the "preview images" checkbox now, the dialog resizes in a way that the buttons and checkbox remain in the same location! What else do you want?

[Flint]

ghisler(Author)
Indeed, in the new beta-versions resising was greatly improved, no need to move the mouse cursor now. Thank you very much!

But in my post above I was talking about slightly different problem. Look:
1. OW dialog appears, "Thumbs" and "Custom fields" are not checked: the dialog height is minimal.
2. I check "Custom fields": OW dialog height is increased one line. (PS: Frankly, I don't understand why this is necessary, but as you told here that it is normal behaviour, I trust you. )
3. I uncheck "Custom fields". I expect that the dialog height is returned back to its minimal value, like in p.1. But look at the screenshot: it still remains 1 line higher than it was in the very beginning.

[RADiCAL]

ghisler(Author)
Indeed, in the new beta-versions resising was greatly improved, no need to move the mouse cursor now. Thank you very much!

But in my post above I was talking about slightly different problem. Look:
1. OW dialog appears, "Thumbs" and "Custom fields" are not checked: the dialog height is minimal.
2. I check "Custom fields": OW dialog height is increased one line. (PS: Frankly, I don't understand why this is necessary, but as you told here that it is normal behaviour, I trust you. )
3. I uncheck "Custom fields". I expect that the dialog height is returned back to its minimal value, like in p.1. But look at the screenshot: it still remains 1 line higher than it was in the very beginning.

10x, Flint.
ghisler, this is exactly what I meant in my original description (sorry for not attaching any screenshot).

This is not a terrible behavior, but I would also expect that the window will return to its original dimensions when unticking the Custom Fields checkbox.

[ghisler(Author)]

I uncheck "Custom fields". I expect that the dialog height is returned back to its minimal value, like in p.1.

I'm trying to resize the dialog as little as possible, so I'm not reducing the size in this special case.