BUG: cm_SrcUserSpec in Menu with Icons

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
Stance
Power Member
Power Member
Posts: 1079
Joined: 2005-03-29, 06:26 UTC

BUG: cm_SrcUserSpec in Menu with Icons

Post by *Stance »

I am using a menu with MenuItems for LEFT (cm_LeftUserSpec) and RIGHT (cm_RightUserSpec).
Want to add a MenuItem "Source":

Code: Select all

POPUP "&Source"
        MENUITEM "*.*", cm_SrcUserSpec
        POPUP "&Filter"
        MENUITEM "Erweiterung unter Cursor anzeigen", em_ExtensionShowOnly
        MENUITEM "Erweiterung unter Cursor ausblenden", em_ExtensionHideOnly
        MENUITEM "Gleichnamige unter Cursor anzeigen", em_ShowOnlySameName
        END_POPUP
END_POPUP
Without "IconsInMenus" in INI all is fine:
The used Filter is shown for active panel (Also in LEFT and RIGHT)!

Error:
IconsInMenus=1
Only "*.*" is shown in Menu / Source.
(But the used filters are shown proper in RIGHT and LEFT).

IconsInMenus=0
IconsInMenus=16
are functional!

Can anybody confirm this ?

Here's a similar Request: [Req] Update menu item text for cm_SrcUserSpec

Stance
User avatar
petermad
Power Member
Power Member
Posts: 14807
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Interesting indeed :!:

Usually the bugs relates to Left and Right commands and seldom to the Src commands, because Src is used in the default menu. But for once it is the opposite :-)

I can only confirm that cm_SrcUserSpec doesn't show up correctly in the menu while cm_LeftUserSpec and cm_RightUserSpec does, when IconsInMenus is enabled :!:
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Stance
Power Member
Power Member
Posts: 1079
Joined: 2005-03-29, 06:26 UTC

Post by *Stance »

Hi petermad!
I can reverse this with: IconsInMenus=0 or 16!
Then the filter is shown for each panel normally.
It's the first time that I'm using a "Source" item in the menu together with Left/Right.

BTW: Thanks for your Extended Menus for TC7! Have just downloaded it!

Kind regards
Stance
User avatar
petermad
Power Member
Power Member
Posts: 14807
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

I can reverse this with: IconsInMenus=0 or 16!
That simply just disables the icons and then the bug doesn't show.

The rule is:
IconsInMenus=1 shows 16x16 icons with checkmarks to the left.
IconsInMenus=2 shows 16x16 icons with button-style border and checkmarks to the left.

Add 4 for 24x24 icons
Add 8 for 32x32 icons
Add 12 for 48x48 icons
Add 16 to show icons in frames and no checkmarks to the left
That means:
IconsInMenus=5 (1+4) shows 24x24 icons with checkmarks to the left
IconsInMenus=6 (2+4) shows 24x24 icons with button-style and checkmarks to the left
IconsInMenus=9 (1+8 ) shows 32x32 icons with checkmarks to the left
IconsInMenus=10 (2+8 ) shows 32x32 icons with button-style and checkmarks to the left
IconsInMenus=13 (1+12) shows 48x48 icons with checkmarks to the left
IconsInMenus=14 (2+12) shows 48x48 icons with button-style and checkmarks to the left
----
IconsInMenus=17 (1+16) shows 16x16 icons in frames and no checkmarks to the left
IconsInMenus=18 (2+16) shows 16x16 icons with button-style and no checkmarks to the left
IconsInMenus=21 (1+4+16) shows 24x24 icons in frames and no checkmarks to the left
IconsInMenus=22 (2+4+16) shows 24x24 icons with button-style and no checkmarks to the left
IconsInMenus=25 (1+8+16) shows 32x32 icons in frames and no checkmarks to the left
IconsInMenus=26 (2+8+16) shows 32x32 icons with button-style and no checkmarks to the left
IconsInMenus=29 (1+12+16) shows 48x48 icons in frames and no checkmarks to the left
IconsInMenus=30 (2+12+16) shows 48x48 icons with button-style and no checkmarks to the left
Currently any other value for IconsInMenus simply disables the icons, that's why 16 disables them :!:
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I will check that, thanks.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14807
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Fixed in TC7b3 - cm_SrcUserSpec now works again :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Post Reply