TC7rc4 - Compare By Content, duplicate line numbers

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
white
Power Member
Power Member
Posts: 4619
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

TC7rc4 - Compare By Content, duplicate line numbers

Post by *white »

During testing at one time I got two lines with the same line number. I know I was deleting a lot of text and undoing it, but I cannot reproduce. I want to report it anyway.

(Edited:
Subject changed.
Old subject: TC7rc3 - Compare By Content, Edit mode, unknown bug
New subject: TC7rc4 - Compare By Content, duplicate line numbers)
Last edited by white on 2007-05-10, 19:27 UTC, edited 2 times in total.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48079
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

What version of TC7 was this?
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4619
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Post by *white »

ghisler(Author) wrote:What version of TC7 was this?
TC7rc3
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48079
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I asked because it looked like the "writing beyond the last line in the shorter file" problem, which should be fixed in RC4.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4619
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Post by *white »

I can now reproduce it using TC7rc4. (I changed the subject of this thread.)

Contents left file

Code: Select all

one
two
three
four
five
six
seven
eight
nine
ten
Contents right file

Code: Select all

one
two
three
four
five
six
seven
eight
nine
ten
eleven
Edit as follows.
(* Compare by content dialog, enter Edit mode)
* Place the cursor at the beginning of line 10 of the left file and hit Enter twice to insert two new lines.
* Move the cursor up two lines to get to the first inserted line.
* Press Delete to delete the first of the inserted lines.
* Go to the right file.
* Place the cursor at the end of the last line (behind "eleven").
* Hit Enter.
Now the tenth line in at the left is duplicated including the line number. See screen shot.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48079
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks, I could reproduce it and fix it now! I found two reasons for the error:
1. When the line was deleted, the last line in the first file was not reset to "empty".
2. When the nw line was added, the line added to the other file wasn't set to "empty" either.

Fixing one of the two fixes the problem, but I will fix of course both.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4619
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Post by *white »

Multiple duplicate line numbers produced using TC7rc4.1c. See screen shot. Look at line number 16 of the left file.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48079
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Can you give me again step by step instructions to create them, please? I guess that it's the same problem as above. I only fixed it tonight, _after_ sending you the new test version...
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4619
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Post by *white »

Although I could reproduce the problem regularly, I was not able to determine exactly which steps to take to get this problem. Probably because the problem was caused by multiple bugs.

I am not able to reproduce it in the last test version you sent me. So I assume this is fixed!
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48079
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

OK, thanks! Please contact me by e-mail if you can reproduce the problem with the latest test version.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4619
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Post by *white »

Fixed in TC7rc5.
Post Reply