[9.50b2] Browse to plugin dialog doesn't suggest current panel

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

[9.50b2] Browse to plugin dialog doesn't suggest current panel

Post by *MVV »

Open Configuration - Plugins, any of Configure buttons, click Add button. Browse dialog should show current panel's location.
But sometimes it shows wrong location. E.g. change folder in right panel, switch to left panel and repeat described steps... Browse dialog suggests location from inactive panel.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [9.50b2] Browse to plugin dialog doesn't suggest current panel

Post by *ghisler(Author) »

It always uses the current directory, which is the one where you last performed some opertation.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14806
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [9.50b2] Browse to plugin dialog doesn't suggest current panel

Post by *petermad »

So it is like this https://www.ghisler.ch/board/viewtopic.php?p=360613#p360613

I also think that here in MVV's example it would be better to use the path from the active panel - the user might not alway remember which folder was opened last or in which folder the last operation was performed - but he can easily see which panel is active.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Hacker
Moderator
Moderator
Posts: 13065
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Re: [9.50b2] Browse to plugin dialog doesn't suggest current panel

Post by *Hacker »

Yeah, I agree, the active directory should always be the current directory. Is there any situation in which that is not intuitive or does not make sense?

Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Re: [9.50b2] Browse to plugin dialog doesn't suggest current panel

Post by *MVV »

I don't think that one would expect that after switching panel current directory will be the same. Especially since buttonbar buttons always use current panel's dir as starting directory, not the one where last operation performed.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [9.50b2] Browse to plugin dialog doesn't suggest current panel

Post by *ghisler(Author) »

The problem is that I cannot constantly change the current directory, this would cause many problems and slowdowns.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14806
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [9.50b2] Browse to plugin dialog doesn't suggest current panel

Post by *petermad »

The problem is that I cannot constantly change the current directory
Just don't use current directory in functions that like those, alway use direrctory in active panel.

So far I can see that it is for theese functions:
Configuration:
Edit/View - Editor for F4
FTP - Create log file
Plugins - Add (File system plugins, Lister plugins, Content plugins)
Ignore list - Save in:
Packer - 5 instances
Zip packer - 2 instances

Associate:
New type
Edit type - Open / New - Command (program)

Internal associations:
Add - Edit file type - Open / New - Command (program)
Edit - Open / New - Command (program)

Lister:
Configure - Multimedia - Use IrfanView... - Path:

SAVETABS
SAVETABSL
SAVETABSR
SAVETABS2
SAVETABS2L
SAVETABS2R
SAVESELECTION
SAVEDETAILS


That is max 27 places (maybe fewer, some of these probably use the same function)- that is feasible. I might of course have overlooked some situations.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Re: [9.50b2] Browse to plugin dialog doesn't suggest current panel

Post by *MVV »

ghisler(Author),
You only need to add changing directory before displaying dialog, it is a user action so he won't notice any slowdown here.
User avatar
petermad
Power Member
Power Member
Posts: 14806
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [9.50b2] Browse to plugin dialog doesn't suggest current panel

Post by *petermad »

MVV wrote: 2019-10-26, 19:34 UTC ghisler(Author),
You only need to add changing directory before displaying dialog, it is a user action so he won't notice any slowdown here.
Exactly :wink:
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [9.50b2] Browse to plugin dialog doesn't suggest current panel

Post by *ghisler(Author) »

That's what I will do - but there are probably other such dialogs with the same problem...
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14806
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [9.50b2] Browse to plugin dialog doesn't suggest current panel

Post by *petermad »

Confirmed fixed in TC9.5b3 for:
Configuration - Plugins - Add (File system plugins, Lister plugins, Content plugins)
SAVESELECTION
SAVESELECTIONA
SAVESELECTIONW
SAVEDETAILS
SAVEDETAILSA
SAVEDETAILSw
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Re: [9.50b2] Browse to plugin dialog doesn't suggest current panel

Post by *MVV »

I can confirm that WLX, WFX and WDX plugins are now searched in current panel, but WCX plugins are still searched in wrong panel!
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [9.50b2] Browse to plugin dialog doesn't suggest current panel

Post by *ghisler(Author) »

WCX uses the file associate dialog, not the plugin dialog used for the other plugin types.
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Re: [9.50b2] Browse to plugin dialog doesn't suggest current panel

Post by *MVV »

Yes, but the problem is the same: it hasn't too much sense to open last changed directory in this dialog, it is better to open current directory of active panel there.
User avatar
petermad
Power Member
Power Member
Posts: 14806
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [9.50b2] Browse to plugin dialog doesn't suggest current panel

Post by *petermad »

WCX plugins are still searched in wrong panel!
I can confirm that the last opened directory and not the directory in the active panel is used when the "New type" button is pressed.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Post Reply