[solved] TC 9.5b4 x64 - Cannot show menu icons and checkmarks at the same time anymore

Bug reports will be moved here when the described bug has been fixed

Moderators: sheep, Hacker, Stefan2, white

Post Reply
User avatar
petermad
Power Member
Power Member
Posts: 8998
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

[solved] TC 9.5b4 x64 - Cannot show menu icons and checkmarks at the same time anymore

Post by *petermad » 2019-11-06, 22:03 UTC

TC 9.5b4 cannot show menu icons and checkmarks in the main menu at the same time anymore
This only affects the 64 bit version of TC 9.5b4

To reproduce:
In the "Options"-> "Icons" dialog:
Enable "Show icons for commands in the main menu"
Disable "Show checked items as pressed buttons instead of checkmarks"

Insert this code in the main menu and reload the main menu:

Code: Select all

  POPUP "&Display"
    MENUITEM "Show &Hidden Files", 3013
    MENUITEM "Show &System Files", 3014
    MENUITEM "Show &Long Filenames", 2010
    MENUITEM "Show Old &8.3 Filenames", 2013
    MENUITEM "Show &Overlay Icons", 2917
    MENUITEM "Always Sort Directories by N&ame", 2012
    MENUITEM "&Dark Mode", 2950
    MENUITEM "Auto S&witch Mode", 2947
  END_POPUP
Open the submenu "Display" - no checkmarks are shown. see https://madsenworld.dk/tcmd/iconsnocheckmarks.png

Delete these 2 lines (which have icons) and reload the main menu:

Code: Select all

    MENUITEM "Show &Hidden Files", 3013
    MENUITEM "Show &System Files", 3014
Open the Display submenu again - now the checkmarks are visible. see https://madsenworld.dk/tcmd/noiconscheckmarks.png
Last edited by petermad on 2019-11-13, 22:50 UTC, edited 1 time in total.
License #524 (1994)
Danish Total Commander Translator
TC 9.5b8 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.935 (x64)
TC 3.0b12 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

Slavic
Member
Member
Posts: 144
Joined: 2006-02-26, 15:41 UTC
Location: Moscow, Russia

Re: TC 9.5b4 x64 - Cannot show menu icons and checkmarks at the same time anymore

Post by *Slavic » 2019-11-06, 23:03 UTC

It can be seen more easily by only disabling the option "Show checked items as pressed buttons...", then look at the "Show" panel in main menu.

In previous TC versions this menu had two columns on the left: the leftmost column for marks (bold dot in my OS) and then a column for icons. Now the marks disappear with its column. As a result, when the aforementioned option is disabled and active icons are the same, there is no way to see which menu options are active and which are not.
Desktop: Windows 8.1 x64, TC 9.50b9. Mobile: Pixel 3, Android 10, TC 3.0b12

User avatar
petermad
Power Member
Power Member
Posts: 8998
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC 9.5b4 x64 - Cannot show menu icons and checkmarks at the same time anymore

Post by *petermad » 2019-11-07, 01:51 UTC

I made another observation. If I add this line:

Code: Select all

    MENUITEM "Show Hidden Files (FT&P)", 553
to any menu where the checkmarks are not shown, then this line will fix that - weird indeed!

Also this menu shows no checkmarks:
Spoiler
Show

Code: Select all

POPUP "&View"
  MENUITEM "&Brief View\tCtrl+F1", 301
  MENUITEM "&Full View\tCtrl+F2", 302
  MENUITEM "T&humbnail View\tShift+Ctrl+F1", 269
  MENUITEM "F&ile Comments\tShift+Ctrl+F2", 300
  MENUITEM SEPARATOR
  MENUITEM "Cust&om Columns\tShift+F1", 270
  MENUITEM "    Previous", 5502
  MENUITEM "    Next", 5501
  MENUITEM "Custom View Modes", 333
  MENUITEM "    Auto Switch Mode", 2947
  MENUITEM SEPARATOR
  MENUITEM "&Tree View\tCtrl+F8", 303
  POPUP "S&eparate Tree View"
    MENUITEM "&0 (None)", 3200
    MENUITEM "&1 (One for Both Panels)", 3201
    MENUITEM "&2 (One for Each Panel)", 3202
    MENUITEM "&Next\tShift+Ctrl+F8", 3203
    MENUITEM SEPARATOR
    MENUITEM "&One Tree View On/Off", 3204
    MENUITEM "&Two Tree Views On/Off", 3205
  END_POPUP
  MENUITEM "    Next\tShift+Ctrl+F8", 3203
  MENUITEM SEPARATOR
  MENUITEM "&Quick View\tCtrl+Q", 304
  MENUITEM "Quick View (Without Plu&gins)", 306
  MENUITEM "Quick View in Separate Window\tShift+Ctrl+Q", 2941
  MENUITEM "Quick View in Separate Window (Without Plugins)", 2942
  MENUITEM SEPARATOR
  MENUITEM "Branch Vie&w\tCtrl+B", 2026
  MENUITEM "Branch View (Only Selected)\tShift+Ctrl+B", 2046
  MENUITEM SEPARATOR
  MENUITEM "&Vertical Alignment", 305
  MENUITEM SEPARATOR
  MENUITEM "Sort by &Name\tCtrl+F3", 321
  MENUITEM "Sort by E&xtension\tCtrl+F4", 322
  MENUITEM "Sort by Ti&me\tCtrl+F5", 324
  MENUITEM "Sort by &Size\tCtrl+F6", 323
  MENUITEM "&Unsorted\tCtrl+F7", 325
  MENUITEM "&Reverse Order", 330
  POPUP "Sort b&y Column"
    MENUITEM "Sort by &3rd Column", 6003
    MENUITEM "Sort by &4th Column", 6004
    MENUITEM "Sort by &5th Column", 6005
    MENUITEM "Sort by &6th Column", 6006
    MENUITEM "Sort by &7th Column", 6007
    MENUITEM "Sort by &8th Column", 6008
    MENUITEM "Sort by &9th Column", 6009
  END_POPUP
  MENUITEM SEPARATOR
  MENUITEM "&All Files\tCtrl+F10", 312
  MENUITEM "&Programs\tCtrl+F11", 311
  MENUITEM "&Custom...\tCtrl+F12", 314
  MENUITEM "*.*", 313
  MENUITEM "Only Se&lected Files", 2023
  MENUITEM SEPARATOR
  MENUITEM "Select &Drive\tAlt+F1 / F2", 331
END_POPUP
Whereas this does show chekmarks
Spoiler
Show

Code: Select all

POPUP "&Left"
  MENUITEM "&Brief View\tCtrl+F1", 101
  MENUITEM "&Full View\tCtrl+F2", 102
  MENUITEM "T&humbnail View\tShift+Ctrl+F1", 69
  MENUITEM "F&ile Comments\tShift+Ctrl+F2", 100
  MENUITEM SEPARATOR
  MENUITEM "Cust&om Columns\tShift+F1", 70
  MENUITEM "    Previous", 5506
  MENUITEM "    Next", 5505
  MENUITEM "Custom View Modes", 133
  MENUITEM "    Auto Switch Mode", 2947
  MENUITEM SEPARATOR
  MENUITEM "&Tree View\tCtrl+F8", 103
  POPUP "S&eparate Tree View"
    MENUITEM "&0 (None)", 3200
    MENUITEM "&1 (One for Both Panels)", 3201
    MENUITEM "&2 (One for Each Panel)", 3202
    MENUITEM "&Next\tShift+Ctrl+F8", 3203
    MENUITEM SEPARATOR
    MENUITEM "&One Tree View On/Off", 3204
    MENUITEM "&Two Tree Views On/Off", 3205
  END_POPUP
  MENUITEM "    Next\tShift+Ctrl+F8", 3203
  MENUITEM SEPARATOR
  MENUITEM "&Quick View\tCtrl+Q", 204
  MENUITEM "Quick View (Without Plu&gins)", 206
  MENUITEM "Quick View in Separate Window\tShift+Ctrl+Q", 2941
  MENUITEM "Quick View in Separate Window (Without Plugins)", 2942
  MENUITEM SEPARATOR
  MENUITEM "Branch Vie&w\tCtrl+B", 2034
  MENUITEM "Branch View (On&ly Selected)\tShift+Ctrl+B", 2047
  MENUITEM SEPARATOR
  MENUITEM "&Vertical Alignment", 305
  MENUITEM SEPARATOR
  MENUITEM "Sort by &Name\tCtrl+F3", 121
  MENUITEM "Sort by E&xtension\tCtrl+F4", 122
  MENUITEM "Sort by Ti&me\tCtrl+F5", 124
  MENUITEM "Sort by &Size\tCtrl+F6", 123
  MENUITEM "&Unsorted\tCtrl+F7", 125
  MENUITEM "&Reverse Order", 130
  POPUP "Sort b&y Column"
    MENUITEM "Sort by &3rd Column", 6203
    MENUITEM "Sort by &4th Column", 6204
    MENUITEM "Sort by &5th Column", 6205
    MENUITEM "Sort by &6th Column", 6206
    MENUITEM "Sort by &7th Column", 6207
    MENUITEM "Sort by &8th Column", 6208
    MENUITEM "Sort by &9th Column", 6209
  END_POPUP
  MENUITEM SEPARATOR
  MENUITEM "&All Files\tCtrl+F10", 112
  MENUITEM "&Programs\tCtrl+F11", 111
  MENUITEM "&Custom...\tCtrl+F12", 114
  MENUITEM "*.*", 113
  MENUITEM SEPARATOR
  MENUITEM "Select &Drive\tAlt+F1", 131
END_POPUP
License #524 (1994)
Danish Total Commander Translator
TC 9.5b8 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.935 (x64)
TC 3.0b12 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38451
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b4 x64 - Cannot show menu icons and checkmarks at the same time anymore

Post by *ghisler(Author) » 2019-11-07, 10:24 UTC

It's probably caused by dark mode changes - I will check it.
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 8998
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC 9.5b4 x64 - Cannot show menu icons and checkmarks at the same time anymore

Post by *petermad » 2019-11-07, 12:58 UTC

Just to make it clear - I see the bug in both Dark and Normal mode.
License #524 (1994)
Danish Total Commander Translator
TC 9.5b8 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.935 (x64)
TC 3.0b12 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
petermad
Power Member
Power Member
Posts: 8998
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC 9.5b4 x64 - Cannot show menu icons and checkmarks at the same time anymore

Post by *petermad » 2019-11-13, 22:50 UTC

Confirmed fixed in TC 9.5b5 :-)
License #524 (1994)
Danish Total Commander Translator
TC 9.5b8 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.935 (x64)
TC 3.0b12 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

Post Reply