TC 9.5b7 - USB on buttonbar doesn't get pressed

Bug reports will be moved here when the described bug has been fixed

Moderators: sheep, Hacker, Stefan2, white

User avatar
MaxX
Power Member
Power Member
Posts: 700
Joined: 2012-03-23, 18:15 UTC
Location: Earth

TC 9.5b7 - USB on buttonbar doesn't get pressed

Post by *MaxX »

TC 9.5 beta 7 x32 on Win 7 SP1 x32

By step:
1. Start TC, press any drive button. Let it be C:
https://jpegshare.net/images/47/8b/478b17f1137299341a55864685917b79.png
2. Connect any Android device and press new "u1" button
https://jpegshare.net/images/cf/92/cf9253e4d6ab8a991ce7a27f9a8d5644.png
3. TC goes to the path we need ++ button does not remain pressed ++ TC shows pressed "\" instead of "u1"
https://jpegshare.net/images/5f/62/5f620cff89a2901a1083967e74664d24.png
4. Now press "u1" again ++ "u1" is pressed
https://jpegshare.net/images/d7/70/d7704c83b6d271d561d459a2bfbc8d11.png
5. Now go to any folder on device ++ TC shows pressed "\" instead of "u1" (again)
User avatar
petermad
Power Member
Power Member
Posts: 9802
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC 9.5b7 - USB on buttonbar doesn't get pressed

Post by *petermad »

Confirmed on Windows 7 and windows 10, both with and without flat drive bar icons.
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.988 (x64)
TC 3.10b8 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39920
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b7 - USB on buttonbar doesn't get pressed

Post by *ghisler(Author) »

This is normal, the same has happened for years when you chose the phone in Alt+F1 or Alt+F2. Then the network was also selected in Alt+F1. The reason is that there is no way to find out whether a subdirectory is on the phone or some other virtual folder. That's also why you don't get a full path shown in the panel title.
Author of Total Commander
http://www.ghisler.com
User avatar
Usher
Power Member
Power Member
Posts: 883
Joined: 2011-03-11, 10:11 UTC

Re: TC 9.5b7 - USB on buttonbar doesn't get pressed

Post by *Usher »

Buttons for USB grab and display properties for U:\ drive letter, if it's available in the system.
Regards from Poland
Andrzej P. Wozniak
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39920
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b7 - USB on buttonbar doesn't get pressed

Post by *ghisler(Author) »

Buttons for USB grab and display properties for U:\ drive letter, if it's available in the system.
Sorry, I don't understand what you mean. I have created drive letter u: with command
subst u: c:\totalcmd
for test purposes. The button "u1" still has its own icon, and it opens the USB device when clicked on, not drive u:.
Can you describe what's wrong?
Author of Total Commander
http://www.ghisler.com
User avatar
Usher
Power Member
Power Member
Posts: 883
Joined: 2011-03-11, 10:11 UTC

Re: TC 9.5b7 - USB on buttonbar doesn't get pressed

Post by *Usher »

2ghisler(Author)
I have letter U assigned to virtual DVD drive. When I right click u1 button, it shows u:\ as the first context menu item, and when I select this item it opens ISO image mounted in virtual DVD. The same is happening for real optical drive and for HDD partition with letter U assigned.

Did you do any tests with any drive assigned to letter U: partition on local HDD, network drive, optical drive, virtual drive?
Regards from Poland
Andrzej P. Wozniak
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39920
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b7 - USB on buttonbar doesn't get pressed

Post by *ghisler(Author) »

When I right click u1 button
Ah, thanks, I didn't try the right click menu! Please try with beta 8.
Author of Total Commander
http://www.ghisler.com
User avatar
Usher
Power Member
Power Member
Posts: 883
Joined: 2011-03-11, 10:11 UTC

Re: TC 9.5b7 - USB on buttonbar doesn't get pressed

Post by *Usher »

Confirm U letter fixed in TC9.5b8.
Regards from Poland
Andrzej P. Wozniak
User avatar
MVV
Power Member
Power Member
Posts: 8535
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Re: TC 9.5b7 - USB on buttonbar doesn't get pressed

Post by *MVV »

When I open a phone folder properties in Explorer, it shows folder location as a full path to parent folder, e.g. "Компьютер\My Phone\Phone\WhatsApp\Media\WhatsApp Voice Notes". Does TC have access to such information? It would be nice to be able to show such paths in path bar, or even be able to jump to a phone folder by such full path, and also such path would allow to detect device owning the folder.
Last edited by MVV on 2019-12-17, 07:34 UTC, edited 1 time in total.
User avatar
Usher
Power Member
Power Member
Posts: 883
Joined: 2011-03-11, 10:11 UTC

Re: TC 9.5b7 - USB on buttonbar doesn't get pressed

Post by *Usher »

2MVV
Wrong topic…
Regards from Poland
Andrzej P. Wozniak
User avatar
MVV
Power Member
Power Member
Posts: 8535
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Re: TC 9.5b7 - USB on buttonbar doesn't get pressed

Post by *MVV »

Usher,
No, the topic is correct. As Christian said, he can't find out whether a subdirectory is on the phone or some other virtual folder. But I see that Explorer somehow remembers or gets it from folder. Perhaps TC can also use such a way.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39920
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b7 - USB on buttonbar doesn't get pressed

Post by *ghisler(Author) »

For network paths, I can call GetDisplayNameOf with parameter "SHGDN_FORPARSING" to get the full path.

However, for phones it returns something unreadable:
::{20D04FE0-3AEA-1069-A2D8-08002B30309D}\\\?\usb#vid_04e8&pid_6860&ms_comp_mtp&samsung_android#8&408428d&0&0000#{6ac27878-a6fa-4155-ba85-f98f491d4f33}\SID-{10001,SECZ9519043CHOHB,118031462400}\{CF281901-668F-AC51-CD52-3F6EBB2351DA}

I couldn't find a way to convert this to a user-readable path. I then call the function with parameter "SHGDN_NORMAL", but it only gives the name of the folder itself.
Author of Total Commander
http://www.ghisler.com
User avatar
MaxX
Power Member
Power Member
Posts: 700
Joined: 2012-03-23, 18:15 UTC
Location: Earth

Re: TC 9.5b7 - USB on buttonbar doesn't get pressed

Post by *MaxX »

Is it possible to cache and remember folders' names for each guid and convert them into readable look?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39920
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b7 - USB on buttonbar doesn't get pressed

Post by *ghisler(Author) »

There is no standard what format GetDisplayNameOf returns, so it may differ between Windows versions and even device types.

The only way would be to call GetDisplayNameOf for each parent directory and then construct a path from that, but this could be very slow when in a deep subdirectory. Caching is problematic too because the user could rename folders on the phone while it is connected to the PC.
Author of Total Commander
http://www.ghisler.com
User avatar
MaxX
Power Member
Power Member
Posts: 700
Joined: 2012-03-23, 18:15 UTC
Location: Earth

Re: TC 9.5b7 - USB on buttonbar doesn't get pressed

Post by *MaxX »

Could you try adding such a feature until beta testing is still in progress?
I think, there are different ways for it:
1. Any parameter in wincmd.ini (would be enough to enable this manually). Or dedicated section with device-IDs with =0 and =1 for enable/disable caching.
2. Any cm_<command> to execute in active panel on needed device opened. This does not need any additional config, does not need to be saved, affects only chosen device-ID until TC is closed or cm_<command> run once more.
That should be safe enough to prevent unwanted problems.
Post Reply