[TC 9.50b9, Win7+XP] cm_SwitchDarkmode: menu bar stays dark

Bug reports will be moved here when the described bug has been fixed

Moderators: sheep, Hacker, Stefan2, white

Post Reply
StatusQuo
Power Member
Power Member
Posts: 1524
Joined: 2007-01-17, 21:36 UTC
Location: Germany

[TC 9.50b9, Win7+XP] cm_SwitchDarkmode: menu bar stays dark

Post by *StatusQuo »

(Only on systems older than Windows 8/10):

cm_SwitchDarkmode leaves the menu bar background:
- permanently in dark mode (TC 32bit) or
- temporarily + partially in dark mode (64bit),
with WINCMD.INI: IconsInMenus=0 (no icons in menu)

To reproduce:
WINCMD.INI:

Code: Select all

[Configuration]
IconsInMenus=0
Using cm_SwitchDarkmode twice switch dark mode on and off again
via TC command line (or call it via button or starter menu, makes no difference).

Result after switching back to normal mode:
TC 32bit:
- font color switches to black, but background stays dark grey (content unreadable)
- no change after switching to another program window and back => TC restart needed to restore normal mode
TC 64bit:
- used area of menu bar (containing menu items) looks normal, space between "Start" and "Help" stays dark
- switching to another program window and back solves the issue (missing redraw?)

Tested Windows versions:

Code: Select all

XP    x86      : bug like described
Win7  x86 + x64: bug like described
Win8  x86      : OK, no problem (TC 32bit - could not test 64bit, no test environment)
Win10 x86 + x64: OK, no problem (both TC 32bit and 64bit)
(Win2k         : OK, dark mode not supported, cm_SwitchDarkmode does nothing)
edit:
Summary of conditions to reproduce so far:
- Windows 7 or Windows XP
- Windows Classic theme for Win7 (?) (for XP theme doesn't matter)
- TC internal English language setting
- TC IconsInMenus=0
- TC XPthemeBg=0 (?)
Last edited by StatusQuo on 2019-12-14, 23:01 UTC, edited 1 time in total.
Who the hell is General Failure, and why is he reading my disk?
-- TC starter menu: Fast yet descriptive command access!
User avatar
petermad
Power Member
Power Member
Posts: 9802
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [TC 9.50b9, Win7+XP] cm_SwitchDarkmode: menu bar stays dark

Post by *petermad »

I can only partly confirm this.

In Windows 7 and 8.1 with 64bit TC 9.5b9 the menu bar stays black all the way from left to right. If I hover the cursor over the menu items, they get their normal background, except for the area between Start and Help.
I can only reproduce this if I use the internal English language setting.
If I use an external language/menu file (for example wcmd_deu.lng / wcmd_deu.mnu) I can not reproduce the bug.
I can also only reproduce this, when XPthemeBg=0 and as you write with IconsInMenus=0.

In Windows 7 and 8.1 with 32bit TC 9.5b9 I can not reproduce it.

In Window XP with 32bit TC 9.5b9 I can reproduce the behaviour as described, and the setting of XPthemeBg=0 has no influence.

In Windows 10 1909 with 32bit and 64bit TC 9.5b9 I see no problems

I am using Aero theme in Windows 7 and Luna theme in Windows XP
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.988 (x64)
TC 3.10b8 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
StatusQuo
Power Member
Power Member
Posts: 1524
Joined: 2007-01-17, 21:36 UTC
Location: Germany

Re: [TC 9.50b9, Win7+XP] cm_SwitchDarkmode: menu bar stays dark

Post by *StatusQuo »

Summary of conditions to reproduce so far: (also added to initial post)
- Windows 7 or Windows XP
- Windows Classic theme for Win7 (?) (for XP theme doesn't matter)
- TC internal English language setting
- TC IconsInMenus=0
- TC XPthemeBg=0 (?)
petermad wrote:
2019-12-14, 20:23 UTC
I can only reproduce this if I use the internal English language setting.
Confirmed - using an external language file "fixes" the bug here, too. ;)
petermad wrote:
2019-12-14, 20:23 UTC
I can also only reproduce this, when XPthemeBg=0 and as you write with IconsInMenus=0.
Hm, "XPthemeBg" doesn't seem to make a difference here.

BTW, in help file this switch seems undocumented? Only found it in TC's Configuration UI.
petermad wrote:
2019-12-14, 20:23 UTC
I am using Aero theme in Windows 7 and Luna theme in Windows XP
Indeed, Windows theme seems to be important/make a difference:
- In Win7 x64 I get the bug in Classic theme - in Aero theme it works OK
- In Windows XP theming doesn't seem to matter
Who the hell is General Failure, and why is he reading my disk?
-- TC starter menu: Fast yet descriptive command access!
User avatar
DrShark
Power Member
Power Member
Posts: 1619
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: [TC 9.50b9, Win7+XP] cm_SwitchDarkmode: menu bar stays dark

Post by *DrShark »

I tried on Vista 32-bit with classic theme, and can confirm the issue with TC internal English language setting and IconsInMenus=0.

[off-top]
2StatusQuo
Can you check on Windows x64 the bugfix (TC 9.5 b6 and newer) for one bug you reported?
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39920
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 9.50b9, Win7+XP] cm_SwitchDarkmode: menu bar stays dark

Post by *ghisler(Author) »

Confirmed with classic theme and English menu without icons, thanks.
Author of Total Commander
http://www.ghisler.com
StatusQuo
Power Member
Power Member
Posts: 1524
Joined: 2007-01-17, 21:36 UTC
Location: Germany

Re: [TC 9.50b9, Win7+XP] cm_SwitchDarkmode: menu bar stays dark

Post by *StatusQuo »

Fixed in TC 7.50b10.
DrShark wrote:
2019-12-16, 10:23 UTC
2StatusQuo
Can you check on Windows x64 the bugfix (TC 9.5 b6 and newer) for one bug you reported?
Done, seems fixed, too.
Who the hell is General Failure, and why is he reading my disk?
-- TC starter menu: Fast yet descriptive command access!
User avatar
DrShark
Power Member
Power Member
Posts: 1619
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: [TC 9.50b9, Win7+XP] cm_SwitchDarkmode: menu bar stays dark

Post by *DrShark »

history950.txt wrote:16.12.19 Fixed: Classic theme: Turning off dark mode kept dark background in main menu when using internal English menu without icons (32/64)
I also can confirm this fix in TC 9.50 beta 10 on Vista 32-bit with classic theme.
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
petermad
Power Member
Power Member
Posts: 9802
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [TC 9.50b9, Win7+XP] cm_SwitchDarkmode: menu bar stays dark

Post by *petermad »

Confirmed fixed in 64bit TC 9.5b10 under Windows 7 and 8.1 and in 32bit TC 9.5b10 under Windows XP :-)


16.12.19 Fixed: Classic theme: Turning off dark mode kept dark background in main menu when using internal English menu without icons (32/64)
For me the bug wasn't seen with Classic theme, but with Luna theme in windows XP and Aero Theme in Windows 7, and Standard theme in Windows 8.1 - so maybe the history should be changed to:
16.12.19 Fixed: Turning off dark mode kept dark background in main menu when using internal English menu without icons (32/64)
Last edited by petermad on 2019-12-19, 18:20 UTC, edited 1 time in total.
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.988 (x64)
TC 3.10b8 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39920
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 9.50b9, Win7+XP] cm_SwitchDarkmode: menu bar stays dark

Post by *ghisler(Author) »

I will change the history, thanks. I was only able to reproduce it with classic theme here, so that's why I put that in the history.
Author of Total Commander
http://www.ghisler.com
Post Reply