Dark Mode: white text of some menus with light Windows 10 theme

Bug reports will be moved here when the described bug has been fixed

Moderators: sheep, Hacker, Stefan2, white

Post Reply
User avatar
DrShark
Power Member
Power Member
Posts: 1628
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Dark Mode: white text of some menus with light Windows 10 theme

Post by *DrShark »

To reproduce:
1. Make sure Windows 10 theme DOES NOT use dark mode.
2. Start TC with default ini, switch it to dark mode (e.g. with cm_switchdarkmode).
3. Restart TC.
4. Open some menus like file context menu, button bar context menu, directory hotlist or history:
they will use light theme, but also with white text.

Note: scrollbars will also be light, it seems in this case TC doesn't apply dark theme to scrollbars in a way as it does on older Windows versions where dark mode is not implemented in system itself.

Reproduced on Total Commander 9.50 beta 11 x32 and x64, Windows 10 1903 (18362.535).
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
petermad
Power Member
Power Member
Posts: 9898
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: Dark Mode: white text of some menus with light Windows 10 theme

Post by *petermad »

I cannot reproduce this on Windows 10 1909 in neither 32bit nor 64bit TC 9.5b11

But notice that I use Windows 10 1909 not 1903 as DrShark
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.992 (x64)
TC 3.11 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 40066
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Dark Mode: white text of some menus with light Windows 10 theme

Post by *ghisler(Author) »

Not confirmed so far, but I'm also on 1909...
Author of Total Commander
http://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1628
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: Dark Mode: white text of some menus with light Windows 10 theme

Post by *DrShark »

Christian Ghisler reproduced the problem with my theme file. From email:
Christian Ghisler wrote:I [...] found out that [in this case] the problem seems to be a missing or invalid theme: "Darkmode_Explorer".

Total Commander sets this theme with SetWindowTheme to the listboxes, scrollbars etc.

In the 32-bit version, I have now added code where I create a hidden window, call SetWindowTheme on it, and then draw a scrollbar background in memory using this theme. If the drawn part is dark, then "Darkmode_Explorer" is present
and work, and if not, I switch to the emulated dark mode.

Currently this is only in the 32-bit version, but I will also move it to 64-bit if it works well. You cannot override this option with ForceDarkModeOptions=1.
history950.txt wrote:15.01.20 Fixed: Use simulated dark mode also on Windows 10 1809 and later if scrollbars with theme "DarkMode_Explorer" aren't dark, otherwise we will sometimes get white on white context menus (32)
I tried 32-bit TC 9.50 beta 13, and simulated dark mode works on my problem Windows 10 1903 as expected: scrollbars/spinbars are dark, context menus are light with black text.

Looking forward for next beta to try 64-bit Total Commander.
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
DrShark
Power Member
Power Member
Posts: 1628
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: Dark Mode: white text of some menus with light Windows 10 theme

Post by *DrShark »

In 9.50 RC1, 64-bit TC now seems to also use emulated dark mode with ForceDarkModeoptions=1 on that W10 machine, but I only tested it briefly because of that notebook's hardware damage (details in my other post).
So for now problem may be considered as resolved.

I'll post here again if something will be wrong with it later after/if notebook will be repaired.
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 40066
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Dark Mode: white text of some menus with light Windows 10 theme

Post by *ghisler(Author) »

Great, thanks!
Author of Total Commander
http://www.ghisler.com
Post Reply