[solved] TC 9.5b12 ForceDarkModeOptions=0 now disables Dark mode in all Windows versions

Bug reports will be moved here when the described bug has been fixed

Moderators: sheep, Hacker, Stefan2, white

Post Reply
User avatar
petermad
Power Member
Power Member
Posts: 9360
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

[solved] TC 9.5b12 ForceDarkModeOptions=0 now disables Dark mode in all Windows versions

Post by *petermad »

Help TC 9.5b12
ForceDarkModeOptions= 1:Enable dark mode options on older Windows versions
2:Handle all dark mode functions internally, except for title bar
3:also no dark title bar
Help TC 9.5b11
ForceDarkModeOptions=0 Enable dark mode options on older Windows versions
History.txt:
29.10.19 Added: Dark mode: Enable dark mode options by default also on Windows XP and newer (32/64)
Before TC 9.5b12 ForceDarkModeOptions=0 only had an effect for for Windows versions before XP, but since beta12 with the adding of ForceDarkModeOptions=2 and 3, now ForceDarkModeOptions=0 disables Darkmode for all versions of Windows (even Windows 10 - is that really intentional?

EDIT:
If it is intentional, I suggest that the Help is changed to:
ForceDarkModeOptions=1 Enable dark mode options on all Windows versions
0: Disable dark mode options for all Windows versions
2: Handle all dark mode functions internally on Windows 10, except for title bar
3: Also no dark title bar
Last edited by petermad on 2020-01-17, 03:28 UTC, edited 1 time in total.
License #524 (1994)
Danish Total Commander Translator
TC 9.5b10 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.960 (x64)
TC 3.0b16 on Android 6.0
Get: Extended Total Commander Menus | TC Languagebar | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39100
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b12 ForceDarkModeOptions=0 now disables Dark mode in all Windows versions

Post by *ghisler(Author) »

Yes, it's intentional, e.g. for the case where a company wants to block dark mode.
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 9360
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC 9.5b12 ForceDarkModeOptions=0 now disables Dark mode in all Windows versions

Post by *petermad »

OK, then I suggest to use my proposal for a change to the Help.
License #524 (1994)
Danish Total Commander Translator
TC 9.5b10 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.960 (x64)
TC 3.0b16 on Android 6.0
Get: Extended Total Commander Menus | TC Languagebar | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39100
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b12 ForceDarkModeOptions=0 now disables Dark mode in all Windows versions

Post by *ghisler(Author) »

I have already changed it in the meantime, thanks.
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 9360
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC 9.5b12 ForceDarkModeOptions=0 now disables Dark mode in all Windows versions

Post by *petermad »

Maybe the name should be changed to DarkModeOptions - the "Force" could be confusing for people who hasn't been beta testing.
License #524 (1994)
Danish Total Commander Translator
TC 9.5b10 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.960 (x64)
TC 3.0b16 on Android 6.0
Get: Extended Total Commander Menus | TC Languagebar | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39100
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b12 ForceDarkModeOptions=0 now disables Dark mode in all Windows versions

Post by *ghisler(Author) »

I prefer not to change it at this time. "Force" isn't wrong because it forces dark mode options which are otherwise determined automatically.
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 9360
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC 9.5b12 ForceDarkModeOptions=0 now disables Dark mode in all Windows versions

Post by *petermad »

Help:
ForceDarkModeOptions= 1:Enable dark mode options on older Windows versions
2:Handle all dark mode functions internally, except for title bar
3:Also no dark title bar
0:Disable
Considered fixed in TC 9.5b13 with this chnage in the help fole :-)
License #524 (1994)
Danish Total Commander Translator
TC 9.5b10 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 (1909) 64bit, 'Everything' 1.4.1.960 (x64)
TC 3.0b16 on Android 6.0
Get: Extended Total Commander Menus | TC Languagebar | PHSM-Calendar

Post Reply