Here are a few scenarios I could think of:
1. The command is at the top of a popup, followed by a separator:
Code: Select all
POPUP "Some settings"
MENUITEM "Dark<->Normal", 2950
MENUITEM SEPARATOR
...
2. The command is at the bottom of a popup, after a separator:
Code: Select all
...
MENUITEM SEPARATOR
MENUITEM "Dark<->Normal", 2950
END_POPUP
3. The command is between two separators:
Code: Select all
…
MENUITEM SEPARATOR
MENUITEM "Dark<->Normal", 2950
MENUITEM SEPARATOR
...
4. A popup menu is comprised exclusively of the dark mode commands:
Code: Select all
POPUP "Control the Dark Side"
MENUITEM "Switch Your Side", 2950
MENUITEM "Become Sith", 2951
MENUITEM "Become Jedi", 2952
END_POPUP
I understand that a normal user won't enable and disable dark mode on a whim, he/she can choose once, whether to have this option or not, and adjust the menu accordingly. Unfortunately, this approach does not work for distributable custom menus included in third-party localization packages.
I'm not sure what's best to do here. The first 3 issues could be fixed within TC by identifying those layouts and removing the excess separator. As for the 4th scenario I have absolutely no clue as to what is best. Maybe show it as the disabled menu entry, while keeping the popup triangle marker at the right? (So it would still look like a popup, but it won't be able to expand.)