(Solved) [10b1a] Compare files, direct line comparison area: no scrolling

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

(Solved) [10b1a] Compare files, direct line comparison area: no scrolling

Post by *Flint »

The new direct line comparison block has no scrolling support. If there are two very long lines, it becomes impossible to see them fully.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48079
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [10b1a] Compare files, direct line comparison area: no scrolling

Post by *ghisler(Author) »

As I have explained in the German forum, I wanted to save the spaced needed to show the horizontal scrollbar. The problem is that it has to be shown for lines which are longer than the available space, but not when the lines are shorter. Scrolling to the file could therefore constantly change the height of this section, which would be very annoying.

Your suggestion to scroll via click+drag is intersting. Maybe someone has other good ideas.
Author of Total Commander
https://www.ghisler.com
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

Re: [10b1a] Compare files, direct line comparison area: no scrolling

Post by *Flint »

Ctrl+drag wasn't my suggestion, but it may work, indeed. However, for very long lines it may become inconvenient. With scrollbar you can just quickly drag the runner to the position you want. If you have to drag the long text, it may take many steps of "drag - release - move mouse - drag".

In the Compare It! program which also has this "direct line compare" feature, the scrollbox is always displayed, but it's simply become disabled when the lines are too short. This is the standard behavior for many programs, and it saves from flickering between "shown/hidden" states, so you could do it like that.

There's also a possibility to synchronize scrolling with the main window, but it has many drawbacks compared to individual scrolling control, so I didn't put it into the first post.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48079
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [10b1a] Compare files, direct line comparison area: no scrolling

Post by *ghisler(Author) »

In the Compare It! program which also has this "direct line compare" feature, the scrollbox is always displayed, but it's simply become disabled when the lines are too short. This is the standard behavior for many programs, and it saves from flickering between "shown/hidden" states, so you could do it like that.
Hmm, this would be annoying for most files where the lines are shorter. Maybe an idea would be to not show the scrollbar initially, but show it the first time a very long line is encountered, and then keep it shown (but disabled). What do you think?
Author of Total Commander
https://www.ghisler.com
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

Re: [10b1a] Compare files, direct line comparison area: no scrolling

Post by *Flint »

Hm… I'm not sure, it has to be looked at. This single "jump" still can be annoying. Maybe make an INI option to switch between "show always" and "on first encounter"?
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
Sob
Power Member
Power Member
Posts: 941
Joined: 2005-01-19, 17:33 UTC

Re: [10b1a] Compare files, direct line comparison area: no scrolling

Post by *Sob »

Flint wrote: 2021-03-11, 15:36 UTCThere's also a possibility to synchronize scrolling with the main window, but it has many drawbacks compared to individual scrolling control, so I didn't put it into the first post.
Definitely not this, TortoiseGitMerge has it, and while it allows to at least see everything, it's pretty annoying, because it makes me scroll left and right all the time.

Scrollbar shown always or when first needed, both sound good.
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [10b1a] Compare files, direct line comparison area: no scrolling

Post by *Usher »

Currently Left/Right arrows and Ctrl+Left/Ctrl+Right do the same scrolling action.
I would use Ctrl+Left/Ctrl+Right only to scroll direct line comparison area, no matter which part of the window is focused.
I would also add left/right buttons similar to buttons in tab bar or allow horizontal mouse scrolling when hovering over direct line comparison area.
Andrzej P. Wozniak
Polish subforum moderator
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48079
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [10b1a] Compare files, direct line comparison area: no scrolling

Post by *ghisler(Author) »

Sorry, Ctrl+Left/Ctrl+Right jumps from word to word in edit mode.
Author of Total Commander
https://www.ghisler.com
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [10b1a] Compare files, direct line comparison area: no scrolling

Post by *Usher »

What about Alt+Left/Alt+Right?
Andrzej P. Wozniak
Polish subforum moderator
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48079
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [10b1a] Compare files, direct line comparison area: no scrolling

Post by *ghisler(Author) »

That's used to copy the current line to the other panel in edit mode.
Author of Total Commander
https://www.ghisler.com
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [10b1a] Compare files, direct line comparison area: no scrolling

Post by *Usher »

How can I move from a panel to another one? I can't see any hotkeys described in Help.
Andrzej P. Wozniak
Polish subforum moderator
N_Usul
Junior Member
Junior Member
Posts: 17
Joined: 2003-04-26, 08:04 UTC

Re: [10b1a] Compare files, direct line comparison area: no scrolling

Post by *N_Usul »

ghisler(Author) wrote: 2021-03-11, 14:25 UTC
Your suggestion to scroll via click+drag is intersting. Maybe someone has other good ideas.
and just click and drag?
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

Re: [10b1a] Compare files, direct line comparison area: no scrolling

Post by *Flint »

Confirm that the new scrolling feature is working in b2.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
Post Reply