[TC 10 b3] Thumbnail view crashes

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10 b3] Thumbnail view crashes

Post by *ghisler(Author) »

I found out somehting interesting: Normally I call the OLE interface IThumbnailProvider to load thumbnails with function GetThumbnail. This interface only allows one size parameter, and Total Commander passes the larger of the two (width, height) to it and then resizes the received image.

However, when GetThumbnail fails, Total Commander calls a different interface: IExtractImage.
This involves two calls: First a call to GetLocation where the width and height can be requested.
Then if the first call succeded, a call to Extract which does not take any size parameters, but GetLocation must be called first.

Since your problem only occurs when width and height are different, it means that MediaPreview does not support the IThumbnailProvider interface for mp4. TC then calls the IExtractImage function. So since this is only a fallback, I will call it with a square size in the future (except for folders, Windows seems to stretch them to the requested size).
Author of Total Commander
https://www.ghisler.com
User avatar
freaktenstein
Junior Member
Junior Member
Posts: 12
Joined: 2012-03-18, 08:29 UTC

Re: [TC 10 b3] Thumbnail view crashes

Post by *freaktenstein »

I tested it with Icaros 3.0.2 now - it works! No exits anymore, does not matter which TN size I chose.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10 b3] Thumbnail view crashes

Post by *ghisler(Author) »

Please test this with beta 5! It should no longer crash where older beta versions crashed.
Author of Total Commander
https://www.ghisler.com
User avatar
freaktenstein
Junior Member
Junior Member
Posts: 12
Joined: 2012-03-18, 08:29 UTC

Re: [TC 10 b3] Thumbnail view crashes

Post by *freaktenstein »

For me everything works correctly now!
Post Reply