If a *incomplete* IconLib is setted, some icon feature broken

[dindog]

TC9b12 now shows '!' as expected in all cases when OldListIcons=1:

If no iconlib is defined: '!' is overlayed with TC's internal overlay
If iconlib with '!' icon inside it (icon 49 and 50) is defined: TC overlay with '!' from iconlib.
If iconlib without '!' icon inside it is defined: TC uses icons with integrated '!' from iconlib (icons 9,11, 15, 18).

According to this thread, the current TC icon work as above.
https://www.ghisler.ch/board/viewtopic.php?f=15&t=45252&hilit=hidden+icon&start=15

If the iconlib don't have the independent "!" icon, will use the iconlib's (9,11,15,18), that would even be the case when it is an packed archive. Would it be better if there is no "!" icon, fall back to use the internal "!" icon overlay?

especially by adding a new dim icon option. we don't even need "!" mark at for hidden file at all

[dindog]

I do some search on the forum, found this thread by MVV's, as he said that "it has to have all icon" to make a iconlib work, and that's quite a lot...
Is it possible to let user define only some of the filelist icon using icon_dll+inc, and all omitted icon will fallback to TC's or Explorer default ones?

[ghisler(Author)]

Unfortunately TC wouldn't know where to find the missing icons. Furthermore, they are found by their index, not by name. You may freely copy the icons from the old wcmicons.dll to your own library. You are not allowed to use the new icons - they are licensed from a third party, so only we are allowed to distribute them with Total Commander.

[dindog]

Unfortunately TC wouldn't know where to find the missing icons. Furthermore, they are found by their index, not by name. You may freely copy the icons from the old wcmicons.dll to your own library. You are not allowed to use the new icons - they are licensed from a third party, so only we are allowed to distribute them with Total Commander.

so would you please at least let the dimmed icon work ?
currently TC will use an unknown hidden file icon then dim it, if the iconlib doesn't come with "!" icon

[ghisler(Author)]

Could you send me a test icon lib? This would be very helpful to debug the issue.

[dindog]

2ghisler(Author)
Here is file icon lib on totalcmd.net
http://totalcmd.net/plugring/flatFileIcons.html
It has 37 group icon, and no independent icon for "!" mark, and group 9 & group 18 is "unknown hidden/system" icon.

As long as a file attribute is setted to hidden or system, it will use the unknown filetype whatever the icon display setting or the extension of the file, even it's a ZIP archive.
And the "Dimmed hidden files" works in the manner of dimmimg the unknow hidden/system icon. The show "!" on hidden/system optionn has totally no effect.

As a contrast, if a complete iconlib is setted like this iconlib of TC8 extracted by MVV in the thread
https://www.ghisler.ch/board/viewtopic.php?f=15&t=45429&hilit=hidden+icon
It will dimmed a right icon, and show "!" on hidden/system will work too.

[ghisler(Author)]

Thanks, I will try to reproduce it.

[kesdoputr]

24.11.19 Added: Load "!" overlay icon from EXE if missing in external icon library, e.g. flat_FileIcons.dll (32/64)

"!" overlay icon is shown ok in beta7.

[dindog]

beta7 will dim and draw "!" overlay on correct icon, confirmed.
and I see it also end the "hidden/system file"(icon,8) and "hidden/system folder"(icon,14) support completely, right? Personally, I don't miss it, but I reckon people using incomplete iconlib for years will find their icon changed a lot when they update to 9.5, especially the hidden folder icon change is quite easy to notice, like 9.0 drop the <LNK> icon(icon,11)

[ghisler(Author)]

and I see it also end the "hidden/system file"(icon,8) and "hidden/system folder"(icon,14) support completely, right?

Didn't you ask for that? Replacing the separate hidden/system file icon by normal icon plus "!" overlay?

[dindog]

and I see it also end the "hidden/system file"(icon,8) and "hidden/system folder"(icon,14) support completely, right?

Didn't you ask for that? Replacing the separate hidden/system file icon by normal icon plus "!" overlay?

Sorry, my bad. I've been comparing the icon behavior mostly between TC8.5 and the current beta, I thought the hidden folder icon was still used when "show overlay" was unchecked. I didn't realize TC's been using same folder icon for both normal folder and hidden/system folder since 9.2.