[unchanged - but argued] TC 9.50 - SAVESELECTION, SAVEDETAILS and SAVETABS silently fails

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

[unchanged - but argued] TC 9.50 - SAVESELECTION, SAVEDETAILS and SAVETABS silently fails

Post by *petermad »

If I have a button like:

Code: Select all

TOTALCMD#BAR#DATA
SAVESELECTION
"%PLIST.txt"
wcmicons.dll,43
Save selection to file


-1
or

Code: Select all

TOTALCMD#BAR#DATA
SAVEDETAILS
"%PLIST.txt"
wcmicons.dll,43
Save selection with all details to file


-1
or

Code: Select all

TOTALCMD#BAR#DATA
SAVEDETABS
"%PTABS.tab"
wcmicons.dll,43
Save tabs to .tab file


-1
And TC is not able to write to the current directory - because it is write-protected, on a Network share, on an FTP-site, in a Filesystem plugin or in a Virtual folder - then TC fails without any notice - an error message saying that the file could not be saved would be espected.
Last edited by petermad on 2020-02-08, 16:39 UTC, edited 3 times in total.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.50 - SAVESELECTION, SAVEDETAILS and SAVETABS silently fails

Post by *ghisler(Author) »

The function is meant to be silent, so no error message will be shown when it fails.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: TC 9.50 - SAVESELECTION, SAVEDETAILS and SAVETABS silently fails

Post by *petermad »

Hmm, a pity.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Re: [unchanged] TC 9.50 - SAVESELECTION, SAVEDETAILS and SAVETABS silently fails

Post by *DrShark »

ghisler(Author) wrote: 2020-02-07, 17:09 UTC The function is meant to be silent, so no error message will be shown when it fails.
Some time ago I suggested to use FTP connection status bar or self-closing tooltips to show the information that doesn't require further actions from user. There is also my suggestion on adding additional status bar(s) for such purpose...
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
Dalai
Power Member
Power Member
Posts: 9364
Joined: 2005-01-28, 22:17 UTC
Location: Meiningen (Südthüringen)

Re: [unchanged] TC 9.50 - SAVESELECTION, SAVEDETAILS and SAVETABS silently fails

Post by *Dalai »

Honestly I think TC should give some kind of feedback if any of these commands fail. As it is right now, the user can only assume that the command completed successfully while in reality it could be either successful or not. Imagine a user has one of these commands on a button, but something changed outside of TC's scope, e.g. NTFS permissions, and saving fails. Now the user wonders why that is, and finds that TC doesn't complain about not being able to save something - and then that user complains here in the forum about it (rightfully so IMO).

The Linux way of doing things - if everything is OK, don't output anything, but if something fails, fail fast and tell the user about what went wrong - is a good guideline IMO.

Regards
Dalai
#101164 Personal licence
Ryzen 5 2600, 16 GiB RAM, ASUS Prime X370-A, Win7 x64

Plugins: Services2, Startups, CertificateInfo, SignatureInfo, LineBreakInfo - Download-Mirror
User avatar
Horst.Epp
Power Member
Power Member
Posts: 6449
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Re: TC 9.50 - SAVESELECTION, SAVEDETAILS and SAVETABS silently fails

Post by *Horst.Epp »

ghisler(Author) wrote: 2020-02-07, 17:09 UTC The function is meant to be silent, so no error message will be shown when it fails.
A command should never fail silently.
That gives all sort of surprises il the results are used later.
Windows 11 Home x64 Version 23H2 (OS Build 22631.3374)
TC 11.03 x64 / x86
Everything 1.5.0.1371a (x64), Everything Toolbar 1.3.2, Listary Pro 6.3.0.69
QAP 11.6.3.2 x64
User avatar
Ovg
Power Member
Power Member
Posts: 756
Joined: 2014-01-06, 16:26 UTC

Re: TC 9.50 - SAVESELECTION, SAVEDETAILS and SAVETABS silently fails

Post by *Ovg »

Dalai wrote: 2020-02-08, 13:25 UTC Honestly I think TC should give some kind of feedback if any of these commands fail.
Horst.Epp wrote: 2020-02-08, 14:30 UTC A command should never fail silently.
Support ++ !!!
It's impossible to lead us astray for we don't care even to choose the way.
#259941, TC 11.01 x64, Windows 7 SP1 x64
User avatar
Stefan2
Power Member
Power Member
Posts: 4132
Joined: 2007-09-13, 22:20 UTC
Location: Europa

Re: TC 9.50 - SAVESELECTION, SAVEDETAILS and SAVETABS silently fails

Post by *Stefan2 »

ghisler(Author) wrote: 2020-02-07, 17:09 UTC The function is meant to be silent, so no error message will be shown when it fails.

>> "so no error message will be shown when it fails."

Me think that is no good :?





 
Post Reply