Unused DLL after upgrade 9.51 to 10.00b1

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: white, Hacker, petermad, Stefan2

Slavic
Senior Member
Senior Member
Posts: 290
Joined: 2006-02-26, 15:41 UTC
Location: Montenegro

Unused DLL after upgrade 9.51 to 10.00b1

Post by *Slavic »

I installed TC beta over my previous 9.51 installation in C:\Program Files\ (btw, glad to note that it's now a default path). However, among some configuration files left unchanged from 9.51, as it supposed, one looks definitely outdated:

Code: Select all

TCKEYHANDLER64.DLL 	61.928  11/03/2020  9:51
I doubt that it is required for v10 because installer would have overwritten it with new version, even if DLL was the same internally. Apparently it isn't required for new version anymore. Could this remnant be detected and automatically deleted during installation as version upgrade?
Desktop: Windows 11 Pro 23H2, TC 11.03(RC). Mobile: Pixel 5a, Android 14, TC 3.42b5
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Unused DLL after upgrade 9.51 to 10.00b1

Post by *petermad »

This also applies to the obsolete files:
TCKEYHANDLER.DLL
EVERYTHING32.DLL
EVERYTHING64.DLL
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
beb
Senior Member
Senior Member
Posts: 430
Joined: 2009-09-20, 08:03 UTC
Location: Odesa, Ukraine

Re: Unused DLL after upgrade 9.51 to 10.00b1

Post by *beb »

Slavic wrote: 2021-03-14, 19:54 UTC TCKEYHANDLER64.DLL
petermad wrote: 2021-03-14, 23:52 UTC TCKEYHANDLER.DLL
EVERYTHING32.DLL
EVERYTHING64.DLL
I don't have any of those after the same upgrade, so maybe they're somehow user-actions-specific.
#278521 User License
Total Commander [always the latest version, including betas] x86/x64 on Win10 x64/Android 10
TW
Senior Member
Senior Member
Posts: 383
Joined: 2005-01-19, 13:35 UTC

Re: Unused DLL after upgrade 9.51 to 10.00b1

Post by *TW »

petermad wrote: 2021-03-14, 23:52 UTC This also applies to the obsolete files:
TCKEYHANDLER.DLL
EVERYTHING32.DLL
EVERYTHING64.DLL
i don't have those. :?: where do they come from? they aren't in the installer either.
EVERYTHINGXX.DLL is part of the everything SDK but wasn't needed in recent TC versions i guess.

but i see UNRAR9X.DLL is absent in 10.0
licenced and happy TC user since 1994 (#11xx)
gdpr deleted 6
Power Member
Power Member
Posts: 872
Joined: 2013-09-04, 14:07 UTC

Re: Unused DLL after upgrade 9.51 to 10.00b1

Post by *gdpr deleted 6 »

TW wrote: 2021-03-15, 11:50 UTC i don't have those. :?: where do they come from? they aren't in the installer either.
For a time, they were part of some installers. I however don't know with confidence whether only for release candidates/betas, or whether they made in into the installers for final releases too. You can check the history of these files in ... history.txt (unfortunately only tracked by calendar date, not by TC version).
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Re: Unused DLL after upgrade 9.51 to 10.00b1

Post by *DrShark »

OK, I understand that it's a rare case, but for test purposes sometimes it's handy to launch different versions of TC by putting their exe and some additional files into the dir of main TC copy, so they automatically use current TC settings.
My suggestion then, if TC installer will be able to delete the files not used by TC version it installs, to list such files in installer's dialog and ask whether user wants to delete them.
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Unused DLL after upgrade 9.51 to 10.00b1

Post by *petermad »

TCKEYHANDLER.DLL was for the 32bit version of TC

TCKEYHANDLER.DLL and TCKEYHANDLER64.DLL was used in TC 9.51 rc3 -> TC 9.51 rc5
EVERYTHING32.DLL and EVERYTHING64.DLL was used in TC 9.0 b2 -> TC 9.0 rc3

So only beta version users could have these files.
history.txt wrote: 16.03.20 Fixed: Lister, Explorer preview: Use WH_KEYBOARD_LL hook instead of WH_KEYBOARD, so tckeyhandler.dll/tckeyhandler64.dll is no longer needed (32/64)

24.02.20 Fixed: ESC and TAB didn't work in Lister with Explorer preview, use tckeyhandler.dll/tckeyhandler64.dll for temporary WH_KEYBOARD hook. A global hook is used only when the preview is loaded in a separate process (32/64)

30.10.16 Fixed: Everything dlls are no longer needed, replaced by internal code calling the Everything service directly. Necessary because the dlls didn't support the new Everything 1.4 functions yet (32/64)

09.06.16 Fixed: Search with "Everything" wasn't working, because Everything32.dll/Everything64.dll wasn't included (32/64)


TW wrote:but i see UNRAR9X.DLL is absent in 10.0
Maybe Ghisler gave up support for Windows 95 and 98 ?
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Slavic
Senior Member
Senior Member
Posts: 290
Joined: 2006-02-26, 15:41 UTC
Location: Montenegro

Re: Unused DLL after upgrade 9.51 to 10.00b1

Post by *Slavic »

petermad wrote: 2021-03-15, 12:49 UTC So only beta version users could have these files.
You suppose that all beta testers should carefully read history.txt and manually remove no longer needed files, even if they weren't asked to do this directly? But I still believe that it's a matter of installer to get us rid of unused files. Who else can know for sure what is required for new version and what isn't? Sorry if it's my delusion...
Desktop: Windows 11 Pro 23H2, TC 11.03(RC). Mobile: Pixel 5a, Android 14, TC 3.42b5
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Unused DLL after upgrade 9.51 to 10.00b1

Post by *petermad »

2Slavic
You suppose that all beta testers should carefully read history.txt and manually remove no longer needed files
No - I just explained why beb and TW probably could not see some of these files.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Unused DLL after upgrade 9.51 to 10.00b1

Post by *ghisler(Author) »

but i see UNRAR9X.DLL is absent in 10.0
I removed it because one virus scanner on virustotal reports a vulnerability in it. Newer patched unrar.dll versions do not run on Windows 9x/ME, and all older versions are vunerable for path traversals (e.g. putting a file in the Windows dir when unpacking).
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Unused DLL after upgrade 9.51 to 10.00b1

Post by *petermad »

I removed it because one virus scanner on virustotal reports a vulnerability in it.
If a person with Windows 9x still have the UNRAR9X.DLL in his TC 10 program folder, will TC 10 then use it?
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Unused DLL after upgrade 9.51 to 10.00b1

Post by *ghisler(Author) »

If a person with Windows 9x still have the UNRAR9X.DLL in his TC 10 program folder, will TC 10 then use it?
Yes it will. The risk that Windows 9x gets targeted is very low.
Author of Total Commander
https://www.ghisler.com
Slavic
Senior Member
Senior Member
Posts: 290
Joined: 2006-02-26, 15:41 UTC
Location: Montenegro

Re: Unused DLL after upgrade 9.51 to 10.00b1

Post by *Slavic »

TC 10.00b2 installed as upgrade from 10.00b1a: TCKEYHANDLER64.DLL still exists.

I keep this file hoping that one time the installer will detect it properly. But if this feature (and deleting other obsolete DLLs) isn't planned, please inform us, it's not a problem to delete such files manually.
Desktop: Windows 11 Pro 23H2, TC 11.03(RC). Mobile: Pixel 5a, Android 14, TC 3.42b5
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: Unused DLL after upgrade 9.51 to 10.00b1

Post by *Usher »

2Slavic
TCkeyHandler*.dll should be deleted by TC9.51 installer. However, there may still exist because they are left in description.ini

Code: Select all

TASTEN.TXT German list of commands with keyboard shortcuts
tckeyhandler.dll Handle ESC and TAB keys in Explorer preview in Lister (32-bit)
tckeyhandler64.dll Handle ESC and TAB keys in Explorer preview in Lister (64-bit)
As you can see, there is another unused file listed - TASTEN.TXT should exist only in Deutsch descript.ion.
Andrzej P. Wozniak
Polish subforum moderator
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Re: Unused DLL after upgrade 9.51 to 10.00b1

Post by *DrShark »

ghisler(Author) wrote: 2021-03-15, 18:30 UTC
but i see UNRAR9X.DLL is absent in 10.0
I removed it because one virus scanner on virustotal reports a vulnerability in it. Newer patched unrar.dll versions do not run on Windows 9x/ME, and all older versions are vunerable for path traversals (e.g. putting a file in the Windows dir when unpacking).
Isn't the UnRAR code open source? Or the binary of UnRAR.dll from RarLab has some proprietary parts that aren't based on opened code which is hard/impossible to reimplement? I mean, could Christian provide with TC own build of UNRAR9X.DLL with fixed vulnerability (if UnRAR code license allows this)?
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
Post Reply