[Small Bug] Bug on Cursor Font Color.

Please report only one bug per message!

Moderators: sheep, Hacker, Stefan2, white

islogged
Senior Member
Senior Member
Posts: 205
Joined: 2008-09-17, 00:57 UTC

Post by *islogged » 2016-03-27, 00:41 UTC

Okay lets again explain my point of view:
The bug is the label "Cursor Font" (which should be called "Inverted Font") because it's only available if one of the use inverted ... options is active.
TC uses this color as font color for either inverted cursor (State2) or inverted selection (State3) to give the user more possibilities for the color of inverted bars.
Then you have already a problem in one case > [Mark+Cursor] in State 2 < where it's not true.
It's Inverted but don't get the Cursor_Font color ...
another solution can be to introduce an additional "Mark Font" color which would add more complexity to the user interface.
It can be great to add another variable right, but as i told and just for solve this current actual Bug we really no need it !

I quote my fix again - State 3 Inverted Selection - http://i.imgur.com/79HGtcf.jpg
example.[Mark].Font == user.Font_Color <=(blue in the jpg capture)
example.[Cursor].Font == user.Cusor_Font <=(green in the jpg capture)
example.[Mark+Cursor].Font == user.Cusor_Font <=(green in the jpg capture)
Easy :wink:
And hope we are Ok now !

User avatar
petermad
Power Member
Power Member
Posts: 8201
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Post by *petermad » 2016-03-27, 01:09 UTC

2islogged
TC uses this color as font color for either inverted cursor (State2) or inverted selection (State3)
Notice the word "either" - of course the font color of marked and highligted items (the item where the cursor is on) doesn't need to be set by itself, it has to have the same font color as the marked but not highlighted items.
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.92b1 on Android 6.0
Get: Extended Total Commander Menus | PHSM-Calendar

User avatar
HolgerK
Power Member
Power Member
Posts: 5051
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Post by *HolgerK » 2016-03-27, 01:16 UTC

Then you have already a problem in one case > [Mark+Cursor] in State 2 < where it's not true.
It's Inverted but don't get the Cursor Font color ...
You mean this: http://i.imgur.com/kxP6VpK.jpg
That was the point where I wrote:
HolgerK wrote:You will not be able to see any difference between selected or not for the file under the inverted cursor bar.
answering to
islogged wrote:
The problem is that there is no difference between a mark font and a cursor font -color ... ATM there is only one inverted bar possible (either "inverted cursor" or "inverted selection").
There is ... as you can see here: http://i.imgur.com/kxP6VpK.jpg
[Cursor] font is green
[Mark + Cursor] font is brown
... and both are Inverted !

islogged wrote:I quote my fix again - State 3 Inverted Selection - http://i.imgur.com/79HGtcf.jpg
example.[Mark].Font == user.Font_Color <=(blue in the jpg capture)
example.[Cursor].Font == user.Cusor_Font <=(green in the jpg capture)
example.[Mark+Cursor].Font == user.Cusor_Font <=(green in the jpg capture)
This will not fix the contrast problem between foreground and background color.
Especially the "Inverted Font" color is chosen as light color (high contrast with the dark selection bar) and has a very bad contrast with the white background.
Easy Wink
No.

Regards
Holger

User avatar
HolgerK
Power Member
Power Member
Posts: 5051
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Post by *HolgerK » 2016-03-27, 01:28 UTC

example.[Cursor].Font == user.Cusor_Font <=(green in the jpg capture)
One additional point:
With non inverted cursor (rectangle) the color by file type is usable.
Your suggestion to solve the problem will break this feature.

Regards
Holger

islogged
Senior Member
Senior Member
Posts: 205
Joined: 2008-09-17, 00:57 UTC

Post by *islogged » 2016-03-27, 04:05 UTC

You mean this: http://i.imgur.com/kxP6VpK.jpg
That was the point where I wrote:
HolgerK a écrit:
You will not be able to see any difference between selected or not for the file under the inverted cursor bar.
Yes i mean this, this is the state 2, and state 2 is not bugged.

And unlike as you told, you can see the difference :
[Cursor] : Green on Red
[Mark+Cursor] : Brown on Red
Can you see the difference ? Answer is Yes

Then all is Ok here !

----------------------->
This will not fix the contrast problem between foreground and background color
Especially the "Inverted Font" color is chosen as light color (high contrast with the dark selection bar) and has a very bad contrast with the white background.

??? Don't understand, need Capture for Example of your problem !
One additional point:
With non inverted cursor (rectangle) the color by file type is usable.
Your suggestion to solve the problem will break this feature.
I use myself color by file type and nothing is broken ...
??? Don't understand, need Capture for Example of your problem !

----------------------->

For now, nothing and no concrete evidence for me, then i stay on my position (sorry)
It's a small Bug who can be easily solved as i told in 1 minute of coding ...

User avatar
HolgerK
Power Member
Power Member
Posts: 5051
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Post by *HolgerK » 2016-03-27, 09:05 UTC

Save this as demo.ini
and enter from the commandline of TC
%COMMANDER_EXE% /I=<PATH>\Demo.ini

Code: Select all

[Selection]
0=*.txt
[Colors]
ColorFilter1=*.txt
ColorFilter1Color=32768
InverseCursor=0
InverseSelection=1
BackColor=-1
BackColor2=-1
ForeColor=-1
MarkColor=-1
CursorColor=-1
CursorText=-1
Only modification starting from default settings is
[x] use inverted selection
Color filter green for Text-files

Better you can see it live than a screen capture.

Regards
Holger

islogged
Senior Member
Senior Member
Posts: 205
Joined: 2008-09-17, 00:57 UTC

Post by *islogged » 2016-03-27, 18:16 UTC

Done !
And even with you Example the only problem i see is the Bug i exposed on the first message of this Topic !
Windows 10 - Tc 64bit
The "Cursor Font" color change the "Mark Font" color and not the "Cursor Font" color as promised !
Capture of the bug : http://imgur.com/Kq3Pdib.jpg
You seem to find problems where no have. (like here: http://ghisler.ch/board/viewtopic.php?t=43732&highlight=)
Maybe you speak (i try to imagine) about the current cursor who change the font color of the fileTypeFont color. (is that ?)

Then it's a normal behavior ( http://imgur.com/jhhJi5u ), and it's already like that TC work
Try Inverted Cursor - State 2 and change the color of Cursor font ! <= Current behavior of TC and it's not a BUG !

Of course the current cursor can change the color background or the font color to make distinction.

Maybe you don't understand how TC color work ?

Now i already spent to many time to answer you. i going angry
And i ask myself if you are a Joke or Troll (sorry)

All my points, all my post are proved ! (even with so many captures)
Until now you proved nothing ! (sorry)

The original bug is simple and the solution was given (many times).
I lost my time here !

User avatar
HolgerK
Power Member
Power Member
Posts: 5051
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Post by *HolgerK » 2016-03-27, 18:47 UTC

islogged wrote:The original bug is simple and the solution was given (many times).
Summarize:
Your Bug:
The "Cursor Font" color change the "Mark Font" color and not the "Cursor Font" color as promised !
http://imgur.com/Kq3Pdib
Your Solution:
example.[Cursor].Font == user.Cusor.Font
example.[Mark+Cursor].Font == user.Cusor.Font
Which means that the font color of the rectangle (non inverted cursor) should be set to the same as the font color of the inverted selection/mark.

Make this the new default behavior and my simple modification started from TC's default settings would lead to the result that with one single click ([x] use inverted Selection) the text of the cursor will be shown as white text on white background.
I lost my time here !
Me too.
You are so focused on your special color combination that this is really annoying.
:(
Holger

islogged
Senior Member
Senior Member
Posts: 205
Joined: 2008-09-17, 00:57 UTC

Post by *islogged » 2016-03-27, 19:32 UTC

Your Solution:
Citation:
example.[Cursor].Font == user.Cusor.Font
example.[Mark+Cursor].Font == user.Cusor.Font

Which means that the font color of the rectangle (non inverted cursor) should be set to the same as the font color of the inverted selection/mark.
First you change my solution !

My solution is not :
example.[Cursor].Font == user.Cusor.Font
example.[Mark+Cursor].Font == user.Cusor.Font
My solution is: http://i.imgur.com/79HGtcf.jpg
example.[Mark].Font == user.Font_Color <=(blue in the jpg capture)
example.[Cursor].Font == user.Cusor_Font <=(green in the jpg capture)
example.[Mark+Cursor].Font == user.Cusor_Font <=(green in the jpg capture)
With my Solution and on the base of this Capture http://i.imgur.com/79HGtcf.jpg
The font color of the rectangle (non inverted cursor)
Become GREEN

With my Solution and on the base of this Capture http://i.imgur.com/79HGtcf.jpg
set to the same as the font color of the inverted selection/mark.
The Select/Mark font color become BLUE.

>> Then it's Different ID color !
>> Then my solution work !

How many time i explain you that in the past like here :
In State 3, files Inverted are also files Selected.
And as you can see here (With my Solution) : http://i.imgur.com/79HGtcf.jpg

Files : Blue on White
Cursor on a File : Green on White (with red border here)
Selected Files : Blue on Brown
Cursor on a Selected File : Green on Brown
If i can give you advice, read 2 or 3 times my posts before to answer me !
You seem to read too fast !
Last edited by islogged on 2016-03-27, 19:55 UTC, edited 2 times in total.

User avatar
HolgerK
Power Member
Power Member
Posts: 5051
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Post by *HolgerK » 2016-03-27, 19:52 UTC

islogged wrote:If you look in the Example Panel here: http://i.imgur.com/79HGtcf.jpg
- Font of [Mark] must be Blue and not Green as it is. <= The Bug
- Font of [Cursor] must be Green and not Blue as it is. <= The Bug
- Font of [Mark + Cursor] is Ok !
Isn't this exactly what I try to describe.
Replace your special colors with the default colors (+ default white background):
- Font of [Mark] must be Black and not White as it is.
- Font of [Cursor] must be White and not Black as it is.
This really becomes ridiculous.
Apply your simple fix and thousands of TC user will not be able to read the text under the cursor after updating to TC 9.0.

You should think 2 or 3 times over such easy/simple fixes before posting.

Regards
Holger

islogged
Senior Member
Senior Member
Posts: 205
Joined: 2008-09-17, 00:57 UTC

Post by *islogged » 2016-03-27, 20:27 UTC

Ok !
For the First time i think i get the point of the (pseudo-) problem you expose in your last message !

You want to tell that if i we apply my fix as this :
example.[Mark].Font == user.Font_Color
example.[Cursor].Font == user.Cusor_Font
example.[Mark+Cursor].Font == user.Cusor_Font
With the Default color of TC, the [Cursor] get a White (font) on White (background) !!!
I can easily answer (and solve) that, anyway before to do i want to be sure it's the only problem you really want to expose (if we apply my solution).
And after i answer to that ...

Because in the past and by experience you always changed the problems in the discuss.
Then it's impossible to have a follow treat problem conversation.

Then my question is : Is it only that the problem you expose ? => (dixit: a white font cursor on a white background with the default color settings)

User avatar
HolgerK
Power Member
Power Member
Posts: 5051
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Post by *HolgerK » 2016-03-27, 21:05 UTC

islogged wrote:Then my question is : Is it only that the problem you expose ? (dixit: a white font cursor on a white background with the default color settings)
No this is not the only one.
Your suggestions to fix the problem also include to set the font color of the inverted selection(mark) to the default font color.
This will reduce the number of usable colors for mark color( combined with the default text color) and create additional compatibility problems.

That's why my suggestion was to rename "Cursor Font" to "Inverted Font".
As an alternative the introduction of a second color for the "Mark Font" can clarify the UI (and offer the possibility to select wider range of color pairs for the inverted selection).
But this may also lead to some compatibility problems.

And these all are no pseudo problems which can be easily solved as you told in 1 minute of coding ... :?

Regards
Holger

islogged
Senior Member
Senior Member
Posts: 205
Joined: 2008-09-17, 00:57 UTC

Post by *islogged » 2016-03-27, 21:36 UTC

Your suggestions to fix the problem also include to set the font color of the inverted selection(mark) to the default font color.
No !

The Solution of the last question is to set a different default matrice color who match better well, Example :

Default Cursor Font = Blue (or whatever better then blue but no white)
A capture of this Example : http://imgur.com/j3VTswF.jpg

And with my corrected solution (who work) you easily get :
IDColor01 for [Files] > Black font on White background
IDColor02 for [Cursor on a File] > Blue font on White background
IDColor03 for [Selected Files] > Black font on Red backgound
IDColor04 for [Cursor on a Selected File] > Blue font on Red backgound

For the others problems you expose, i don't understand because for me there is no others compatibility problem.
And at finally the user can always change the colors to obtain a better rendering or a better compatibility.
That's why my suggestion was to rename "Cursor Font" to "Inverted Font".
It's not a good suggestion because it's not the way how TC work.
Inverted Font can have differents font color as i already told at many times, and as you can check here http://i.imgur.com/zuwRlsm.jpg in the State 2 (state who work perfectly, with no bugs)

User avatar
HolgerK
Power Member
Power Member
Posts: 5051
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Post by *HolgerK » 2016-03-27, 22:00 UTC

islogged wrote:
Your suggestions to fix the problem also include to set the font color of the inverted selection(mark) to the default font color.
No !
Do we start again at the beginning?
- Font of [Mark] must be Blue and not Green as it is. <= The Bug
For the others problems you expose, i don't understand because for me there is no others compatibility problem.
And at finally the user can always change the colors for obtain a better render.
Yes for you, but what about other users?
That's why my suggestion was to rename "Cursor Font" to "Inverted Font".
It's not a good suggestion because it's not the way how TC work.
It's exactly how TC works at the moment.

I'm now out of this discussion.
No real arguments or solutions from your side other than:
It's working for me. I don't understand your problem.. You mixed the topics. It easy to fix...
Let's wait for Christian's answer on this topic.

:(
Holger

islogged
Senior Member
Senior Member
Posts: 205
Joined: 2008-09-17, 00:57 UTC

Post by *islogged » 2016-03-28, 01:00 UTC

My GOD !!!
It's not possible !!!

Each time i answered you with proofs and captures proofs of what i explain, you just always ignore it, back to an old message and speak to another thing.
In my country we call that: "Noyer le poisson dans l'eau"

And you already did that in the past with this thread : http://ghisler.ch/board/viewtopic.php?t=43732&highlight=&sid=cabd4db0c31d885cc8e572d789c1989c
Are you Ok in your life ?
Yes for you, but what about other users?
Same Same, no problem for nobody ! (only for you)
It's exactly how TC works at the moment.
No and until now i proved it with my last message.
No real arguments or solutions from your side
Are you serious? - Is that a joke?
I don't believe!
I'm now out of this discussion.
Ok, but can you out of my next Topics also, because i'm so tired (as you) with surreals debates.
Thanks!

--------------------------------------------->

For the Others, the Final Solution i suggest since the begin its this one (Image retouching): => http://i.imgur.com/Tc9XrCy.jpg
with a Default Cursor Font = blue (or a Ghisler color different of the actual default white)

Thanks

Post Reply