[9.0a]Crash when pressing F1 when exiting help.

[hit02]

Totalcmd crashes when user tries to close help window with F1 key pressed.

How to reproduce:
Press F1 to open help and don't lift the key.
Then press X icon to close help.

Problem seems to reproduce more often when help is opened from lister, or when F1 and F2 are pressed simultaneously.

My totalcmd version is 9.0a 64 bit (2016-12-14)

[petermad]

I can reproduce this with TC 9.12 x 64, but not with the 32bit version.

But what a weird idea to keep holding down the F1 key

[Horst.Epp]

Totalcmd crashes when user tries to close help window with F1 key pressed.

How to reproduce:
Press F1 to open help and don't lift the key.
Then press X icon to close help.

Problem seems to reproduce more often when help is opened from lister, or when F1 and F2 are pressed simultaneously.

My totalcmd version is 9.0a 64 bit (2016-12-14)

Solution for this "Problems" is simple
don't make such strange key presses which no one ever does.

[hit02]

Haha I know it's strange.
Tried to keep F2 pressed using something heavy to automaticly see changes in file and accidently discovered it.

[Dalai]

Can't reproduce it, neither with TC 9.0a x64 nor 9.12 x64 (on Win7).

Regards
Dalai

[ghisler(Author)]

No crash here either on Windows 7 x64...

[petermad]

Hmm, I can reproduce it every time, also with a clean ini file.

Just do it from the main TC screen - Press F1 and keep it down and then click on the red X in the upper right corner of the Help window.

TC 9.12 x64 under Windows 7, Windows 8.1 and Windows 10

[ghisler(Author)]

No crash here on Windows 7 and 10, sorry. The help just re-opens after a few seconds.

[petermad]

Hmm, I tried on the same 3 computers with the same result, but alo tried on 2 other Windows 7 PC's, where I cannot reproduce it on one of them but can on the other.

So that is on 4 out of 5 PC's where I can reproduce it - but it also shows that it is not 100% reproducible - so maby you should try it on some other conputers...

[Horst.Epp]

Hmm, I tried on the same 3 computers with the same result, but alo tried on 2 other Windows 7 PC's, where I cannot reproduce it on one of them but can on the other.

So that is on 4 out of 5 PC's where I can reproduce it - but it also shows that it is not 100% reproducible - so maby you should try it on some other conputers...

Thats wasting time for situation which never comes for any normal use

[petermad]

Thats wasting time for situation which never comes for any normal use

That's right...

[Stefan2]

no, that's fun on hunting a bug










 

[tuska]

The fun on the matter can go by quickly.

Well,
- let's do a PC restart
- press F1, then press this button down again and keep pressing, afterwords click quickly on the "x" several times

Sometimes TC crashes on the first click on the "X" and sometimes only after the fourth or sixth attempt.
TC 9.12 - 32 bit + 64 bit, Windows 10 Pro (x64) Version 1709 (Build 16299.125)

Nice side effect:
If the browser (EDGE) has been opened first, then TC has crashed and F1 is still pressed,
it will be switched back to the browser and new tabs will be created there.

Therefore, please do not forget to let go of the F1 key at some point!

[DrShark]

I could reproduce this crash when holding F1 key while closing CHM Help with mouse here on Vista 32-bit.

I sent dumps to Christian Ghisler, he wrote it looks like it's a bug in Windows HTML Help Viewer, and dumps don't have hints on possible workaround.

Calls from dump's stack trace:

Code: Select all

mshtml!DllCanUnloadNow+0x1399
mshtml!DllCanUnloadNow+0x1e58
mshtml!DllCanUnloadNow+0x5d86
mshtml!DllCanUnloadNow+0x5d1d
ieframe!Ordinal160+0x20b5
ieframe!Ordinal160+0x2947
ieframe!Ordinal160+0x28c1
ieframe!Ordinal162+0x39e2
ieframe!Ordinal160+0x2da0
ieframe!Ordinal160+0x2ee0
ieframe!Ordinal153+0x4a1c
ieframe!Ordinal153+0x4c7a
ieframe!Ordinal234+0x67cb
user32!GetWindowLongW+0x4b3
user32!GetWindowLongW+0x58b
user32!ReleaseDC+0x7d
user32!WCSToMBEx+0xcc
ntdll!KiUserCallbackDispatcher+0x2e
ieframe!Ordinal153+0x5472
ieframe!Ordinal153+0x561f

[ghisler(Author)]

Yes, as you can see in the log, there is no trace of Total Commander code in it.